[
https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13909105#comment-13909105
]
Lars Hofhansl commented on HBASE-7295:
--
I haven't see any convincing evidence that th
[
https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13909020#comment-13909020
]
Mubarak Seyed commented on HBASE-7295:
--
Is there any update on this issue? Thanks.
>
[
https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13639262#comment-13639262
]
Varun Sharma commented on HBASE-7295:
-
I attached two files comparing performance of v
[
https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13605838#comment-13605838
]
Varun Sharma commented on HBASE-7295:
-
We are not seeing any issues on the thrift gate
[
https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13605729#comment-13605729
]
stack commented on HBASE-7295:
--
This doesn't make sense:
{code}
- protected final PoolMap c
[
https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13605711#comment-13605711
]
Lars Hofhansl commented on HBASE-7295:
--
Double checked locking is fine when the varia
[
https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13605664#comment-13605664
]
Varun Sharma commented on HBASE-7295:
-
Lars,
I maybe forgetting but is it because of
[
https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13605621#comment-13605621
]
Lars Hofhansl commented on HBASE-7295:
--
I know we went through this before, but just
[
https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13605586#comment-13605586
]
Ted Yu commented on HBASE-7295:
---
I ran TestRowProcessorEndpoint with trunk patch v4 and it p
[
https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13603655#comment-13603655
]
Varun Sharma commented on HBASE-7295:
-
I also ran the test for 0.94 - those passed (th
[
https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13602557#comment-13602557
]
Hadoop QA commented on HBASE-7295:
--
{color:red}-1 overall{color}. Here are the results o
[
https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13602025#comment-13602025
]
Varun Sharma commented on HBASE-7295:
-
I would like to revive this issue. We have been
[
https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13551490#comment-13551490
]
Gary Helmling commented on HBASE-7295:
--
The HBASE-7460 changes don't directly touch t
[
https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13550929#comment-13550929
]
stack commented on HBASE-7295:
--
[~ghelmling] Work in HBASE-7460 could fix this when it remove
[
https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543664#comment-13543664
]
Varun Sharma commented on HBASE-7295:
-
No, I don't have a matching number of handlers
[
https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13536297#comment-13536297
]
Lars Hofhansl commented on HBASE-7295:
--
Yeah, maybe use ConcurrentHashMap.putIfAbsent
[
https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13536173#comment-13536173
]
Varun Sharma commented on HBASE-7295:
-
I cannot really make "connection" volatile sinc
[
https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13530655#comment-13530655
]
Hadoop QA commented on HBASE-7295:
--
{color:red}-1 overall{color}. Here are the results o
[
https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13530138#comment-13530138
]
Lars Hofhansl commented on HBASE-7295:
--
In fact I had misread the whole patch (looked
[
https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13530128#comment-13530128
]
Lars Hofhansl commented on HBASE-7295:
--
Indeed. You're right of course.
[
https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13530123#comment-13530123
]
Hiroshi Ikeda commented on HBASE-7295:
--
It is meaningless to chage the final instance
[
https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529483#comment-13529483
]
Lars Hofhansl commented on HBASE-7295:
--
Will commit unless there are objections.
[
https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528703#comment-13528703
]
Hadoop QA commented on HBASE-7295:
--
{color:red}-1 overall{color}. Here are the results o
[
https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528669#comment-13528669
]
Varun Sharma commented on HBASE-7295:
-
We are not seeing the contention issues now - n
[
https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528666#comment-13528666
]
Lars Hofhansl commented on HBASE-7295:
--
Looks good. Is there any way for you to repro
[
https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528659#comment-13528659
]
Hadoop QA commented on HBASE-7295:
--
{color:red}-1 overall{color}. Here are the results o
[
https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528338#comment-13528338
]
Varun Sharma commented on HBASE-7295:
-
Hi Lars,
Interesting, I did not know all this
[
https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528331#comment-13528331
]
Lars Hofhansl commented on HBASE-7295:
--
Thanks Varun.
Double checked locking only wo
[
https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528236#comment-13528236
]
Varun Sharma commented on HBASE-7295:
-
Okay - I can completely do away with the PoolMa
[
https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528138#comment-13528138
]
Lars Hofhansl commented on HBASE-7295:
--
Looking at the 0.94, maybe it's fine to pull
[
https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528088#comment-13528088
]
Hadoop QA commented on HBASE-7295:
--
{color:red}-1 overall{color}. Here are the results o
[
https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528083#comment-13528083
]
Hadoop QA commented on HBASE-7295:
--
{color:red}-1 overall{color}. Here are the results o
[
https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528073#comment-13528073
]
Varun Sharma commented on HBASE-7295:
-
Attached trunk-v2 with the fixes.
[
https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528065#comment-13528065
]
Ted Yu commented on HBASE-7295:
---
Latest trunk patch looks good.
{code}
+// Recheck s
[
https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528066#comment-13528066
]
Varun Sharma commented on HBASE-7295:
-
Hmm, i did "mvn package -DskipTests" - maybe si
[
https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528060#comment-13528060
]
Ted Yu commented on HBASE-7295:
---
What command did you use to build trunk ?
The following com
[
https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13527983#comment-13527983
]
Hadoop QA commented on HBASE-7295:
--
{color:red}-1 overall{color}. Here are the results o
[
https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13527927#comment-13527927
]
Varun Sharma commented on HBASE-7295:
-
I have attached another version (v3) - now we s
[
https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13526832#comment-13526832
]
Ted Yu commented on HBASE-7295:
---
@Varun:
bq. it might lead to cases where we might go slight
[
https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13526632#comment-13526632
]
Lars Hofhansl commented on HBASE-7295:
--
I do not think I want to change this behavior
[
https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13526613#comment-13526613
]
nkeywal commented on HBASE-7295:
Just a question: what's expected if we have a failure of
[
https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13526608#comment-13526608
]
Hadoop QA commented on HBASE-7295:
--
{color:red}-1 overall{color}. Here are the results o
[
https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13526216#comment-13526216
]
Varun Sharma commented on HBASE-7295:
-
That is disallowed - look at the getPoolType fu
[
https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13526211#comment-13526211
]
Lars Hofhansl commented on HBASE-7295:
--
bq. Since we are using RoundRobin/ThreadLocal
[
https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13526145#comment-13526145
]
Ted Yu commented on HBASE-7295:
---
There were so many TestHBaseFsck failures on Jenkins. I was
[
https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13526137#comment-13526137
]
Hadoop QA commented on HBASE-7295:
--
{color:red}-1 overall{color}. Here are the results o
[
https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13526085#comment-13526085
]
Ted Yu commented on HBASE-7295:
---
Can you attach patch for trunk so that Hadoop QA can test i
[
https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13526083#comment-13526083
]
Varun Sharma commented on HBASE-7295:
-
Attached a v2 with updated comments and your fe
[
https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13526055#comment-13526055
]
Ted Yu commented on HBASE-7295:
---
How about calling createPool() once and storing the return
[
https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13526052#comment-13526052
]
Varun Sharma commented on HBASE-7295:
-
I dont know if we can use putIfAbsent() without
[
https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13526040#comment-13526040
]
Ted Yu commented on HBASE-7295:
---
{code}
+ // This is a bug in RoundRobinPool. However u
51 matches
Mail list logo
