[jira] [Commented] (HBASE-7349) Jenkins build should compare trunk vs patch for Javadoc warnings

2012-12-18 Thread Nick Dimiduk (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13535098#comment-13535098 ] Nick Dimiduk commented on HBASE-7349: - Ah yes, that's precisely it: https://github.co

[jira] [Commented] (HBASE-7349) Jenkins build should compare trunk vs patch for Javadoc warnings

2012-12-18 Thread nkeywal (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13535088#comment-13535088 ] nkeywal commented on HBASE-7349: Yes, that's what I've finally done in HBASE-7363, it work

[jira] [Commented] (HBASE-7349) Jenkins build should compare trunk vs patch for Javadoc warnings

2012-12-18 Thread Nick Dimiduk (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13535078#comment-13535078 ] Nick Dimiduk commented on HBASE-7349: - [~nkeywal] Remove the generics from the first s

[jira] [Commented] (HBASE-7349) Jenkins build should compare trunk vs patch for Javadoc warnings

2012-12-18 Thread nkeywal (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534769#comment-13534769 ] nkeywal commented on HBASE-7349: For this one, it seems it doesn't like templates: {noform

[jira] [Commented] (HBASE-7349) Jenkins build should compare trunk vs patch for Javadoc warnings

2012-12-17 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534630#comment-13534630 ] Hudson commented on HBASE-7349: --- Integrated in HBase-TRUNK #3630 (See [https://builds.apach

[jira] [Commented] (HBASE-7349) Jenkins build should compare trunk vs patch for Javadoc warnings

2012-12-17 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534578#comment-13534578 ] Hudson commented on HBASE-7349: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #300 (See [https

[jira] [Commented] (HBASE-7349) Jenkins build should compare trunk vs patch for Javadoc warnings

2012-12-17 Thread Nick Dimiduk (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534487#comment-13534487 ] Nick Dimiduk commented on HBASE-7349: - Sounds good. > Jenkins build s

[jira] [Commented] (HBASE-7349) Jenkins build should compare trunk vs patch for Javadoc warnings

2012-12-17 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534486#comment-13534486 ] stack commented on HBASE-7349: -- I'd go w/ @nkeywal on this one; i.e. lets keep javadoc warnin

[jira] [Commented] (HBASE-7349) Jenkins build should compare trunk vs patch for Javadoc warnings

2012-12-17 Thread nkeywal (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534328#comment-13534328 ] nkeywal commented on HBASE-7349: Yep, I actually used IntelliJ to detect the warnings, it

[jira] [Commented] (HBASE-7349) Jenkins build should compare trunk vs patch for Javadoc warnings

2012-12-17 Thread Nick Dimiduk (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534207#comment-13534207 ] Nick Dimiduk commented on HBASE-7349: - [~stack] the first two are known. Those are the

[jira] [Commented] (HBASE-7349) Jenkins build should compare trunk vs patch for Javadoc warnings

2012-12-17 Thread Nick Dimiduk (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534199#comment-13534199 ] Nick Dimiduk commented on HBASE-7349: - [~stack] This patch was committed also, so the

[jira] [Commented] (HBASE-7349) Jenkins build should compare trunk vs patch for Javadoc warnings

2012-12-17 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534197#comment-13534197 ] stack commented on HBASE-7349: -- At the moment I see the following WARNINGs still: {code} 3

[jira] [Commented] (HBASE-7349) Jenkins build should compare trunk vs patch for Javadoc warnings

2012-12-17 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534185#comment-13534185 ] stack commented on HBASE-7349: -- Should we close this one now that we went a different route (

[jira] [Commented] (HBASE-7349) Jenkins build should compare trunk vs patch for Javadoc warnings

2012-12-14 Thread Nick Dimiduk (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13532707#comment-13532707 ] Nick Dimiduk commented on HBASE-7349: - Sounds like that leaves me hbase-server: beginn

[jira] [Commented] (HBASE-7349) Jenkins build should compare trunk vs patch for Javadoc warnings

2012-12-14 Thread nkeywal (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13532702#comment-13532702 ] nkeywal commented on HBASE-7349: Ok, so I will do the ones I mentioned... But tomorrow now

[jira] [Commented] (HBASE-7349) Jenkins build should compare trunk vs patch for Javadoc warnings

2012-12-14 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13532676#comment-13532676 ] stack commented on HBASE-7349: -- hbase-7356 is all modules but hbase-server >

[jira] [Commented] (HBASE-7349) Jenkins build should compare trunk vs patch for Javadoc warnings

2012-12-14 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13532638#comment-13532638 ] stack commented on HBASE-7349: -- nvm. Made for more work than it fixed... doubled annotations

[jira] [Commented] (HBASE-7349) Jenkins build should compare trunk vs patch for Javadoc warnings

2012-12-14 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13532519#comment-13532519 ] stack commented on HBASE-7349: -- Hang on... this javadoc:fix plugin looks promising... let me

[jira] [Commented] (HBASE-7349) Jenkins build should compare trunk vs patch for Javadoc warnings

2012-12-14 Thread nkeywal (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13532516#comment-13532516 ] nkeywal commented on HBASE-7349: ok ok then I volunteer for hbase-server, packages from ma

[jira] [Commented] (HBASE-7349) Jenkins build should compare trunk vs patch for Javadoc warnings

2012-12-14 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13532512#comment-13532512 ] stack commented on HBASE-7349: -- I like the moving stuff to zero rather than double running ja

[jira] [Commented] (HBASE-7349) Jenkins build should compare trunk vs patch for Javadoc warnings

2012-12-14 Thread nkeywal (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13532462#comment-13532462 ] nkeywal commented on HBASE-7349: Great :-) there are 100 warnings, if I'm not wrong. 50 se

[jira] [Commented] (HBASE-7349) Jenkins build should compare trunk vs patch for Javadoc warnings

2012-12-14 Thread Nick Dimiduk (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13532458#comment-13532458 ] Nick Dimiduk commented on HBASE-7349: - [~nkeywal] I agree, no/minimal warnings would b

[jira] [Commented] (HBASE-7349) Jenkins build should compare trunk vs patch for Javadoc warnings

2012-12-14 Thread Nick Dimiduk (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13532450#comment-13532450 ] Nick Dimiduk commented on HBASE-7349: - This one appears to be functioning as expected.

[jira] [Commented] (HBASE-7349) Jenkins build should compare trunk vs patch for Javadoc warnings

2012-12-14 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13532262#comment-13532262 ] Hudson commented on HBASE-7349: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #296 (See [https

[jira] [Commented] (HBASE-7349) Jenkins build should compare trunk vs patch for Javadoc warnings

2012-12-14 Thread nkeywal (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13532172#comment-13532172 ] nkeywal commented on HBASE-7349: For javadocs warnings, would it make sense to fix all of

[jira] [Commented] (HBASE-7349) Jenkins build should compare trunk vs patch for Javadoc warnings

2012-12-13 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13531917#comment-13531917 ] Hudson commented on HBASE-7349: --- Integrated in HBase-TRUNK #3620 (See [https://builds.apach

[jira] [Commented] (HBASE-7349) Jenkins build should compare trunk vs patch for Javadoc warnings

2012-12-13 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13531864#comment-13531864 ] stack commented on HBASE-7349: -- Committed to trunk. Will leave issue open in case amendment

[jira] [Commented] (HBASE-7349) Jenkins build should compare trunk vs patch for Javadoc warnings

2012-12-13 Thread Nick Dimiduk (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13531861#comment-13531861 ] Nick Dimiduk commented on HBASE-7349: - [~stack] I sure as hell don't trust my AWK but

[jira] [Commented] (HBASE-7349) Jenkins build should compare trunk vs patch for Javadoc warnings

2012-12-13 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13531855#comment-13531855 ] stack commented on HBASE-7349: -- [~ndimiduk] Or commit it and keep an eye on it? I can commit

[jira] [Commented] (HBASE-7349) Jenkins build should compare trunk vs patch for Javadoc warnings

2012-12-13 Thread Nick Dimiduk (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13531694#comment-13531694 ] Nick Dimiduk commented on HBASE-7349: - Unknown. The script is already running when it

[jira] [Commented] (HBASE-7349) Jenkins build should compare trunk vs patch for Javadoc warnings

2012-12-13 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13531673#comment-13531673 ] stack commented on HBASE-7349: -- [~ndimiduk] Did your patch do the right thing?

[jira] [Commented] (HBASE-7349) Jenkins build should compare trunk vs patch for Javadoc warnings

2012-12-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13531670#comment-13531670 ] Hadoop QA commented on HBASE-7349: -- {color:red}-1 overall{color}. Here are the results o