[jira] [Commented] (HBASE-7414) Convert some HFile metadata to PB

2013-01-08 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546810#comment-13546810 ] Hudson commented on HBASE-7414: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #335 (See

[jira] [Commented] (HBASE-7414) Convert some HFile metadata to PB

2013-01-07 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546303#comment-13546303 ] stack commented on HBASE-7414: -- On whether this patch breaks our being able to read hfiles

[jira] [Commented] (HBASE-7414) Convert some HFile metadata to PB

2013-01-07 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546335#comment-13546335 ] Andrew Purtell commented on HBASE-7414: --- bq. So, if this test passes, we can have

[jira] [Commented] (HBASE-7414) Convert some HFile metadata to PB

2013-01-07 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546339#comment-13546339 ] stack commented on HBASE-7414: -- +1 Convert some HFile metadata to PB

[jira] [Commented] (HBASE-7414) Convert some HFile metadata to PB

2013-01-07 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546412#comment-13546412 ] Hadoop QA commented on HBASE-7414: -- {color:red}-1 overall{color}. Here are the results

[jira] [Commented] (HBASE-7414) Convert some HFile metadata to PB

2013-01-07 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546567#comment-13546567 ] Hudson commented on HBASE-7414: --- Integrated in HBase-TRUNK #3708 (See

[jira] [Commented] (HBASE-7414) Convert some HFile metadata to PB

2013-01-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13544720#comment-13544720 ] Ted Yu commented on HBASE-7414: --- {code} +if (majorVersion 2 || (majorVersion == 2

[jira] [Commented] (HBASE-7414) Convert some HFile metadata to PB

2013-01-05 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13545168#comment-13545168 ] Andrew Purtell commented on HBASE-7414: --- Ah, thanks. Dumb paste-o. Will remove those

[jira] [Commented] (HBASE-7414) Convert some HFile metadata to PB

2013-01-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13545194#comment-13545194 ] Hadoop QA commented on HBASE-7414: -- {color:red}-1 overall{color}. Here are the results

[jira] [Commented] (HBASE-7414) Convert some HFile metadata to PB

2013-01-05 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13545195#comment-13545195 ] Andrew Purtell commented on HBASE-7414: --- All tests pass locally with -PrunAllTests

[jira] [Commented] (HBASE-7414) Convert some HFile metadata to PB

2013-01-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13545206#comment-13545206 ] Ted Yu commented on HBASE-7414: --- In serialize(): {code} +if (majorVersion 2 ||

[jira] [Commented] (HBASE-7414) Convert some HFile metadata to PB

2013-01-05 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13545217#comment-13545217 ] Andrew Purtell commented on HBASE-7414: --- bq. Since we don't change majorVersion in

[jira] [Commented] (HBASE-7414) Convert some HFile metadata to PB

2013-01-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13545222#comment-13545222 ] Ted Yu commented on HBASE-7414: --- Sounds good, Andy Convert some HFile

[jira] [Commented] (HBASE-7414) Convert some HFile metadata to PB

2013-01-05 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13545223#comment-13545223 ] Andrew Purtell commented on HBASE-7414: --- Thanks for the review Ted. I'll add some of

[jira] [Commented] (HBASE-7414) Convert some HFile metadata to PB

2013-01-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13545283#comment-13545283 ] Hadoop QA commented on HBASE-7414: -- {color:red}-1 overall{color}. Here are the results

[jira] [Commented] (HBASE-7414) Convert some HFile metadata to PB

2013-01-04 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13544545#comment-13544545 ] stack commented on HBASE-7414: -- [~andrew.purt...@gmail.com] Not working on this boss. Agree

[jira] [Commented] (HBASE-7414) Convert some HFile metadata to PB

2013-01-04 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13544547#comment-13544547 ] Ted Yu commented on HBASE-7414: --- {code} +if (majorVersion 2 || (majorVersion == 2

[jira] [Commented] (HBASE-7414) Convert some HFile metadata to PB

2013-01-04 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13544553#comment-13544553 ] Ted Yu commented on HBASE-7414: --- Looking at HFileBlock.java: {code} static final int