[jira] [Commented] (HBASE-7784) move the code related to selection that is specific to default compaction policy, into default compaction policy (from HStore)

2013-02-08 Thread Matteo Bertozzi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13574949#comment-13574949 ] Matteo Bertozzi commented on HBASE-7784: looks good to me +1 > mo

[jira] [Commented] (HBASE-7784) move the code related to selection that is specific to default compaction policy, into default compaction policy (from HStore)

2013-02-08 Thread Jimmy Xiang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13574832#comment-13574832 ] Jimmy Xiang commented on HBASE-7784: +1 for me. > move the code relat

[jira] [Commented] (HBASE-7784) move the code related to selection that is specific to default compaction policy, into default compaction policy (from HStore)

2013-02-08 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13574754#comment-13574754 ] Ted Yu commented on HBASE-7784: --- [~mbertozzi], [~jxiang]: Any further comments ? Thanks

[jira] [Commented] (HBASE-7784) move the code related to selection that is specific to default compaction policy, into default compaction policy (from HStore)

2013-02-08 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13574749#comment-13574749 ] Hadoop QA commented on HBASE-7784: -- {color:red}-1 overall{color}. Here are the results o

[jira] [Commented] (HBASE-7784) move the code related to selection that is specific to default compaction policy, into default compaction policy (from HStore)

2013-02-08 Thread Matteo Bertozzi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13574702#comment-13574702 ] Matteo Bertozzi commented on HBASE-7784: minor note: Don't you need to change FIXE

[jira] [Commented] (HBASE-7784) move the code related to selection that is specific to default compaction policy, into default compaction policy (from HStore)

2013-02-08 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13574685#comment-13574685 ] Sergey Shelukhin commented on HBASE-7784: - wrt method name - yes. Just to make it

[jira] [Commented] (HBASE-7784) move the code related to selection that is specific to default compaction policy, into default compaction policy (from HStore)

2013-02-08 Thread Jimmy Xiang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13574658#comment-13574658 ] Jimmy Xiang commented on HBASE-7784: I see. I prefer to move this logic change/fix to

[jira] [Commented] (HBASE-7784) move the code related to selection that is specific to default compaction policy, into default compaction policy (from HStore)

2013-02-08 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13574633#comment-13574633 ] Sergey Shelukhin commented on HBASE-7784: - Because the collision of values with US

[jira] [Commented] (HBASE-7784) move the code related to selection that is specific to default compaction policy, into default compaction policy (from HStore)

2013-02-07 Thread Jimmy Xiang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13574257#comment-13574257 ] Jimmy Xiang commented on HBASE-7784: bq. Yes; see HBASE-7791 bq. I am assuming this is

[jira] [Commented] (HBASE-7784) move the code related to selection that is specific to default compaction policy, into default compaction policy (from HStore)

2013-02-07 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13574252#comment-13574252 ] Hadoop QA commented on HBASE-7784: -- {color:red}-1 overall{color}. Here are the results o

[jira] [Commented] (HBASE-7784) move the code related to selection that is specific to default compaction policy, into default compaction policy (from HStore)

2013-02-07 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13574229#comment-13574229 ] Ted Yu commented on HBASE-7784: --- +1 on patch, pending QA result. > move the

[jira] [Commented] (HBASE-7784) move the code related to selection that is specific to default compaction policy, into default compaction policy (from HStore)

2013-02-07 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13574150#comment-13574150 ] Hadoop QA commented on HBASE-7784: -- {color:red}-1 overall{color}. Here are the results o

[jira] [Commented] (HBASE-7784) move the code related to selection that is specific to default compaction policy, into default compaction policy (from HStore)

2013-02-07 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13574144#comment-13574144 ] Sergey Shelukhin commented on HBASE-7784: - Yes; see HBASE-7791 I am assuming this

[jira] [Commented] (HBASE-7784) move the code related to selection that is specific to default compaction policy, into default compaction policy (from HStore)

2013-02-07 Thread Jimmy Xiang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13574138#comment-13574138 ] Jimmy Xiang commented on HBASE-7784: Looks good to me. One question, why do we want to