[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13635675#comment-13635675
]
Tsz Wo (Nicholas), SZE commented on HBASE-8352:
---
Thanks for everyone. You g
[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633852#comment-13633852
]
Hudson commented on HBASE-8352:
---
Integrated in HBase-0.94-security #138 (See
[https://build
[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633814#comment-13633814
]
Hudson commented on HBASE-8352:
---
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #501 (See
[https
[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633783#comment-13633783
]
Hudson commented on HBASE-8352:
---
Integrated in HBase-TRUNK #4067 (See
[https://builds.apach
[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633768#comment-13633768
]
Hudson commented on HBASE-8352:
---
Integrated in HBase-0.94 #962 (See
[https://builds.apache.
[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633757#comment-13633757
]
Hudson commented on HBASE-8352:
---
Integrated in hbase-0.95-on-hadoop2 #71 (See
[https://buil
[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633729#comment-13633729
]
Hudson commented on HBASE-8352:
---
Integrated in hbase-0.95 #150 (See
[https://builds.apache.
[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633548#comment-13633548
]
Ted Yu commented on HBASE-8352:
---
Integrated to 0.94, 0.95 and trunk.
Thanks for the reviews
[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633481#comment-13633481
]
Ted Yu commented on HBASE-8352:
---
@Matteo:
Were you suggesting modification based on patch v6
[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633474#comment-13633474
]
Matteo Bertozzi commented on HBASE-8352:
if the inital folder name was ".hbase-sna
[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633456#comment-13633456
]
Andrew Purtell commented on HBASE-8352:
---
OLD_SNAPSHOT_DIR_NAME lgtm
[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633451#comment-13633451
]
Ted Yu commented on HBASE-8352:
---
I thought about that. getCompletedSnapshots() references ".
[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633422#comment-13633422
]
Andrew Purtell commented on HBASE-8352:
---
Minor nit on patch v5, can be fixed up on c
[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633396#comment-13633396
]
Hadoop QA commented on HBASE-8352:
--
{color:green}+1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633378#comment-13633378
]
Lars Hofhansl commented on HBASE-8352:
--
+1 from me as well.
> Rename
[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633371#comment-13633371
]
Jesse Yates commented on HBASE-8352:
+1 lgtm. Thanks Ted!
> Rename '.
[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633367#comment-13633367
]
Matteo Bertozzi commented on HBASE-8352:
+1 v5 looks good to me
>
[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633343#comment-13633343
]
Hadoop QA commented on HBASE-8352:
--
{color:green}+1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633342#comment-13633342
]
Jonathan Hsieh commented on HBASE-8352:
---
lgtm +1.
> Rename '.snapsh
[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633294#comment-13633294
]
Jonathan Hsieh commented on HBASE-8352:
---
nit: Prefer keeping the no argument version
[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633217#comment-13633217
]
Hadoop QA commented on HBASE-8352:
--
{color:red}-1 overall{color}. Here are the results o
[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633204#comment-13633204
]
Lars Hofhansl commented on HBASE-8352:
--
This does not seem right:
{code}
+// chec
[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633168#comment-13633168
]
Hadoop QA commented on HBASE-8352:
--
{color:green}+1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633162#comment-13633162
]
Tsz Wo (Nicholas), SZE commented on HBASE-8352:
---
{quote}
> If 2.0.5-alpha is
[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633159#comment-13633159
]
Enis Soztutar commented on HBASE-8352:
--
Release notes seems good. There is a upgrade
[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633144#comment-13633144
]
Jonathan Hsieh commented on HBASE-8352:
---
The insertion point in the code is correct
[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633125#comment-13633125
]
Ted Yu commented on HBASE-8352:
---
Patch v2 has the following in checkSnapshotSupport():
{code
[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633122#comment-13633122
]
Jonathan Hsieh commented on HBASE-8352:
---
bq. So you're good with the patch, Jon?
Le
[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633116#comment-13633116
]
Lars Hofhansl commented on HBASE-8352:
--
So you're good with the patch, Jon?
[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633091#comment-13633091
]
Jonathan Hsieh commented on HBASE-8352:
---
I'm suggesting that for future 0.94's (0.94
[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633087#comment-13633087
]
Lars Hofhansl commented on HBASE-8352:
--
Release notes look good. +1 on v2.
[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633074#comment-13633074
]
Ted Yu commented on HBASE-8352:
---
See release notes in HDFS-4666 for how ".snapshot" is handl
[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633071#comment-13633071
]
Jonathan Hsieh commented on HBASE-8352:
---
bq. If 2.0.5-alpha is the underlying hdfs,
[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633039#comment-13633039
]
Ted Yu commented on HBASE-8352:
---
w.r.t. Lars' suggestion of introducing 'hbase.snapshot.use_
[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633043#comment-13633043
]
Jonathan Hsieh commented on HBASE-8352:
---
bq. If hbase.snapshot.use_newdir is true we
[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633034#comment-13633034
]
Ted Yu commented on HBASE-8352:
---
bq. can we add some logging code that checks the .snapshot
[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633029#comment-13633029
]
Jonathan Hsieh commented on HBASE-8352:
---
I like Matteo's latest version.
Also, can
[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633024#comment-13633024
]
Jonathan Hsieh commented on HBASE-8352:
---
bq. You want doc and release notes? Or is e
[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633019#comment-13633019
]
Lars Hofhansl commented on HBASE-8352:
--
Here's an option to make this configurable an
[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633004#comment-13633004
]
Matteo Bertozzi commented on HBASE-8352:
{quote}Should order of steps #2 and #3 ab
[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13632984#comment-13632984
]
Ted Yu commented on HBASE-8352:
---
Should order of steps #2 and #3 above be switched ?
[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13632983#comment-13632983
]
Matteo Bertozzi commented on HBASE-8352:
forgot to say that if you take a snapshot
[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13632977#comment-13632977
]
Lars Hofhansl commented on HBASE-8352:
--
Hmm... Jon just pointed out on the dev list t
[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13632978#comment-13632978
]
Matteo Bertozzi commented on HBASE-8352:
I think the upgrade procedure should be m
[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13632973#comment-13632973
]
Lars Hofhansl commented on HBASE-8352:
--
Can you draft something [~jmhsieh] (otherwise
[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13632964#comment-13632964
]
Ted Yu commented on HBASE-8352:
---
The test failure was not related to the patch:
Running org
[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13632957#comment-13632957
]
Hadoop QA commented on HBASE-8352:
--
{color:red}-1 overall{color}. Here are the results o
[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13632926#comment-13632926
]
Jonathan Hsieh commented on HBASE-8352:
---
-1 until we get the docs / release notes up
[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13632912#comment-13632912
]
Matteo Bertozzi commented on HBASE-8352:
The release note should highlight that yo
[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13632895#comment-13632895
]
Ted Yu commented on HBASE-8352:
---
bq. If we want to tackle those, I'd suggest a different a j
[
https://issues.apache.org/jira/browse/HBASE-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13632888#comment-13632888
]
Lars Hofhansl commented on HBASE-8352:
--
+1 on this approach and patch.
(Making this
51 matches
Mail list logo
