[jira] [Commented] (HBASE-9079) FilterList getNextKeyHint skips rows that should be included in the results

[ https://issues.apache.org/jira/browse/HBASE-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1370#comment-1370 ] Viral Bajaria commented on HBASE-9079: -- Sorry for the delay. I did a local test with

[jira] [Commented] (HBASE-9079) FilterList getNextKeyHint skips rows that should be included in the results

[ https://issues.apache.org/jira/browse/HBASE-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13733946#comment-13733946 ] Viral Bajaria commented on HBASE-9079: -- Thanks for all the help [~ted_yu] and

[jira] [Commented] (HBASE-9079) FilterList getNextKeyHint skips rows that should be included in the results

[ https://issues.apache.org/jira/browse/HBASE-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13734075#comment-13734075 ] Hudson commented on HBASE-9079: --- SUCCESS: Integrated in HBase-0.94-security #249 (See

[jira] [Commented] (HBASE-9079) FilterList getNextKeyHint skips rows that should be included in the results

[ https://issues.apache.org/jira/browse/HBASE-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13734086#comment-13734086 ] Hudson commented on HBASE-9079: --- SUCCESS: Integrated in HBase-0.94 #1100 (See

[jira] [Commented] (HBASE-9079) FilterList getNextKeyHint skips rows that should be included in the results

[ https://issues.apache.org/jira/browse/HBASE-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13734181#comment-13734181 ] Hudson commented on HBASE-9079: --- FAILURE: Integrated in HBase-TRUNK #4357 (See

[jira] [Commented] (HBASE-9079) FilterList getNextKeyHint skips rows that should be included in the results

[ https://issues.apache.org/jira/browse/HBASE-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13734195#comment-13734195 ] Hudson commented on HBASE-9079: --- FAILURE: Integrated in hbase-0.95 #418 (See

[jira] [Commented] (HBASE-9079) FilterList getNextKeyHint skips rows that should be included in the results

[ https://issues.apache.org/jira/browse/HBASE-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13734293#comment-13734293 ] Hudson commented on HBASE-9079: --- FAILURE: Integrated in hbase-0.95-on-hadoop2 #225 (See

[jira] [Commented] (HBASE-9079) FilterList getNextKeyHint skips rows that should be included in the results

[ https://issues.apache.org/jira/browse/HBASE-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13734310#comment-13734310 ] Hudson commented on HBASE-9079: --- FAILURE: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #658

[jira] [Commented] (HBASE-9079) FilterList getNextKeyHint skips rows that should be included in the results

[ https://issues.apache.org/jira/browse/HBASE-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13732119#comment-13732119 ] Lars Hofhansl commented on HBASE-9079: -- Did you get a chance to test this with real

[jira] [Commented] (HBASE-9079) FilterList getNextKeyHint skips rows that should be included in the results

[ https://issues.apache.org/jira/browse/HBASE-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13732627#comment-13732627 ] Viral Bajaria commented on HBASE-9079: -- Not yet, got caught in something else. Will

[jira] [Commented] (HBASE-9079) FilterList getNextKeyHint skips rows that should be included in the results

[ https://issues.apache.org/jira/browse/HBASE-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13733117#comment-13733117 ] Lars Hofhansl commented on HBASE-9079: -- ping :) It's also fine to push into next

[jira] [Commented] (HBASE-9079) FilterList getNextKeyHint skips rows that should be included in the results

[ https://issues.apache.org/jira/browse/HBASE-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13731116#comment-13731116 ] Lars Hofhansl commented on HBASE-9079: -- So thinking about this again. Why can't we

[jira] [Commented] (HBASE-9079) FilterList getNextKeyHint skips rows that should be included in the results

[ https://issues.apache.org/jira/browse/HBASE-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13731130#comment-13731130 ] Viral Bajaria commented on HBASE-9079: -- If we take the largest seekHint, the problem

[jira] [Commented] (HBASE-9079) FilterList getNextKeyHint skips rows that should be included in the results

[ https://issues.apache.org/jira/browse/HBASE-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13731276#comment-13731276 ] Lars Hofhansl commented on HBASE-9079: -- I see. But what you hit a scenario where the

[jira] [Commented] (HBASE-9079) FilterList getNextKeyHint skips rows that should be included in the results

[ https://issues.apache.org/jira/browse/HBASE-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13731387#comment-13731387 ] Viral Bajaria commented on HBASE-9079: -- The current patch only calls the filter that

[jira] [Commented] (HBASE-9079) FilterList getNextKeyHint skips rows that should be included in the results

[ https://issues.apache.org/jira/browse/HBASE-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13731447#comment-13731447 ] Lars Hofhansl commented on HBASE-9079: -- From your example the problem is (1) FuzzyRow

[jira] [Commented] (HBASE-9079) FilterList getNextKeyHint skips rows that should be included in the results

[ https://issues.apache.org/jira/browse/HBASE-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13731490#comment-13731490 ] Lars Hofhansl commented on HBASE-9079: -- Then again this breaks

[jira] [Commented] (HBASE-9079) FilterList getNextKeyHint skips rows that should be included in the results

[ https://issues.apache.org/jira/browse/HBASE-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13731571#comment-13731571 ] Ted Yu commented on HBASE-9079: --- I ran Filter related tests and they passed. {code} for

[jira] [Commented] (HBASE-9079) FilterList getNextKeyHint skips rows that should be included in the results

[ https://issues.apache.org/jira/browse/HBASE-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13731575#comment-13731575 ] Hadoop QA commented on HBASE-9079: -- {color:green}+1 overall{color}. Here are the results

[jira] [Commented] (HBASE-9079) FilterList getNextKeyHint skips rows that should be included in the results

[ https://issues.apache.org/jira/browse/HBASE-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13731612#comment-13731612 ] Lars Hofhansl commented on HBASE-9079: -- Will move the comment upon commit. So Ted and

[jira] [Commented] (HBASE-9079) FilterList getNextKeyHint skips rows that should be included in the results

[ https://issues.apache.org/jira/browse/HBASE-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13731621#comment-13731621 ] Viral Bajaria commented on HBASE-9079: -- Looks good to me. I have applied the patch to

[jira] [Commented] (HBASE-9079) FilterList getNextKeyHint skips rows that should be included in the results

[ https://issues.apache.org/jira/browse/HBASE-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13729738#comment-13729738 ] Viral Bajaria commented on HBASE-9079: -- [~lhofhansl] Can you review the patch when

[jira] [Commented] (HBASE-9079) FilterList getNextKeyHint skips rows that should be included in the results

[ https://issues.apache.org/jira/browse/HBASE-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13726775#comment-13726775 ] Viral Bajaria commented on HBASE-9079: -- (pressed enter too soon when attaching

[jira] [Commented] (HBASE-9079) FilterList getNextKeyHint skips rows that should be included in the results

[ https://issues.apache.org/jira/browse/HBASE-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13726777#comment-13726777 ] Ted Yu commented on HBASE-9079: --- There're a few long lines in test: {code} +

[jira] [Commented] (HBASE-9079) FilterList getNextKeyHint skips rows that should be included in the results

[ https://issues.apache.org/jira/browse/HBASE-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13727020#comment-13727020 ] Hadoop QA commented on HBASE-9079: -- {color:red}-1 overall{color}. Here are the results

[jira] [Commented] (HBASE-9079) FilterList getNextKeyHint skips rows that should be included in the results

[ https://issues.apache.org/jira/browse/HBASE-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13727039#comment-13727039 ] Viral Bajaria commented on HBASE-9079: -- Removed the TestFail and TestSuccess patches

[jira] [Commented] (HBASE-9079) FilterList getNextKeyHint skips rows that should be included in the results

[ https://issues.apache.org/jira/browse/HBASE-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13727245#comment-13727245 ] Hadoop QA commented on HBASE-9079: -- {color:green}+1 overall{color}. Here are the results

[jira] [Commented] (HBASE-9079) FilterList getNextKeyHint skips rows that should be included in the results

[ https://issues.apache.org/jira/browse/HBASE-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13725684#comment-13725684 ] Viral Bajaria commented on HBASE-9079: -- Uploaded patch for both 0.94 and trunk.

[jira] [Commented] (HBASE-9079) FilterList getNextKeyHint skips rows that should be included in the results

[ https://issues.apache.org/jira/browse/HBASE-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13725776#comment-13725776 ] Hadoop QA commented on HBASE-9079: -- {color:red}-1 overall{color}. Here are the results

[jira] [Commented] (HBASE-9079) FilterList getNextKeyHint skips rows that should be included in the results

[ https://issues.apache.org/jira/browse/HBASE-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13725805#comment-13725805 ] Ted Yu commented on HBASE-9079: --- @Viral: The difference you saw in FilterList was due to

[jira] [Commented] (HBASE-9079) FilterList getNextKeyHint skips rows that should be included in the results

[ https://issues.apache.org/jira/browse/HBASE-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13725987#comment-13725987 ] Viral Bajaria commented on HBASE-9079: -- Is it not a good idea to work from the

[jira] [Commented] (HBASE-9079) FilterList getNextKeyHint skips rows that should be included in the results

[ https://issues.apache.org/jira/browse/HBASE-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13725991#comment-13725991 ] Ted Yu commented on HBASE-9079: --- That's strange. I saw the changes from

[jira] [Commented] (HBASE-9079) FilterList getNextKeyHint skips rows that should be included in the results

[ https://issues.apache.org/jira/browse/HBASE-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13725995#comment-13725995 ] Viral Bajaria commented on HBASE-9079: -- Oh wait! I do see all those changes on 0.94

[jira] [Commented] (HBASE-9079) FilterList getNextKeyHint skips rows that should be included in the results

[ https://issues.apache.org/jira/browse/HBASE-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13726025#comment-13726025 ] Ted Yu commented on HBASE-9079: --- Here was the checkin for trunk: {code} r1499851 | tedyu |

[jira] [Commented] (HBASE-9079) FilterList getNextKeyHint skips rows that should be included in the results

[ https://issues.apache.org/jira/browse/HBASE-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13723981#comment-13723981 ] Ted Yu commented on HBASE-9079: --- For trunk, can we introduce the following method to Filter:

[jira] [Commented] (HBASE-9079) FilterList getNextKeyHint skips rows that should be included in the results

[ https://issues.apache.org/jira/browse/HBASE-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13724652#comment-13724652 ] Viral Bajaria commented on HBASE-9079: -- What kind of re-ordering will you do ? Isn't

[jira] [Commented] (HBASE-9079) FilterList getNextKeyHint skips rows that should be included in the results

[ https://issues.apache.org/jira/browse/HBASE-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13724719#comment-13724719 ] Ted Yu commented on HBASE-9079: --- bq. Maybe I could limit the scope of this ticket to

[jira] [Commented] (HBASE-9079) FilterList getNextKeyHint skips rows that should be included in the results

[ https://issues.apache.org/jira/browse/HBASE-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13723166#comment-13723166 ] Ted Yu commented on HBASE-9079: --- For TestFuzzyAndColumnRangeFilter, please add license. Can

[jira] [Commented] (HBASE-9079) FilterList getNextKeyHint skips rows that should be included in the results

[ https://issues.apache.org/jira/browse/HBASE-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13723193#comment-13723193 ] Lars Hofhansl commented on HBASE-9079: -- I also have a question about this: {code} +

[jira] [Commented] (HBASE-9079) FilterList getNextKeyHint skips rows that should be included in the results

[ https://issues.apache.org/jira/browse/HBASE-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13723305#comment-13723305 ] Viral Bajaria commented on HBASE-9079: -- I will upload a new patch with the fixes that

[jira] [Commented] (HBASE-9079) FilterList getNextKeyHint skips rows that should be included in the results

[ https://issues.apache.org/jira/browse/HBASE-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13723343#comment-13723343 ] Ted Yu commented on HBASE-9079: --- w.r.t. ordering, there is no method in FilterBase which can