[jira] [Commented] (HBASE-9518) getFakedKey() improvement

2013-09-20 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13772654#comment-13772654 ] Hudson commented on HBASE-9518: --- SUCCESS: Integrated in HBase-TRUNK #4535 (See

[jira] [Commented] (HBASE-9518) getFakedKey() improvement

2013-09-20 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13772832#comment-13772832 ] Hudson commented on HBASE-9518: --- SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #743

[jira] [Commented] (HBASE-9518) getFakedKey() improvement

2013-09-19 Thread Liang Xie (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13771922#comment-13771922 ] Liang Xie commented on HBASE-9518: -- [~jdcryans], thanks for review, i just filed

[jira] [Commented] (HBASE-9518) getFakedKey() improvement

2013-09-18 Thread Jean-Daniel Cryans (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13771223#comment-13771223 ] Jean-Daniel Cryans commented on HBASE-9518: --- +1 When you have some time

[jira] [Commented] (HBASE-9518) getFakedKey() improvement

2013-09-16 Thread Liang Xie (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13769131#comment-13769131 ] Liang Xie commented on HBASE-9518: -- any more comments? thanks

[jira] [Commented] (HBASE-9518) getFakedKey() improvement

2013-09-16 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13769197#comment-13769197 ] stack commented on HBASE-9518: -- lgtm Makes sense (I see you left an 'opportunity for

[jira] [Commented] (HBASE-9518) getFakedKey() improvement

2013-09-14 Thread Liang Xie (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13767482#comment-13767482 ] Liang Xie commented on HBASE-9518: -- Hi [~stack] you can see the new TestKeyValue case: if

[jira] [Commented] (HBASE-9518) getFakedKey() improvement

2013-09-13 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13767033#comment-13767033 ] stack commented on HBASE-9518: -- bq. make generating faked key algo more aggressive What does

[jira] [Commented] (HBASE-9518) getFakedKey() improvement

2013-09-12 Thread Liang Xie (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13765255#comment-13765255 ] Liang Xie commented on HBASE-9518: -- TestCacheOnWrite case is updated due to the index

[jira] [Commented] (HBASE-9518) getFakedKey() improvement

2013-09-12 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13765288#comment-13765288 ] Hadoop QA commented on HBASE-9518: -- {color:red}-1 overall{color}. Here are the results

[jira] [Commented] (HBASE-9518) getFakedKey() improvement

2013-09-12 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13765468#comment-13765468 ] Ted Yu commented on HBASE-9518: --- {code} + System.out.println(midkey: + midKV + or: +

[jira] [Commented] (HBASE-9518) getFakedKey() improvement

2013-09-12 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13765459#comment-13765459 ] Hadoop QA commented on HBASE-9518: -- {color:green}+1 overall{color}. Here are the results