huaxiang sun created HBASE-16275: ------------------------------------ Summary: Change ServerManager#onlineServers from ConcurrentHashMap to ConcurrentSkipListMap Key: HBASE-16275 URL: https://issues.apache.org/jira/browse/HBASE-16275 Project: HBase Issue Type: Improvement Reporter: huaxiang sun Assignee: huaxiang sun Priority: Minor
In Class ServerManager, onlineServers is declared as ConcurrentHashMap. In findServerWithSameHostnamePortWithLock(), it has to do a loop to find if there is a ServerName with same host:port pair. If replaced with ConcurrentSkipListMap, findServerWithSameHostnamePortWithLock() can be replaced with a O(log(n)) implementation. I run some performance comparison(test the function only), it seems that there is no difference if there are 1000 servers. With more servers, ConcurrentSkipListMap implementation is going to win big. -- This message was sent by Atlassian JIRA (v6.3.4#6332)