huaxiang sun created HBASE-20710: ------------------------------------ Summary: extra cloneFamily() in Mutation.add(Cell) Key: HBASE-20710 URL: https://issues.apache.org/jira/browse/HBASE-20710 Project: HBase Issue Type: Improvement Components: regionserver Affects Versions: 2.0.1 Reporter: huaxiang sun Assignee: huaxiang sun
The cpu profiling shows that during PE randomWrite testing, about 1 percent of time is spent in cloneFamily. Reviewing code found that when a cell is DBB backed ByteBuffKeyValueCell (which is default with Netty Rpc), cell.getFamilyArray() will call cloneFamily() and there is again a cloneFamily() in the following line of the code. since this is the critical write path processing, this needs to be optimized. https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Mutation.java#L791 https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Mutation.java#L795 -- This message was sent by Atlassian JIRA (v7.6.3#76005)