HLog shouldn't create a new HBC when rolling --------------------------------------------
Key: HBASE-3860 URL: https://issues.apache.org/jira/browse/HBASE-3860 Project: HBase Issue Type: Improvement Affects Versions: 0.90.2 Reporter: Jean-Daniel Cryans Priority: Critical Fix For: 0.90.3 HBASE-2059 added this change in HLog.rollWriter: {code} this.writer = createWriter(fs, newPath, new HBaseConfiguration(conf)); {code} Which has since become: {code} HLog.Writer nextWriter = this.createWriterInstance(fs, newPath, HBaseConfiguration.create(conf)); {code} It's unclear to me why it needs to do that, but it bite us today because we swapped jars under a running hbase with: {quote} 2011-05-05 12:06:12,876 FATAL org.apache.hadoop.conf.Configuration: error parsing conf file: java.util.zip.ZipException: invalid stored block lengths 2011-05-05 12:06:12,877 ERROR org.apache.hadoop.hbase.regionserver.LogRoller: Log rolling failed java.lang.RuntimeException: java.util.zip.ZipException: invalid stored block lengths at org.apache.hadoop.conf.Configuration.loadResource(Configuration.java:1352) at org.apache.hadoop.conf.Configuration.loadResources(Configuration.java:1227) at org.apache.hadoop.conf.Configuration.getProps(Configuration.java:1156) at org.apache.hadoop.conf.Configuration.get(Configuration.java:427) at org.apache.hadoop.hbase.HBaseConfiguration.checkDefaultsVersion(HBaseConfiguration.java:63) at org.apache.hadoop.hbase.HBaseConfiguration.addHbaseResources(HBaseConfiguration.java:89) at org.apache.hadoop.hbase.HBaseConfiguration.create(HBaseConfiguration.java:100) at org.apache.hadoop.hbase.HBaseConfiguration.create(HBaseConfiguration.java:110) at org.apache.hadoop.hbase.regionserver.wal.HLog.rollWriter(HLog.java:485) at org.apache.hadoop.hbase.regionserver.LogRoller.run(LogRoller.java:94) Caused by: java.util.zip.ZipException: invalid stored block lengths at java.util.zip.InflaterInputStream.read(InflaterInputStream.java:147) at java.util.zip.InflaterInputStream.read(InflaterInputStream.java:105) at java.io.FilterInputStream.read(FilterInputStream.java:66) at com.sun.org.apache.xerces.internal.impl.XMLEntityManager$RewindableInputStream.read(XMLEntityManager.java:2932) at com.sun.org.apache.xerces.internal.impl.XMLEntityManager.setupCurrentEntity(XMLEntityManager.java:704) at com.sun.org.apache.xerces.internal.impl.XMLVersionDetector.determineDocVersion(XMLVersionDetector.java:186) at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:772) at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:737) at com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:119) at com.sun.org.apache.xerces.internal.parsers.DOMParser.parse(DOMParser.java:235) at com.sun.org.apache.xerces.internal.jaxp.DocumentBuilderImpl.parse(DocumentBuilderImpl.java:284) at javax.xml.parsers.DocumentBuilder.parse(DocumentBuilder.java:180) at org.apache.hadoop.conf.Configuration.loadResource(Configuration.java:1266) ... 9 more {quote} -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira