[ https://issues.apache.org/jira/browse/HBASE-18925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Appy updated HBASE-18925: ------------------------- Comment: was deleted (was: Corrected most of the checkstyle issues. But i'll treating them as best effort (instead of \*must\* as in normal patches) in future dependency refactoring patches since class moves will result in existing checkstyle errors being reported by yetus, but the effort here is not about checkstyle cleanup.) > Need updated mockito for using java optional > -------------------------------------------- > > Key: HBASE-18925 > URL: https://issues.apache.org/jira/browse/HBASE-18925 > Project: HBase > Issue Type: Improvement > Reporter: Appy > Assignee: Appy > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18925.master.001.patch, > HBASE-18925.master.002.patch, HBASE-18925.master.002.patch, > HBASE-18925.master.003.patch, HBASE-18925.master.004.patch, > HBASE-18925.master.005.patch, HBASE-18925.master.006.patch, > HBASE-18925.master.007.patch, HBASE-18925.master.008.patch > > > Came up when i was trying to test HBASE-18878. > It kept failing because mock of RpcCall returned null where return type was > Optional<User>. > Instead, we want it to return Optional.empty(). > New mockito versions support this (and other java8 things) - > https://github.com/mockito/mockito/wiki/What%27s-new-in-Mockito-2 > We use mockito-all which was last released in Dec2014. However, mockito-core > has had more than 50 releases after that > (https://mvnrepository.com/artifact/org.mockito/mockito-core). > We need to change our deps from mockito-all to mockito-core. > However that comes with fair breakages, so this is not a simple task of > changing pom files. -- This message was sent by Atlassian JIRA (v6.4.14#64029)