[ https://issues.apache.org/jira/browse/HBASE-3084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Spiegelberg updated HBASE-3084: --------------------------------------- Component/s: master io Description: Nicolas reviewed HBASE-2437 after it had been committed and raised some issues that need addressing. The main issue is that splitLog will ignore user interrupts (aka: InterruptException). Currently, data loss can occur (with 'skip.errors' == true) if a user calls 'kill <master-pid>" during splits because the code will consider the interrupted file completely split. If the master receives an interrupt during splitLog, it needs to abort splitting, delete all partially-complete split files, and exit gracefully. (was: Nicolas reviewed hbase-2437 after it had been committed and raised some issues that need addressing: See https://issues.apache.org/jira/browse/HBASE-2437?focusedCommentId=12881937&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12881937) Affects Version/s: 0.92.0 0.90.0 0.89.20100924 Summary: HLog splitLog : Properly Handle User Interrupts (was: Address review comments raised post commit of hbase-2437, "Refactor HLog splitLog") > HLog splitLog : Properly Handle User Interrupts > ----------------------------------------------- > > Key: HBASE-3084 > URL: https://issues.apache.org/jira/browse/HBASE-3084 > Project: HBase > Issue Type: Bug > Components: io, master > Affects Versions: 0.89.20100924, 0.90.0, 0.92.0 > Reporter: stack > > Nicolas reviewed HBASE-2437 after it had been committed and raised some > issues that need addressing. The main issue is that splitLog will ignore > user interrupts (aka: InterruptException). Currently, data loss can occur > (with 'skip.errors' == true) if a user calls 'kill <master-pid>" during > splits because the code will consider the interrupted file completely split. > If the master receives an interrupt during splitLog, it needs to abort > splitting, delete all partially-complete split files, and exit gracefully. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.