Re: [PR] HBASE-28175: Deep copy RpcLogDetails' param field [hbase]

2023-11-06 Thread via GitHub
rmdmattingly commented on code in PR #5481: URL: https://github.com/apache/hbase/pull/5481#discussion_r1383448371 ## hbase-server/src/main/java/org/apache/hadoop/hbase/namequeues/RpcLogDetails.java: ## @@ -60,6 +64,18 @@ public RpcLogDetails(RpcCall rpcCall, Message param,

Re: [PR] HBASE-27276 Reduce reflection overhead in Filter deserialization [hbase]

2023-11-06 Thread via GitHub
Apache-HBase commented on PR #5488: URL: https://github.com/apache/hbase/pull/5488#issuecomment-1795096884 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s |

Re: [PR] HBASE-28180 Review the usage of RegionStates.getOrCreateServer [hbase]

2023-11-04 Thread via GitHub
Apache-HBase commented on PR #5486: URL: https://github.com/apache/hbase/pull/5486#issuecomment-1793415768 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

Re: [PR] HBASE-28185 Alter table to set TTL using hbase shell failed when ttl … [hbase]

2023-11-04 Thread via GitHub
chaijunjie0101 commented on code in PR #5494: URL: https://github.com/apache/hbase/pull/5494#discussion_r1382380098 ## hbase-common/src/main/java/org/apache/hadoop/hbase/util/PrettyPrinter.java: ## @@ -184,7 +184,12 @@ private static long humanReadableIntervalToSec(final

Re: [PR] HBASE-28185 Alter table to set TTL using hbase shell failed when ttl … [hbase]

2023-11-04 Thread via GitHub
Apache-HBase commented on PR #5494: URL: https://github.com/apache/hbase/pull/5494#issuecomment-1793429551 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s |

Re: [PR] HBASE-28185 Alter table to set TTL using hbase shell failed when ttl … [hbase]

2023-11-04 Thread via GitHub
Apache-HBase commented on PR #5494: URL: https://github.com/apache/hbase/pull/5494#issuecomment-1793430561 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

Re: [PR] HBASE-28185 Alter table to set TTL using hbase shell failed when ttl … [hbase]

2023-11-04 Thread via GitHub
Apache-HBase commented on PR #5494: URL: https://github.com/apache/hbase/pull/5494#issuecomment-1793431347 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s |

Re: [PR] HBASE-28180 Review the usage of RegionStates.getOrCreateServer [hbase]

2023-11-04 Thread via GitHub
Apache9 commented on PR #5486: URL: https://github.com/apache/hbase/pull/5486#issuecomment-1793436111 OK, we can see that ``` 2023-11-03T19:10:25,517 DEBUG [RegionServerTracker-0 {}] procedure2.ProcedureExecutor(1032): Stored pid=675, state=RUNNABLE:SERVER_CRASH_START,

Re: [PR] HBASE-28180 Review the usage of RegionStates.getOrCreateServer [hbase]

2023-11-04 Thread via GitHub
Apache-HBase commented on PR #5486: URL: https://github.com/apache/hbase/pull/5486#issuecomment-1793444763 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

Re: [PR] HBASE-27276 Reduce reflection overhead in Filter deserialization [hbase]

2023-11-06 Thread via GitHub
Apache-HBase commented on PR #5488: URL: https://github.com/apache/hbase/pull/5488#issuecomment-1796230994 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s |

Re: [PR] HBASE-28184 Tailing the WAL is very slow if there are multiple peers [hbase]

2023-11-06 Thread via GitHub
Apache-HBase commented on PR #5503: URL: https://github.com/apache/hbase/pull/5503#issuecomment-1796304020 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s |

Re: [PR] HBASE-28043 Reduce seeks from beginning of block in StoreFileScanner.seekToPreviousRow [hbase]

2023-11-06 Thread via GitHub
Apache-HBase commented on PR #5373: URL: https://github.com/apache/hbase/pull/5373#issuecomment-1795597778 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 5s |

Re: [PR] HBASE-28185 Alter table to set TTL using hbase shell failed when ttl … [hbase]

2023-11-04 Thread via GitHub
Apache9 commented on code in PR #5494: URL: https://github.com/apache/hbase/pull/5494#discussion_r138235 ## hbase-common/src/main/java/org/apache/hadoop/hbase/util/PrettyPrinter.java: ## @@ -184,7 +184,12 @@ private static long humanReadableIntervalToSec(final String

Re: [PR] HBASE-28180 Review the usage of RegionStates.getOrCreateServer [hbase]

2023-11-04 Thread via GitHub
Apache9 commented on PR #5486: URL: https://github.com/apache/hbase/pull/5486#issuecomment-1793397862 Ah the log is too big so it has been truncated... Let me see if I can reproduce the problem locally... -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] HBASE-28180 Review the usage of RegionStates.getOrCreateServer [hbase]

2023-11-04 Thread via GitHub
Apache-HBase commented on PR #5486: URL: https://github.com/apache/hbase/pull/5486#issuecomment-1793413736 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

Re: [PR] HBASE-28180 Review the usage of RegionStates.getOrCreateServer [hbase]

2023-11-04 Thread via GitHub
Apache9 commented on PR #5486: URL: https://github.com/apache/hbase/pull/5486#issuecomment-1793397029 ··· 2023-11-03T19:10:49,850 INFO [RS_OPEN_REGION-regionserver/021d69fb7740:0-0 {event_type=M_RS_OPEN_REGION, pid=905}] regionserver.HRegionServer(2186): Post open deploy tasks for

Re: [PR] HBASE-28175: Deep copy RpcLogDetails' param field [hbase]

2023-11-06 Thread via GitHub
Apache-HBase commented on PR #5481: URL: https://github.com/apache/hbase/pull/5481#issuecomment-1795940118 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 23s |

Re: [PR] HBASE-28175: Deep copy RpcLogDetails' param field [hbase]

2023-11-06 Thread via GitHub
Apache-HBase commented on PR #5481: URL: https://github.com/apache/hbase/pull/5481#issuecomment-1795946764 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s |

Re: [PR] HBASE-27276 Reduce reflection overhead in Filter deserialization [hbase]

2023-11-06 Thread via GitHub
Apache-HBase commented on PR #5488: URL: https://github.com/apache/hbase/pull/5488#issuecomment-1795951506 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

Re: [PR] HBASE-28184 Tailing the WAL is very slow if there are multiple peers [hbase]

2023-11-06 Thread via GitHub
Apache-HBase commented on PR #5504: URL: https://github.com/apache/hbase/pull/5504#issuecomment-1796401330 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 28s |

Re: [PR] HBASE-28184 Tailing the WAL is very slow if there are multiple peers [hbase]

2023-11-06 Thread via GitHub
Apache-HBase commented on PR #5505: URL: https://github.com/apache/hbase/pull/5505#issuecomment-1796409945 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 14s |

Re: [PR] HBASE-28043 Reduce seeks from beginning of block in StoreFileScanner.seekToPreviousRow [hbase]

2023-11-06 Thread via GitHub
Apache-HBase commented on PR #5373: URL: https://github.com/apache/hbase/pull/5373#issuecomment-1796429608 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

[PR] HBASE-28189 Fix the miss count in one of CombinedBlockCache getBlock implementations [hbase]

2023-11-06 Thread via GitHub
wchevreuil opened a new pull request, #5506: URL: https://github.com/apache/hbase/pull/5506 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] HBASE-28120 Switch that allows avoiding reopening all regions when altering table [hbase]

2023-10-30 Thread via GitHub
Apache-HBase commented on PR #5482: URL: https://github.com/apache/hbase/pull/5482#issuecomment-1785384713 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

Re: [PR] HBASE-28153 Upgrade zookeeper to a newer version [hbase]

2023-10-30 Thread via GitHub
Apache-HBase commented on PR #5484: URL: https://github.com/apache/hbase/pull/5484#issuecomment-1785417676 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s |

Re: [PR] HBASE-28064:Implement truncate_region command [hbase]

2023-10-30 Thread via GitHub
wchevreuil commented on PR #5480: URL: https://github.com/apache/hbase/pull/5480#issuecomment-1785373478 > Looks like the UT failure is looking unrelated to my changes. Previous yetus run reported "org.apache.hadoop.hbase.client.TestTableShell" as failed test. > > But this test is

Re: [PR] HBASE-28120 Switch that allows avoiding reopening all regions when altering table [hbase]

2023-10-30 Thread via GitHub
Apache-HBase commented on PR #5482: URL: https://github.com/apache/hbase/pull/5482#issuecomment-1785382296 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 39s |

Re: [PR] HBASE-28153 Upgrade zookeeper to a newer version [hbase]

2023-10-27 Thread via GitHub
Apache-HBase commented on PR #5475: URL: https://github.com/apache/hbase/pull/5475#issuecomment-1783466423 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 32s |

Re: [PR] HBASE-28176 PrefetchExecutor should stop once cache reaches capacity [hbase]

2023-10-27 Thread via GitHub
Apache-HBase commented on PR #5474: URL: https://github.com/apache/hbase/pull/5474#issuecomment-1783476368 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

Re: [PR] HBASE-28176 PrefetchExecutor should stop once cache reaches capacity [hbase]

2023-10-27 Thread via GitHub
Apache-HBase commented on PR #5474: URL: https://github.com/apache/hbase/pull/5474#issuecomment-1783494963 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

Re: [PR] HBASE-28153 Upgrade zookeeper to a newer version [hbase]

2023-10-27 Thread via GitHub
Apache-HBase commented on PR #5475: URL: https://github.com/apache/hbase/pull/5475#issuecomment-1783534624 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 56s |

Re: [PR] HBASE-28175: Deep copy RpcLogDetails' param field [hbase]

2023-10-26 Thread via GitHub
bbeaudreault commented on PR #5481: URL: https://github.com/apache/hbase/pull/5481#issuecomment-1781829679 This might seem silly, but I wonder if you could at least do the simple test of: - Create a protobuf and write it to a ByteBuffer - Create another protobuf backed by a

Re: [PR] HBASE-28175: Deep copy RpcLogDetails' param field [hbase]

2023-10-26 Thread via GitHub
rmdmattingly commented on PR #5481: URL: https://github.com/apache/hbase/pull/5481#issuecomment-1781832520 Nice, I like that idea! I'm headed out on vacation tonight, but will add that test when I return later next week -- This is an automated message from the Apache Git Service. To

Re: [PR] HBASE-28175: Deep copy RpcLogDetails' param field [hbase]

2023-10-26 Thread via GitHub
Apache-HBase commented on PR #5481: URL: https://github.com/apache/hbase/pull/5481#issuecomment-1781836520 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 23s |

Re: [PR] HBASE-28175: Deep copy RpcLogDetails' param field [hbase]

2023-10-26 Thread via GitHub
rmdmattingly commented on code in PR #5481: URL: https://github.com/apache/hbase/pull/5481#discussion_r1373772349 ## hbase-server/src/main/java/org/apache/hadoop/hbase/namequeues/RpcLogDetails.java: ## @@ -60,6 +66,40 @@ public RpcLogDetails(RpcCall rpcCall, Message param,

Re: [PR] HBASE-27769 use LeaseRecoverable and SafeMode introduced in hadoop-co… [hbase]

2023-10-26 Thread via GitHub
Apache-HBase commented on PR #5469: URL: https://github.com/apache/hbase/pull/5469#issuecomment-1781845997 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s |

Re: [PR] HBASE-28175: Deep copy RpcLogDetails' param field [hbase]

2023-10-26 Thread via GitHub
bbeaudreault commented on PR #5481: URL: https://github.com/apache/hbase/pull/5481#issuecomment-1781872024 An alternative approach here might be to find a way to call ByteBuffer.retain() when creating the SlowLogParams, and then ByteBuffer.release() when consuming in SlowLogService. That

Re: [PR] HBASE-28175: Deep copy RpcLogDetails' param field [hbase]

2023-10-26 Thread via GitHub
Apache-HBase commented on PR #5481: URL: https://github.com/apache/hbase/pull/5481#issuecomment-1781881495 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 14s |

Re: [PR] HBASE-27794: Tooling for parsing/reading the prefetch files list file [hbase]

2023-10-30 Thread via GitHub
Apache-HBase commented on PR #5468: URL: https://github.com/apache/hbase/pull/5468#issuecomment-1785655116 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 15s |

Re: [PR] HBASE-28180 Review the usage of RegionStates.getOrCreateServer [hbase]

2023-10-30 Thread via GitHub
Apache-HBase commented on PR #5486: URL: https://github.com/apache/hbase/pull/5486#issuecomment-1785502008 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s |

Re: [PR] HBASE-28176 PrefetchExecutor should stop once cache reaches capacity [hbase]

2023-10-30 Thread via GitHub
Apache-HBase commented on PR #5474: URL: https://github.com/apache/hbase/pull/5474#issuecomment-1785512255 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s |

Re: [PR] HBASE-28176 PrefetchExecutor should stop once cache reaches capacity [hbase]

2023-10-30 Thread via GitHub
Apache-HBase commented on PR #5474: URL: https://github.com/apache/hbase/pull/5474#issuecomment-1785524779 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

Re: [PR] HBASE-28153 Upgrade zookeeper to a newer version [hbase]

2023-10-30 Thread via GitHub
Apache-HBase commented on PR #5475: URL: https://github.com/apache/hbase/pull/5475#issuecomment-1785566102 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

Re: [PR] HBASE-28046 adding capability for moving all servers between 2 rs groups [hbase]

2023-10-25 Thread via GitHub
Apache-HBase commented on PR #5477: URL: https://github.com/apache/hbase/pull/5477#issuecomment-1778820808 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s |

Re: [PR] HBASE-24179 Backport fix for "Netty SASL implementation does not wait for challenge response" to branch-2.x [hbase]

2023-10-25 Thread via GitHub
NihalJain merged PR #5472: URL: https://github.com/apache/hbase/pull/5472 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-24179 Backport fix for "Netty SASL implementation does not wait for challenge response" to branch-2.x [hbase]

2023-10-25 Thread via GitHub
NihalJain commented on PR #5472: URL: https://github.com/apache/hbase/pull/5472#issuecomment-1778752138 @Apache9 need your heads up to pull this one to branch-2.5, and branch-2.4. Please let me know WDYT. -- This is an automated message from the Apache Git Service. To respond to the

[PR] HBASE-28110 Align TestShadeSaslAuthenticationProvider between differe… [hbase]

2023-10-25 Thread via GitHub
NihalJain opened a new pull request, #5478: URL: https://github.com/apache/hbase/pull/5478 …nt branches -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] HBASE-28110 Align TestShadeSaslAuthenticationProvider between differe… [hbase]

2023-10-25 Thread via GitHub
Apache-HBase commented on PR #5478: URL: https://github.com/apache/hbase/pull/5478#issuecomment-1779125768 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 46s |

Re: [PR] HBASE-28110 Align TestShadeSaslAuthenticationProvider between differe… [hbase]

2023-10-25 Thread via GitHub
Apache-HBase commented on PR #5478: URL: https://github.com/apache/hbase/pull/5478#issuecomment-1779127475 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s |

Re: [PR] HBASE-28110 Align TestShadeSaslAuthenticationProvider between differe… [hbase]

2023-10-25 Thread via GitHub
Apache-HBase commented on PR #5478: URL: https://github.com/apache/hbase/pull/5478#issuecomment-1779147436 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 46s |

Re: [PR] HBASE-28153 Upgrade zookeeper to a newer version [hbase]

2023-10-30 Thread via GitHub
Apache-HBase commented on PR #5475: URL: https://github.com/apache/hbase/pull/5475#issuecomment-1785764645 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

Re: [PR] HBASE-28146: Make ServerManager rsAdmins map thread safe [hbase]

2023-10-18 Thread via GitHub
Apache-HBase commented on PR #5461: URL: https://github.com/apache/hbase/pull/5461#issuecomment-1769514336 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s |

Re: [PR] HBASE-28146: Make ServerManager rsAdmins map thread safe [hbase]

2023-10-18 Thread via GitHub
Apache-HBase commented on PR #5461: URL: https://github.com/apache/hbase/pull/5461#issuecomment-1769515968 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 18s |

Re: [PR] HBASE-27769 use LeaseRecoverable and SafeMode introduced in hadoop-co… [hbase]

2023-10-18 Thread via GitHub
Apache-HBase commented on PR #5469: URL: https://github.com/apache/hbase/pull/5469#issuecomment-1769584266 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 12s |

[PR] HBASE-27769 use LeaseRecoverable and SafeMode introduced in hadoop-co… [hbase]

2023-10-18 Thread via GitHub
taklwu opened a new pull request, #5469: URL: https://github.com/apache/hbase/pull/5469 …mmon - also upgrade to hadoop.version 3.3.6 for this feature branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] HBASE-28158 Decouple RIT list management from TRSP invocation [hbase]

2023-10-18 Thread via GitHub
apurtell commented on code in PR #5464: URL: https://github.com/apache/hbase/pull/5464#discussion_r1364688488 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStates.java: ## @@ -627,7 +627,21 @@ public boolean hasRegionsInTransition() { public

Re: [PR] HBASE-27794: Tooling for parsing/reading the prefetch files list file [hbase]

2023-10-18 Thread via GitHub
Apache-HBase commented on PR #5468: URL: https://github.com/apache/hbase/pull/5468#issuecomment-1769538721 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

Re: [PR] HBASE-27794: Tooling for parsing/reading the prefetch files list file [hbase]

2023-10-18 Thread via GitHub
Apache-HBase commented on PR #5468: URL: https://github.com/apache/hbase/pull/5468#issuecomment-1769551006 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

Re: [PR] HBASE-28158 Decouple RIT list management from TRSP invocation [hbase]

2023-10-18 Thread via GitHub
apurtell commented on PR #5464: URL: https://github.com/apache/hbase/pull/5464#issuecomment-1769575094 Yes I have legit test failures to resolve, doing that soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[PR] HBASE-28168 Add option in RegionMover.java to isolate one or more reg… [hbase]

2023-10-18 Thread via GitHub
mihir6692 opened a new pull request, #5470: URL: https://github.com/apache/hbase/pull/5470 …ions on the RegionSever -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] HBASE-28168 Add option in RegionMover.java to isolate one or more reg… [hbase]

2023-10-18 Thread via GitHub
Apache-HBase commented on PR #5470: URL: https://github.com/apache/hbase/pull/5470#issuecomment-1769981880 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

Re: [PR] HBASE-27769 use LeaseRecoverable and SafeMode introduced in hadoop-co… [hbase]

2023-10-18 Thread via GitHub
Apache-HBase commented on PR #5469: URL: https://github.com/apache/hbase/pull/5469#issuecomment-1770108560 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s |

Re: [PR] HBASE-27769 use LeaseRecoverable and SafeMode introduced in hadoop-co… [hbase]

2023-10-18 Thread via GitHub
Apache-HBase commented on PR #5469: URL: https://github.com/apache/hbase/pull/5469#issuecomment-1769857171 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

Re: [PR] HBASE-28043 Reduce seeks from beginning of block in StoreFileScanner.seekToPreviousRow [hbase]

2023-10-17 Thread via GitHub
jbewing commented on PR #5373: URL: https://github.com/apache/hbase/pull/5373#issuecomment-1766897059 > do we have a way to identify meta lookups, so that we could revert to the original seeking approach in those cases? We could probably do this (or approximate it), but the problem

[GitHub] [hbase-thirdparty] NihalJain commented on a diff in pull request #102: HBASE-28093 [hbase-thirdparty] Bump thirdparty dependencies

2023-09-19 Thread via GitHub
NihalJain commented on code in PR #102: URL: https://github.com/apache/hbase-thirdparty/pull/102#discussion_r1329830338 ## hbase-shaded-protobuf/src/main/patches/HBASE-15789_V2.patch: ## @@ -1,5 +1,5 @@ diff --git a/src/main/java/com/google/protobuf/ByteBufferWriter.java

[GitHub] [hbase-thirdparty] Apache-HBase commented on pull request #103: HBASE-28096 [hbase-thirdparty] Also relocate the proto files in proto…

2023-09-19 Thread via GitHub
Apache-HBase commented on PR #103: URL: https://github.com/apache/hbase-thirdparty/pull/103#issuecomment-1725092084 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 1s

[GitHub] [hbase] Apache-HBase commented on pull request #5398: Forward-port "HBASE-28065 Corrupt HFile data is mishandled in several cases" to master

2023-09-19 Thread via GitHub
Apache-HBase commented on PR #5398: URL: https://github.com/apache/hbase/pull/5398#issuecomment-1725106713 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

[GitHub] [hbase-thirdparty] Apache-HBase commented on pull request #103: HBASE-28096 [hbase-thirdparty] Also relocate the proto files in proto…

2023-09-19 Thread via GitHub
Apache-HBase commented on PR #103: URL: https://github.com/apache/hbase-thirdparty/pull/103#issuecomment-1725163013 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] frostruan commented on pull request #5408: HBASE-26974 Introduce a LogRollProcedure

2023-09-17 Thread via GitHub
frostruan commented on PR #5408: URL: https://github.com/apache/hbase/pull/5408#issuecomment-1722687888 The failed UT looks not related. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hbase] Apache-HBase commented on pull request #5407: HBASE-28089 Upgrade BouncyCastle to fix CVE-2023-33201

2023-09-19 Thread via GitHub
Apache-HBase commented on PR #5407: URL: https://github.com/apache/hbase/pull/5407#issuecomment-1725400541 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

[GitHub] [hbase] Apache-HBase commented on pull request #5384: HBASE-28065 Corrupt HFile data is mishandled in several cases (branch-2.5)

2023-09-19 Thread via GitHub
Apache-HBase commented on PR #5384: URL: https://github.com/apache/hbase/pull/5384#issuecomment-1725402665 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s |

[GitHub] [hbase] Apache-HBase commented on pull request #5398: Forward-port "HBASE-28065 Corrupt HFile data is mishandled in several cases" to master

2023-09-19 Thread via GitHub
Apache-HBase commented on PR #5398: URL: https://github.com/apache/hbase/pull/5398#issuecomment-1725413301 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s |

[GitHub] [hbase] Apache-HBase commented on pull request #5403: HBASE-28068 : Add hbase.normalizer.merge.merge_request_max_number_of_regions property …

2023-09-19 Thread via GitHub
Apache-HBase commented on PR #5403: URL: https://github.com/apache/hbase/pull/5403#issuecomment-1726270463 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s |

[GitHub] [hbase] Apache-HBase commented on pull request #5403: HBASE-28068 : Add hbase.normalizer.merge.merge_request_max_number_of_regions property …

2023-09-19 Thread via GitHub
Apache-HBase commented on PR #5403: URL: https://github.com/apache/hbase/pull/5403#issuecomment-1726325228 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 23s |

[GitHub] [hbase] Apache-HBase commented on pull request #5407: HBASE-28089 Upgrade BouncyCastle to fix CVE-2023-33201

2023-09-19 Thread via GitHub
Apache-HBase commented on PR #5407: URL: https://github.com/apache/hbase/pull/5407#issuecomment-1726787169 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

[GitHub] [hbase] Apache-HBase commented on pull request #5412: [branch-2 ] HBASE-27981 Add connection and request attributes to slow log (#5335)

2023-09-19 Thread via GitHub
Apache-HBase commented on PR #5412: URL: https://github.com/apache/hbase/pull/5412#issuecomment-1726334465 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 14s |

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #5402: HBASE-28085 Configurably use scanner timeout as rpc timeout for scanner next calls

2023-09-19 Thread via GitHub
bbeaudreault commented on code in PR #5402: URL: https://github.com/apache/hbase/pull/5402#discussion_r1330557602 ## hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionConfiguration.java: ## @@ -76,6 +76,11 @@ public class ConnectionConfiguration { public

[GitHub] [hbase] Apache-HBase commented on pull request #5398: Forward-port "HBASE-28065 Corrupt HFile data is mishandled in several cases" to master

2023-09-19 Thread via GitHub
Apache-HBase commented on PR #5398: URL: https://github.com/apache/hbase/pull/5398#issuecomment-1726323062 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 48s |

[GitHub] [hbase] Apache-HBase commented on pull request #5412: [branch-2 ] HBASE-27981 Add connection and request attributes to slow log (#5335)

2023-09-19 Thread via GitHub
Apache-HBase commented on PR #5412: URL: https://github.com/apache/hbase/pull/5412#issuecomment-1726379818 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

[GitHub] [hbase] Apache-HBase commented on pull request #5402: HBASE-28085 Configurably use scanner timeout as rpc timeout for scanner next calls

2023-09-19 Thread via GitHub
Apache-HBase commented on PR #5402: URL: https://github.com/apache/hbase/pull/5402#issuecomment-1726640562 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 53s |

[GitHub] [hbase] Apache-HBase commented on pull request #5384: HBASE-28065 Corrupt HFile data is mishandled in several cases (branch-2.5)

2023-09-19 Thread via GitHub
Apache-HBase commented on PR #5384: URL: https://github.com/apache/hbase/pull/5384#issuecomment-1726294161 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s |

[GitHub] [hbase] Apache-HBase commented on pull request #5411: HBASE-22138 Undo our direct dependence on protos in google.protobuf.A…

2023-09-19 Thread via GitHub
Apache-HBase commented on PR #5411: URL: https://github.com/apache/hbase/pull/5411#issuecomment-1726529697 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 12s |

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #5402: HBASE-28085 Configurably use scanner timeout as rpc timeout for scanner next calls

2023-09-19 Thread via GitHub
bbeaudreault commented on code in PR #5402: URL: https://github.com/apache/hbase/pull/5402#discussion_r1330451481 ## hbase-client/src/main/java/org/apache/hadoop/hbase/client/ScannerCallableWithReplicas.java: ## @@ -72,11 +73,12 @@ class ScannerCallableWithReplicas implements

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #5402: HBASE-28085 Configurably use scanner timeout as rpc timeout for scanner next calls

2023-09-19 Thread via GitHub
bbeaudreault commented on code in PR #5402: URL: https://github.com/apache/hbase/pull/5402#discussion_r1330557899 ## hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientScannerTimeouts.java: ## @@ -101,6 +102,9 @@ public static void setUpBeforeClass() throws

[GitHub] [hbase] Apache-HBase commented on pull request #5402: HBASE-28085 Configurably use scanner timeout as rpc timeout for scanner next calls

2023-09-19 Thread via GitHub
Apache-HBase commented on PR #5402: URL: https://github.com/apache/hbase/pull/5402#issuecomment-1726344820 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

[GitHub] [hbase] Apache-HBase commented on pull request #5403: HBASE-28068 : Add hbase.normalizer.merge.merge_request_max_number_of_regions property …

2023-09-19 Thread via GitHub
Apache-HBase commented on PR #5403: URL: https://github.com/apache/hbase/pull/5403#issuecomment-1726631497 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s |

[GitHub] [hbase] Apache-HBase commented on pull request #5402: HBASE-28085 Configurably use scanner timeout as rpc timeout for scanner next calls

2023-09-19 Thread via GitHub
Apache-HBase commented on PR #5402: URL: https://github.com/apache/hbase/pull/5402#issuecomment-1726631985 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

[GitHub] [hbase] bbeaudreault merged pull request #5412: [branch-2 ] HBASE-27981 Add connection and request attributes to slow log (#5335)

2023-09-19 Thread via GitHub
bbeaudreault merged PR #5412: URL: https://github.com/apache/hbase/pull/5412 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] Apache9 commented on pull request #5411: HBASE-22138 Undo our direct dependence on protos in google.protobuf.A…

2023-09-19 Thread via GitHub
Apache9 commented on PR #5411: URL: https://github.com/apache/hbase/pull/5411#issuecomment-1726696077 Ah, an error prone error... Let me check what is the root cause, maybe the problem is we upgrade the error prone annotation version in hbase-thirdparty. -- This is an automated

[GitHub] [hbase] Apache-HBase commented on pull request #5411: HBASE-22138 Undo our direct dependence on protos in google.protobuf.A…

2023-09-19 Thread via GitHub
Apache-HBase commented on PR #5411: URL: https://github.com/apache/hbase/pull/5411#issuecomment-1726356355 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s |

[GitHub] [hbase] Apache-HBase commented on pull request #5407: HBASE-28089 Upgrade BouncyCastle to fix CVE-2023-33201

2023-09-19 Thread via GitHub
Apache-HBase commented on PR #5407: URL: https://github.com/apache/hbase/pull/5407#issuecomment-1726538394 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

[GitHub] [hbase] Apache-HBase commented on pull request #5403: HBASE-28068 : Add hbase.normalizer.merge.merge_request_max_number_of_regions property …

2023-09-19 Thread via GitHub
Apache-HBase commented on PR #5403: URL: https://github.com/apache/hbase/pull/5403#issuecomment-1726669261 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s |

[GitHub] [hbase] Apache-HBase commented on pull request #5430: HBASE-27970 Make sync replication also work with FSHLog

2023-09-22 Thread via GitHub
Apache-HBase commented on PR #5430: URL: https://github.com/apache/hbase/pull/5430#issuecomment-1731783604 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

[GitHub] [hbase] Apache-HBase commented on pull request #5430: HBASE-27970 Make sync replication also work with FSHLog

2023-09-22 Thread via GitHub
Apache-HBase commented on PR #5430: URL: https://github.com/apache/hbase/pull/5430#issuecomment-1731781468 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 12s |

[GitHub] [hbase] Apache-HBase commented on pull request #5426: HBASE-28105 NPE in QuotaCache if Table is dropped from cluster

2023-09-22 Thread via GitHub
Apache-HBase commented on PR #5426: URL: https://github.com/apache/hbase/pull/5426#issuecomment-1732174014 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s |

[GitHub] [hbase] Apache-HBase commented on pull request #5426: HBASE-28105 NPE in QuotaCache if Table is dropped from cluster

2023-09-22 Thread via GitHub
Apache-HBase commented on PR #5426: URL: https://github.com/apache/hbase/pull/5426#issuecomment-1732172574 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s |

[GitHub] [hbase] Apache-HBase commented on pull request #5426: HBASE-28105 NPE in QuotaCache if Table is dropped from cluster

2023-09-22 Thread via GitHub
Apache-HBase commented on PR #5426: URL: https://github.com/apache/hbase/pull/5426#issuecomment-1732075534 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s |

[GitHub] [hbase] hanke580 commented on pull request #5426: HBASE-28105 NPE in QuotaCache if Table is dropped from cluster

2023-09-22 Thread via GitHub
hanke580 commented on PR #5426: URL: https://github.com/apache/hbase/pull/5426#issuecomment-1732051071 Make sense. I have updated the commit to remove the dropped tableName from tableMachineQuotaFactors. Is there any other place you suggest me to modify? -- This is an automated message

[GitHub] [hbase] rmdmattingly commented on a diff in pull request #5424: HBASE-27784: support quota user overrides

2023-09-22 Thread via GitHub
rmdmattingly commented on code in PR #5424: URL: https://github.com/apache/hbase/pull/5424#discussion_r1334720397 ## hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/QuotaCache.java: ## @@ -57,6 +61,11 @@ public class QuotaCache implements Stoppable { private static

[GitHub] [hbase] Apache-HBase commented on pull request #5425: HBASE-27991 [hbase-examples] MultiThreadedClientExample throws java.l…

2023-09-21 Thread via GitHub
Apache-HBase commented on PR #5425: URL: https://github.com/apache/hbase/pull/5425#issuecomment-1729480629 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 17s |

<    6   7   8   9   10   11   12   13   14   15   >