[PR] Add stoty to the developer list [hbase]

2024-04-02 Thread via GitHub
stoty opened a new pull request, #5790: URL: https://github.com/apache/hbase/pull/5790 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Add stoty to the developer list [hbase]

2024-04-02 Thread via GitHub
Apache-HBase commented on PR #5790: URL: https://github.com/apache/hbase/pull/5790#issuecomment-2032219398 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docke

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-04-02 Thread via GitHub
virajjasani commented on code in PR #5774: URL: https://github.com/apache/hbase/pull/5774#discussion_r1548126408 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java: ## @@ -324,8 +324,23 @@ public void regionServerReport(ServerName sn, ServerMetrics

Re: [PR] Add stoty to the developer list [hbase]

2024-04-02 Thread via GitHub
Apache-HBase commented on PR #5790: URL: https://github.com/apache/hbase/pull/5790#issuecomment-2032743125 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker

Re: [PR] HBASE-28448 CompressionTest hangs when run over a Ozone ofs path [hbase]

2024-04-02 Thread via GitHub
jojochuang commented on PR #5771: URL: https://github.com/apache/hbase/pull/5771#issuecomment-2032791834 TestRollbackSCP passed in my local tree so i'll just retrigger and hope it passed this time. -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] Add stoty to the developer list [hbase]

2024-04-02 Thread via GitHub
Apache-HBase commented on PR #5790: URL: https://github.com/apache/hbase/pull/5790#issuecomment-2032794238 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker

Re: [PR] HBASE-28448 CompressionTest hangs when run over a Ozone ofs path [hbase]

2024-04-02 Thread via GitHub
Apache-HBase commented on PR #5771: URL: https://github.com/apache/hbase/pull/5771#issuecomment-2032797237 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docker

[PR] [ADDENDUM] HBASE-28458 BucketCache.notifyFileCachingCompleted may incorrectly consider a file fully cached (#5777) [hbase]

2024-04-02 Thread via GitHub
wchevreuil opened a new pull request, #5791: URL: https://github.com/apache/hbase/pull/5791 While backporting original PR to branch-2, I still got some failures for TestBucketCachePersister.testPrefetchBlockEvictionWhilePrefetchRunning. I believe I was using the wrong offset in BucketCache.

Re: [PR] HBASE-28448 CompressionTest hangs when run over a Ozone ofs path [hbase]

2024-04-02 Thread via GitHub
Apache-HBase commented on PR #5771: URL: https://github.com/apache/hbase/pull/5771#issuecomment-2032904791 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docke

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-04-02 Thread via GitHub
Apache-HBase commented on PR #5774: URL: https://github.com/apache/hbase/pull/5774#issuecomment-2032962089 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 15s | Docker

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-04-02 Thread via GitHub
Apache-HBase commented on PR #5774: URL: https://github.com/apache/hbase/pull/5774#issuecomment-2032962099 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docke

Re: [PR] [ADDENDUM] HBASE-28458 BucketCache.notifyFileCachingCompleted may incorrectly consider a file fully cached (#5777) [hbase]

2024-04-02 Thread via GitHub
Apache-HBase commented on PR #5791: URL: https://github.com/apache/hbase/pull/5791#issuecomment-2032969161 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s | Docke

Re: [PR] Add stoty to the developer list [hbase]

2024-04-02 Thread via GitHub
Apache-HBase commented on PR #5790: URL: https://github.com/apache/hbase/pull/5790#issuecomment-2033017605 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docker

Re: [PR] [ADDENDUM] HBASE-28458 BucketCache.notifyFileCachingCompleted may incorrectly consider a file fully cached (#5777) [hbase]

2024-04-02 Thread via GitHub
Apache-HBase commented on PR #5791: URL: https://github.com/apache/hbase/pull/5791#issuecomment-2033250571 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docker

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-04-02 Thread via GitHub
Apache-HBase commented on PR #5774: URL: https://github.com/apache/hbase/pull/5774#issuecomment-2033273874 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-04-02 Thread via GitHub
Apache-HBase commented on PR #5774: URL: https://github.com/apache/hbase/pull/5774#issuecomment-2033351237 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker

Re: [PR] [ADDENDUM] HBASE-28458 BucketCache.notifyFileCachingCompleted may incorrectly consider a file fully cached (#5777) [hbase]

2024-04-02 Thread via GitHub
Apache-HBase commented on PR #5791: URL: https://github.com/apache/hbase/pull/5791#issuecomment-2033357198 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 47s | Docker

Re: [PR] HBASE-28448 CompressionTest hangs when run over a Ozone ofs path [hbase]

2024-04-02 Thread via GitHub
Apache-HBase commented on PR #5771: URL: https://github.com/apache/hbase/pull/5771#issuecomment-2033363466 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docke

Re: [PR] [ADDENDUM] HBASE-28458 BucketCache.notifyFileCachingCompleted may incorrectly consider a file fully cached (#5777) [hbase]

2024-04-02 Thread via GitHub
Apache-HBase commented on PR #5791: URL: https://github.com/apache/hbase/pull/5791#issuecomment-2033363164 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 14s | Docker

[PR] HBASE-28482 Reverse scan with tags throws ArrayIndexOutOfBoundsException with DBE in setCurrentBlock flow [hbase]

2024-04-02 Thread via GitHub
vineet4008 opened a new pull request, #5792: URL: https://github.com/apache/hbase/pull/5792 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [PR] HBASE-28448 CompressionTest hangs when run over a Ozone ofs path [hbase]

2024-04-02 Thread via GitHub
Apache-HBase commented on PR #5771: URL: https://github.com/apache/hbase/pull/5771#issuecomment-2033522786 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 18s | Docke

Re: [PR] HBASE-28482 Reverse scan with tags throws ArrayIndexOutOfBoundsException with DBE in setCurrentBlock flow [hbase]

2024-04-02 Thread via GitHub
Apache-HBase commented on PR #5792: URL: https://github.com/apache/hbase/pull/5792#issuecomment-2033552777 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 57s | Docker

Re: [PR] Add stoty to the developer list [hbase]

2024-04-02 Thread via GitHub
stoty merged PR #5790: URL: https://github.com/apache/hbase/pull/5790 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.or

Re: [PR] HBASE-28448 CompressionTest hangs when run over a Ozone ofs path [hbase]

2024-04-03 Thread via GitHub
Apache-HBase commented on PR #5771: URL: https://github.com/apache/hbase/pull/5771#issuecomment-2033710810 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s | Docker

Re: [PR] HBASE-28448 CompressionTest hangs when run over a Ozone ofs path [hbase]

2024-04-03 Thread via GitHub
Apache-HBase commented on PR #5771: URL: https://github.com/apache/hbase/pull/5771#issuecomment-2033736864 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s | Docker

Re: [PR] HBASE-28482 Reverse scan with tags throws ArrayIndexOutOfBoundsException with DBE in setCurrentBlock flow [hbase]

2024-04-03 Thread via GitHub
Apache-HBase commented on PR #5792: URL: https://github.com/apache/hbase/pull/5792#issuecomment-2033936556 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docke

Re: [PR] HBASE-28482 Reverse scan with tags throws ArrayIndexOutOfBoundsException with DBE in setCurrentBlock flow [hbase]

2024-04-03 Thread via GitHub
Apache-HBase commented on PR #5792: URL: https://github.com/apache/hbase/pull/5792#issuecomment-2033991085 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docke

Re: [PR] HBASE-28482 Reverse scan with tags throws ArrayIndexOutOfBoundsException with DBE in setCurrentBlock flow [hbase]

2024-04-03 Thread via GitHub
Apache-HBase commented on PR #5792: URL: https://github.com/apache/hbase/pull/5792#issuecomment-2034005005 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s | Docke

Re: [PR] HBASE-28482 Reverse scan with tags throws ArrayIndexOutOfBoundsException with DBE in setCurrentBlock flow [hbase]

2024-04-03 Thread via GitHub
Apache-HBase commented on PR #5792: URL: https://github.com/apache/hbase/pull/5792#issuecomment-2034088299 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docke

Re: [PR] HBASE-28292 Make Delay prefetch property to be dynamically configured [hbase]

2024-04-03 Thread via GitHub
wchevreuil commented on code in PR #5605: URL: https://github.com/apache/hbase/pull/5605#discussion_r1549385862 ## hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestPrefetch.java: ## @@ -336,6 +337,62 @@ public void testPrefetchDoesntSkipRefs() throws Exception {

Re: [PR] HBASE-28292 Make Delay prefetch property to be dynamically configured [hbase]

2024-04-03 Thread via GitHub
kabhishek4 commented on code in PR #5605: URL: https://github.com/apache/hbase/pull/5605#discussion_r1549631943 ## hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestPrefetch.java: ## @@ -336,6 +337,62 @@ public void testPrefetchDoesntSkipRefs() throws Exception {

Re: [PR] HBASE-28292 Make Delay prefetch property to be dynamically configured [hbase]

2024-04-03 Thread via GitHub
kabhishek4 commented on code in PR #5605: URL: https://github.com/apache/hbase/pull/5605#discussion_r1549633573 ## hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestPrefetch.java: ## @@ -336,6 +337,62 @@ public void testPrefetchDoesntSkipRefs() throws Exception {

Re: [PR] HBASE-28482 Reverse scan with tags throws ArrayIndexOutOfBoundsException with DBE in setCurrentBlock flow [hbase]

2024-04-03 Thread via GitHub
Apache-HBase commented on PR #5792: URL: https://github.com/apache/hbase/pull/5792#issuecomment-2034603107 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s | Docke

Re: [PR] HBASE-28482 Reverse scan with tags throws ArrayIndexOutOfBoundsException with DBE in setCurrentBlock flow [hbase]

2024-04-03 Thread via GitHub
Apache-HBase commented on PR #5792: URL: https://github.com/apache/hbase/pull/5792#issuecomment-2034620063 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docke

Re: [PR] HBASE-28482 Reverse scan with tags throws ArrayIndexOutOfBoundsException with DBE in setCurrentBlock flow [hbase]

2024-04-03 Thread via GitHub
Apache-HBase commented on PR #5792: URL: https://github.com/apache/hbase/pull/5792#issuecomment-2034623937 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker

Re: [PR] [ADDENDUM] HBASE-28458 BucketCache.notifyFileCachingCompleted may incorrectly consider a file fully cached (#5777) [hbase]

2024-04-03 Thread via GitHub
Apache-HBase commented on PR #5791: URL: https://github.com/apache/hbase/pull/5791#issuecomment-2034941619 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docke

Re: [PR] [ADDENDUM] HBASE-28458 BucketCache.notifyFileCachingCompleted may incorrectly consider a file fully cached (#5777) [hbase]

2024-04-03 Thread via GitHub
Apache-HBase commented on PR #5791: URL: https://github.com/apache/hbase/pull/5791#issuecomment-2035360028 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docke

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-04-03 Thread via GitHub
Apache-HBase commented on PR #5774: URL: https://github.com/apache/hbase/pull/5774#issuecomment-2035363772 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 48s | Docke

Re: [PR] [ADDENDUM] HBASE-28458 BucketCache.notifyFileCachingCompleted may incorrectly consider a file fully cached (#5777) [hbase]

2024-04-03 Thread via GitHub
Apache-HBase commented on PR #5791: URL: https://github.com/apache/hbase/pull/5791#issuecomment-2035398607 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 14s | Docke

Re: [PR] [ADDENDUM] HBASE-28458 BucketCache.notifyFileCachingCompleted may incorrectly consider a file fully cached (#5777) [hbase]

2024-04-03 Thread via GitHub
Apache-HBase commented on PR #5791: URL: https://github.com/apache/hbase/pull/5791#issuecomment-2035411025 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docke

Re: [PR] HBASE-28448 CompressionTest hangs when run over a Ozone ofs path [hbase]

2024-04-03 Thread via GitHub
Apache-HBase commented on PR #5771: URL: https://github.com/apache/hbase/pull/5771#issuecomment-2035634263 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docke

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-04-03 Thread via GitHub
Apache-HBase commented on PR #5774: URL: https://github.com/apache/hbase/pull/5774#issuecomment-2035703665 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-04-03 Thread via GitHub
Apache-HBase commented on PR #5774: URL: https://github.com/apache/hbase/pull/5774#issuecomment-2035730841 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docker

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-04-03 Thread via GitHub
Apache-HBase commented on PR #5774: URL: https://github.com/apache/hbase/pull/5774#issuecomment-2035740710 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docke

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-04-03 Thread via GitHub
virajjasani commented on PR #5774: URL: https://github.com/apache/hbase/pull/5774#issuecomment-2035807493 @apurtell @bbeaudreault are you good with the latest revision of this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-04-03 Thread via GitHub
bbeaudreault commented on PR #5774: URL: https://github.com/apache/hbase/pull/5774#issuecomment-2035831593 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] HBASE-28448 CompressionTest hangs when run over a Ozone ofs path [hbase]

2024-04-03 Thread via GitHub
Apache-HBase commented on PR #5771: URL: https://github.com/apache/hbase/pull/5771#issuecomment-2035894436 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 14s | Docke

Re: [PR] HBASE-28448 CompressionTest hangs when run over a Ozone ofs path [hbase]

2024-04-03 Thread via GitHub
Apache-HBase commented on PR #5771: URL: https://github.com/apache/hbase/pull/5771#issuecomment-2035897526 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docke

Re: [PR] HBASE-28448 CompressionTest hangs when run over a Ozone ofs path [hbase]

2024-04-03 Thread via GitHub
Apache-HBase commented on PR #5771: URL: https://github.com/apache/hbase/pull/5771#issuecomment-2035908592 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker

Re: [PR] HBASE-28482 Reverse scan with tags throws ArrayIndexOutOfBoundsException with DBE in setCurrentBlock flow [hbase]

2024-04-03 Thread via GitHub
Apache-HBase commented on PR #5792: URL: https://github.com/apache/hbase/pull/5792#issuecomment-2036173207 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docke

Re: [PR] HBASE-28482 Reverse scan with tags throws ArrayIndexOutOfBoundsException with DBE in setCurrentBlock flow [hbase]

2024-04-04 Thread via GitHub
Apache-HBase commented on PR #5792: URL: https://github.com/apache/hbase/pull/5792#issuecomment-2036449523 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docke

Re: [PR] HBASE-28482 Reverse scan with tags throws ArrayIndexOutOfBoundsException with DBE in setCurrentBlock flow [hbase]

2024-04-04 Thread via GitHub
Apache-HBase commented on PR #5792: URL: https://github.com/apache/hbase/pull/5792#issuecomment-2036499577 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker

Re: [PR] HBASE-28482 Reverse scan with tags throws ArrayIndexOutOfBoundsException with DBE in setCurrentBlock flow [hbase]

2024-04-04 Thread via GitHub
Apache-HBase commented on PR #5792: URL: https://github.com/apache/hbase/pull/5792#issuecomment-2036507833 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docke

Re: [PR] HBASE-28292 Make Delay prefetch property to be dynamically configured [hbase]

2024-04-04 Thread via GitHub
wchevreuil commented on code in PR #5605: URL: https://github.com/apache/hbase/pull/5605#discussion_r1551312368 ## hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestPrefetch.java: ## @@ -336,6 +337,62 @@ public void testPrefetchDoesntSkipRefs() throws Exception {

Re: [PR] HBASE-28292 Make Delay prefetch property to be dynamically configured [hbase]

2024-04-04 Thread via GitHub
wchevreuil commented on code in PR #5605: URL: https://github.com/apache/hbase/pull/5605#discussion_r1551344684 ## hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestPrefetch.java: ## @@ -336,6 +337,62 @@ public void testPrefetchDoesntSkipRefs() throws Exception {

Re: [PR] HBASE-28292 Make Delay prefetch property to be dynamically configured [hbase]

2024-04-04 Thread via GitHub
kabhishek4 commented on code in PR #5605: URL: https://github.com/apache/hbase/pull/5605#discussion_r1551378020 ## hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestPrefetch.java: ## @@ -336,6 +337,62 @@ public void testPrefetchDoesntSkipRefs() throws Exception {

Re: [PR] HBASE-28292 Make Delay prefetch property to be dynamically configured [hbase]

2024-04-04 Thread via GitHub
kabhishek4 commented on code in PR #5605: URL: https://github.com/apache/hbase/pull/5605#discussion_r1551380210 ## hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestPrefetch.java: ## @@ -336,6 +337,62 @@ public void testPrefetchDoesntSkipRefs() throws Exception {

Re: [PR] HBASE-28482 Reverse scan with tags throws ArrayIndexOutOfBoundsException with DBE in setCurrentBlock flow [hbase]

2024-04-04 Thread via GitHub
vineet4008 commented on PR #5792: URL: https://github.com/apache/hbase/pull/5792#issuecomment-2036922036 TestPrefetchPersistence#testPrefetchPersistence test has no relevance with the current PR change. It is failing without this PR change also. -- This is an automated message from

[PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

2024-04-04 Thread via GitHub
vinayakphegde opened a new pull request, #5793: URL: https://github.com/apache/hbase/pull/5793 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

2024-04-04 Thread via GitHub
Apache-HBase commented on PR #5793: URL: https://github.com/apache/hbase/pull/5793#issuecomment-2037183945 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

2024-04-04 Thread via GitHub
wchevreuil commented on code in PR #5793: URL: https://github.com/apache/hbase/pull/5793#discussion_r1551838394 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DataTieringManager.java: ## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

2024-04-04 Thread via GitHub
vinayakphegde commented on PR #5793: URL: https://github.com/apache/hbase/pull/5793#issuecomment-2037647435 > Overall, looks good, I just think we need to add javadoc on public methods and explain properly when we will consider a file/block as cold/hot, specially when dealing with default t

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

2024-04-04 Thread via GitHub
vinayakphegde commented on code in PR #5793: URL: https://github.com/apache/hbase/pull/5793#discussion_r1552047719 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DataTieringManager.java: ## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

2024-04-04 Thread via GitHub
vinayakphegde commented on code in PR #5793: URL: https://github.com/apache/hbase/pull/5793#discussion_r1552050096 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DataTieringManager.java: ## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

2024-04-04 Thread via GitHub
vinayakphegde commented on code in PR #5793: URL: https://github.com/apache/hbase/pull/5793#discussion_r1552053165 ## hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDataTieringManager.java: ## @@ -0,0 +1,378 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

2024-04-04 Thread via GitHub
vinayakphegde commented on code in PR #5793: URL: https://github.com/apache/hbase/pull/5793#discussion_r1552061992 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DataTieringManager.java: ## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

2024-04-04 Thread via GitHub
Apache-HBase commented on PR #5793: URL: https://github.com/apache/hbase/pull/5793#issuecomment-2037736939 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docke

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

2024-04-04 Thread via GitHub
Apache-HBase commented on PR #5793: URL: https://github.com/apache/hbase/pull/5793#issuecomment-2037800563 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker

Re: [PR] HBASE-28183 It's impossible to re-enable the quota table if it gets d… [hbase]

2024-04-04 Thread via GitHub
chandrasekhar-188k commented on code in PR #5691: URL: https://github.com/apache/hbase/pull/5691#discussion_r1552671014 ## hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestQuotaAdmin.java: ## @@ -994,4 +994,16 @@ public int getQuotaSettingCount(Admin admin) throws

Re: [PR] HBASE-28183 It's impossible to re-enable the quota table if it gets d… [hbase]

2024-04-04 Thread via GitHub
chandrasekhar-188k commented on code in PR #5691: URL: https://github.com/apache/hbase/pull/5691#discussion_r1552671215 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java: ## @@ -2726,16 +2726,20 @@ protected void run() throws IOException { Mast

Re: [PR] HBASE-28183 It's impossible to re-enable the quota table if it gets d… [hbase]

2024-04-04 Thread via GitHub
chandrasekhar-188k commented on PR #5691: URL: https://github.com/apache/hbase/pull/5691#issuecomment-2038622733 > @chandrasekhar-188k Any update? review comments fixed , please check again -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] HBASE-28183 It's impossible to re-enable the quota table if it gets d… [hbase]

2024-04-04 Thread via GitHub
Apache-HBase commented on PR #5691: URL: https://github.com/apache/hbase/pull/5691#issuecomment-2038691759 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 50s | Docke

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-04-04 Thread via GitHub
virajjasani merged PR #5774: URL: https://github.com/apache/hbase/pull/5774 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apa

Re: [PR] HBASE-28183 It's impossible to re-enable the quota table if it gets d… [hbase]

2024-04-04 Thread via GitHub
Apache-HBase commented on PR #5691: URL: https://github.com/apache/hbase/pull/5691#issuecomment-2039009119 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docke

Re: [PR] HBASE-28486 fix CVE-2024-29025 in netty package [hbase]

2024-04-04 Thread via GitHub
Apache-HBase commented on PR #5794: URL: https://github.com/apache/hbase/pull/5794#issuecomment-2039013665 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docke

Re: [PR] HBASE-28183 It's impossible to re-enable the quota table if it gets d… [hbase]

2024-04-04 Thread via GitHub
Apache-HBase commented on PR #5691: URL: https://github.com/apache/hbase/pull/5691#issuecomment-2039020299 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docke

Re: [PR] HBASE-28183 It's impossible to re-enable the quota table if it gets d… [hbase]

2024-04-05 Thread via GitHub
Apache-HBase commented on PR #5691: URL: https://github.com/apache/hbase/pull/5691#issuecomment-2039094278 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 57s | Docker

Re: [PR] HBASE-27986 Adding debug message and assertion for failed BlockCache creation [hbase]

2024-04-05 Thread via GitHub
teamconfx commented on PR #5779: URL: https://github.com/apache/hbase/pull/5779#issuecomment-2039156055 I have changed the name of the PR and the Issue accordingly. Thanks for the response! -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

2024-04-05 Thread via GitHub
wchevreuil commented on code in PR #5793: URL: https://github.com/apache/hbase/pull/5793#discussion_r1553235776 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DataTieringManager.java: ## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

2024-04-05 Thread via GitHub
wchevreuil commented on code in PR #5793: URL: https://github.com/apache/hbase/pull/5793#discussion_r1553235776 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DataTieringManager.java: ## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

2024-04-05 Thread via GitHub
wchevreuil commented on code in PR #5793: URL: https://github.com/apache/hbase/pull/5793#discussion_r1553240987 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DataTieringManager.java: ## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] HBASE-28483 backup merge fails on bulkloaded hfiles [hbase]

2024-04-05 Thread via GitHub
Apache-HBase commented on PR #5795: URL: https://github.com/apache/hbase/pull/5795#issuecomment-2039328476 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

2024-04-05 Thread via GitHub
vinayakphegde commented on code in PR #5793: URL: https://github.com/apache/hbase/pull/5793#discussion_r1553288683 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DataTieringManager.java: ## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] HBASE-28483 backup merge fails on bulkloaded hfiles [hbase]

2024-04-05 Thread via GitHub
Apache-HBase commented on PR #5795: URL: https://github.com/apache/hbase/pull/5795#issuecomment-2039369922 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docke

Re: [PR] HBASE-28483 backup merge fails on bulkloaded hfiles [hbase]

2024-04-05 Thread via GitHub
Apache-HBase commented on PR #5795: URL: https://github.com/apache/hbase/pull/5795#issuecomment-2039371921 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docke

Re: [PR] HBASE-28483 backup merge fails on bulkloaded hfiles [hbase]

2024-04-05 Thread via GitHub
Apache-HBase commented on PR #5795: URL: https://github.com/apache/hbase/pull/5795#issuecomment-2039376139 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 46s | Docke

Re: [PR] [ADDENDUM] HBASE-28458 BucketCache.notifyFileCachingCompleted may incorrectly consider a file fully cached (#5777) [hbase]

2024-04-05 Thread via GitHub
wchevreuil merged PR #5791: URL: https://github.com/apache/hbase/pull/5791 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apac

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

2024-04-05 Thread via GitHub
vinayakphegde commented on code in PR #5793: URL: https://github.com/apache/hbase/pull/5793#discussion_r1553318202 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DataTieringManager.java: ## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] HBASE-28486 fix CVE-2024-29025 in netty package [hbase]

2024-04-05 Thread via GitHub
Apache-HBase commented on PR #5794: URL: https://github.com/apache/hbase/pull/5794#issuecomment-2039410442 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 13s | Docker

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

2024-04-05 Thread via GitHub
vinayakphegde commented on code in PR #5793: URL: https://github.com/apache/hbase/pull/5793#discussion_r1553348860 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DataTieringManager.java: ## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] HBASE-28486 fix CVE-2024-29025 in netty package [hbase]

2024-04-05 Thread via GitHub
Apache-HBase commented on PR #5794: URL: https://github.com/apache/hbase/pull/5794#issuecomment-2039547667 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docke

Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-04-05 Thread via GitHub
Apache-HBase commented on PR #5307: URL: https://github.com/apache/hbase/pull/5307#issuecomment-2039577198 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docke

Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-04-05 Thread via GitHub
Apache-HBase commented on PR #5307: URL: https://github.com/apache/hbase/pull/5307#issuecomment-2039584697 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 16s | Docke

Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-04-05 Thread via GitHub
Apache-HBase commented on PR #5307: URL: https://github.com/apache/hbase/pull/5307#issuecomment-2039586613 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docke

Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-04-05 Thread via GitHub
Apache-HBase commented on PR #5307: URL: https://github.com/apache/hbase/pull/5307#issuecomment-2039588020 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docke

Re: [PR] HBASE-28486 fix CVE-2024-29025 in netty package [hbase]

2024-04-05 Thread via GitHub
Apache9 commented on PR #5794: URL: https://github.com/apache/hbase/pull/5794#issuecomment-2039644392 Actually this fix is not enough. This is just for netty dependency introduced transitively by other dependencies, in hbase we use the relocated netty in hbase-thirdparty. We need to

Re: [PR] HBASE-28486 fix CVE-2024-29025 in netty package [hbase]

2024-04-05 Thread via GitHub
Apache-HBase commented on PR #5794: URL: https://github.com/apache/hbase/pull/5794#issuecomment-2039707363 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 47s | Docker

Re: [PR] HBASE-28483 backup merge fails on bulkloaded hfiles [hbase]

2024-04-05 Thread via GitHub
bbeaudreault commented on PR #5795: URL: https://github.com/apache/hbase/pull/5795#issuecomment-2039713845 Also please run `mvn spotless:apply -pl hbase-backups` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] HBASE-28483 backup merge fails on bulkloaded hfiles [hbase]

2024-04-05 Thread via GitHub
bbeaudreault commented on code in PR #5795: URL: https://github.com/apache/hbase/pull/5795#discussion_r1553565029 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileInputFormat.java: ## @@ -155,16 +154,23 @@ protected List listStatus(JobContext job) throws

Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-04-05 Thread via GitHub
Apache-HBase commented on PR #5307: URL: https://github.com/apache/hbase/pull/5307#issuecomment-2039723307 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docke

<    1   2   3   4   5   6   7   8   9   10   >