Re: [PR] HBASE-28405 - Fix failed procedure rollback when region was not close… [hbase]

2024-04-07 Thread via GitHub
virajjasani commented on PR #5799: URL: https://github.com/apache/hbase/pull/5799#issuecomment-2041555045 > I think i made a mistake. A small but important one which breaks/"doesn't follow" the design of rollback in procedure framework. We didnot change regionNode state in `MERGE_TABLE_REGI

Re: [PR] HBASE-28405 - Fix failed procedure rollback when region was not close… [hbase]

2024-04-07 Thread via GitHub
Apache-HBase commented on PR #5799: URL: https://github.com/apache/hbase/pull/5799#issuecomment-2041625975 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docke

Re: [PR] HBASE-28405 - Fix failed procedure rollback when region was not close… [hbase]

2024-04-07 Thread via GitHub
Apache-HBase commented on PR #5799: URL: https://github.com/apache/hbase/pull/5799#issuecomment-2041628940 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker

Re: [PR] HBASE-28405 - Fix failed procedure rollback when region was not close… [hbase]

2024-04-07 Thread via GitHub
Apache-HBase commented on PR #5799: URL: https://github.com/apache/hbase/pull/5799#issuecomment-2041634955 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docke

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

2024-04-08 Thread via GitHub
wchevreuil commented on PR #5793: URL: https://github.com/apache/hbase/pull/5793#issuecomment-2042252076 LTGM, can we just address latest spotless failure? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

2024-04-08 Thread via GitHub
vinayakphegde commented on PR #5793: URL: https://github.com/apache/hbase/pull/5793#issuecomment-2042266090 > LTGM, can we just address latest spotless failure? That's because of the Javadoc in the `TestDataTieringManager` class, where I included the structure of the `TestDataTieringM

Re: [PR] HBASE-28292 Make Delay prefetch property to be dynamically configured [hbase]

2024-04-08 Thread via GitHub
wchevreuil commented on code in PR #5605: URL: https://github.com/apache/hbase/pull/5605#discussion_r167693 ## hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestPrefetch.java: ## @@ -336,6 +337,62 @@ public void testPrefetchDoesntSkipRefs() throws Exception {

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

2024-04-08 Thread via GitHub
Apache-HBase commented on PR #5793: URL: https://github.com/apache/hbase/pull/5793#issuecomment-2042385473 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docke

Re: [PR] HBASE-28292 Make Delay prefetch property to be dynamically configured [hbase]

2024-04-08 Thread via GitHub
ragarkar commented on code in PR #5605: URL: https://github.com/apache/hbase/pull/5605#discussion_r1555615766 ## hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestPrefetch.java: ## @@ -336,6 +337,62 @@ public void testPrefetchDoesntSkipRefs() throws Exception {

Re: [PR] HBASE-28292 Make Delay prefetch property to be dynamically configured [hbase]

2024-04-08 Thread via GitHub
kabhishek4 commented on code in PR #5605: URL: https://github.com/apache/hbase/pull/5605#discussion_r1555616907 ## hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestPrefetch.java: ## @@ -336,6 +337,62 @@ public void testPrefetchDoesntSkipRefs() throws Exception {

Re: [PR] HBASE-28292 Make Delay prefetch property to be dynamically configured [hbase]

2024-04-08 Thread via GitHub
kabhishek4 commented on code in PR #5605: URL: https://github.com/apache/hbase/pull/5605#discussion_r1555616907 ## hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestPrefetch.java: ## @@ -336,6 +337,62 @@ public void testPrefetchDoesntSkipRefs() throws Exception {

Re: [PR] HBASE-28292 Make Delay prefetch property to be dynamically configured [hbase]

2024-04-08 Thread via GitHub
ragarkar commented on code in PR #5605: URL: https://github.com/apache/hbase/pull/5605#discussion_r1555623367 ## hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestPrefetch.java: ## @@ -336,6 +337,62 @@ public void testPrefetchDoesntSkipRefs() throws Exception {

Re: [PR] HBASE-28292 Make Delay prefetch property to be dynamically configured [hbase]

2024-04-08 Thread via GitHub
kabhishek4 commented on code in PR #5605: URL: https://github.com/apache/hbase/pull/5605#discussion_r1555630761 ## hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestPrefetch.java: ## @@ -336,6 +337,62 @@ public void testPrefetchDoesntSkipRefs() throws Exception {

Re: [PR] HBASE-28405 - Fix failed procedure rollback when region was not close… [hbase]

2024-04-08 Thread via GitHub
Apache-HBase commented on PR #5799: URL: https://github.com/apache/hbase/pull/5799#issuecomment-2042635972 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docke

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

2024-04-08 Thread via GitHub
jhungund commented on code in PR #5793: URL: https://github.com/apache/hbase/pull/5793#discussion_r1555814598 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DataTieringManager.java: ## @@ -0,0 +1,222 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] HBASE-28292 Make Delay prefetch property to be dynamically configured [hbase]

2024-04-08 Thread via GitHub
Apache-HBase commented on PR #5605: URL: https://github.com/apache/hbase/pull/5605#issuecomment-2042745968 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s | Docker

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

2024-04-08 Thread via GitHub
vinayakphegde commented on code in PR #5793: URL: https://github.com/apache/hbase/pull/5793#discussion_r1555847930 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DataTieringManager.java: ## @@ -0,0 +1,222 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

2024-04-08 Thread via GitHub
jhungund commented on code in PR #5793: URL: https://github.com/apache/hbase/pull/5793#discussion_r1555856302 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DataTieringManager.java: ## @@ -0,0 +1,222 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

2024-04-08 Thread via GitHub
Apache-HBase commented on PR #5793: URL: https://github.com/apache/hbase/pull/5793#issuecomment-2042894870 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 56s | Docke

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

2024-04-08 Thread via GitHub
Apache-HBase commented on PR #5793: URL: https://github.com/apache/hbase/pull/5793#issuecomment-2042968954 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

2024-04-08 Thread via GitHub
vinayakphegde commented on PR #5793: URL: https://github.com/apache/hbase/pull/5793#issuecomment-2043004482 @wchevreuil, it seems like most of the tests have passed, and any failures were due to flaky tests. -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

2024-04-08 Thread via GitHub
wchevreuil merged PR #5793: URL: https://github.com/apache/hbase/pull/5793 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apac

Re: [PR] HBASE-28485: Re-use ZstdDecompressCtx/ZstdCompressCtx for performance [hbase]

2024-04-08 Thread via GitHub
apurtell commented on code in PR #5797: URL: https://github.com/apache/hbase/pull/5797#discussion_r1556053315 ## hbase-compression/hbase-compression-zstd/src/main/java/org/apache/hadoop/hbase/io/compress/zstd/ZstdCompressor.java: ## @@ -170,6 +170,13 @@ public void reset() {

Re: [PR] HBASE-28485: Re-use ZstdDecompressCtx/ZstdCompressCtx for performance [hbase]

2024-04-08 Thread via GitHub
apurtell commented on PR #5797: URL: https://github.com/apache/hbase/pull/5797#issuecomment-2043090038 A note for any other reviewers. The difference between failed precommit runs and successful ones is [d6843d3](https://github.com/apache/hbase/pull/5797/commits/d6843d3958aa6f8b1b03024e29f1

Re: [PR] HBASE-28405 - Fix failed procedure rollback when region was not close… [hbase]

2024-04-08 Thread via GitHub
Apache-HBase commented on PR #5799: URL: https://github.com/apache/hbase/pull/5799#issuecomment-2043161214 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docker

Re: [PR] HBASE-28405 - Fix failed procedure rollback when region was not close… [hbase]

2024-04-08 Thread via GitHub
Apache-HBase commented on PR #5799: URL: https://github.com/apache/hbase/pull/5799#issuecomment-2043165670 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docker

Re: [PR] HBASE-28292 Make Delay prefetch property to be dynamically configured [hbase]

2024-04-08 Thread via GitHub
Apache-HBase commented on PR #5605: URL: https://github.com/apache/hbase/pull/5605#issuecomment-2043190919 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docke

Re: [PR] HBASE-28405 - Fix failed procedure rollback when region was not close… [hbase]

2024-04-08 Thread via GitHub
Apache-HBase commented on PR #5799: URL: https://github.com/apache/hbase/pull/5799#issuecomment-2043228894 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker

Re: [PR] HBASE-28292 Make Delay prefetch property to be dynamically configured [hbase]

2024-04-08 Thread via GitHub
Apache-HBase commented on PR #5605: URL: https://github.com/apache/hbase/pull/5605#issuecomment-2043233488 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docke

Re: [PR] HBASE-28292 Make Delay prefetch property to be dynamically configured [hbase]

2024-04-08 Thread via GitHub
Apache-HBase commented on PR #5605: URL: https://github.com/apache/hbase/pull/5605#issuecomment-2043319729 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 15s | Docke

Re: [PR] HBASE-28485: Re-use ZstdDecompressCtx/ZstdCompressCtx for performance [hbase]

2024-04-08 Thread via GitHub
Apache-HBase commented on PR #5797: URL: https://github.com/apache/hbase/pull/5797#issuecomment-2043320252 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docke

Re: [PR] HBASE-28485: Re-use ZstdDecompressCtx/ZstdCompressCtx for performance [hbase]

2024-04-08 Thread via GitHub
Apache-HBase commented on PR #5797: URL: https://github.com/apache/hbase/pull/5797#issuecomment-2043320760 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 0s | Docke

Re: [PR] HBASE-28485: Re-use ZstdDecompressCtx/ZstdCompressCtx for performance [hbase]

2024-04-08 Thread via GitHub
Apache-HBase commented on PR #5797: URL: https://github.com/apache/hbase/pull/5797#issuecomment-2043323670 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s | Docke

Re: [PR] HBASE-28485: Re-use ZstdDecompressCtx/ZstdCompressCtx for performance [hbase]

2024-04-08 Thread via GitHub
Apache-HBase commented on PR #5797: URL: https://github.com/apache/hbase/pull/5797#issuecomment-2043324987 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docke

Re: [PR] HBASE-26192 Master UI hbck should provide a JSON formatted output option [hbase]

2024-04-08 Thread via GitHub
apurtell commented on PR #5772: URL: https://github.com/apache/hbase/pull/5772#issuecomment-2043644217 No further comments, going to merge. Thank you @mihir6692 for the contribution -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] HBASE-26192 Master UI hbck should provide a JSON formatted output option [hbase]

2024-04-08 Thread via GitHub
apurtell commented on PR #5780: URL: https://github.com/apache/hbase/pull/5780#issuecomment-2043644026 No further comments, going to merge. Thank you @mihir6692 for the contribution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] HBASE-26192 Master UI hbck should provide a JSON formatted output option [hbase]

2024-04-08 Thread via GitHub
apurtell merged PR #5772: URL: https://github.com/apache/hbase/pull/5772 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache

Re: [PR] HBASE-26192 Master UI hbck should provide a JSON formatted output option [hbase]

2024-04-08 Thread via GitHub
apurtell merged PR #5780: URL: https://github.com/apache/hbase/pull/5780 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache

Re: [PR] HBASE-28493 [hbase-thirdparty] Bump protobuf version [hbase-thirdparty]

2024-04-08 Thread via GitHub
Apache-HBase commented on PR #117: URL: https://github.com/apache/hbase-thirdparty/pull/117#issuecomment-2044132631 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 45s

Re: [PR] HBASE-28405 - Fix failed procedure rollback when region was not close… [hbase]

2024-04-08 Thread via GitHub
mnpoonia commented on PR #5799: URL: https://github.com/apache/hbase/pull/5799#issuecomment-2044165443 > The latest fix LGTM. > > Could we add a UT for this case? Trying to write a test. Little tricky as i haven't looked at ProcedureTestingUtility as of now. Will see what i can

Re: [PR] HBASE-28298 Fix HFilePrettyPrinter thrown NoSuchMethodError about Met… [hbase]

2024-04-08 Thread via GitHub
Apache9 commented on PR #5783: URL: https://github.com/apache/hbase/pull/5783#issuecomment-2044248091 Mind putting up the `mvn dependency:tree` result before and after the PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

2024-04-09 Thread via GitHub
stoty opened a new pull request, #5802: URL: https://github.com/apache/hbase/pull/5802 …vent scanner leakage -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

2024-04-09 Thread via GitHub
stoty commented on PR #5802: URL: https://github.com/apache/hbase/pull/5802#issuecomment-2044329576 Using Caffeine instead of Guava Cache, as recommended by Guava. Caffeine is already a dependency. -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

2024-04-09 Thread via GitHub
Apache-HBase commented on PR #5802: URL: https://github.com/apache/hbase/pull/5802#issuecomment-2044377748 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s | Docker

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

2024-04-09 Thread via GitHub
Apache-HBase commented on PR #5802: URL: https://github.com/apache/hbase/pull/5802#issuecomment-2044378785 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docke

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

2024-04-09 Thread via GitHub
Apache-HBase commented on PR #5802: URL: https://github.com/apache/hbase/pull/5802#issuecomment-2044379683 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docke

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

2024-04-09 Thread via GitHub
Apache-HBase commented on PR #5802: URL: https://github.com/apache/hbase/pull/5802#issuecomment-2044380918 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docke

Re: [PR] HBASE-28485: Re-use ZstdDecompressCtx/ZstdCompressCtx for performance [hbase]

2024-04-09 Thread via GitHub
ndimiduk merged PR #5797: URL: https://github.com/apache/hbase/pull/5797 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache

Re: [PR] HBASE-28436 Use connection url to specify the connection registry inf… [hbase]

2024-04-09 Thread via GitHub
Apache9 commented on PR #5770: URL: https://github.com/apache/hbase/pull/5770#issuecomment-2044439200 If no other feedbacks, I will move forward to update the PR to address the review comments. The basic direction is still the same as beginning, we use `hbase+zk` and `hbase+rpc` as s

Re: [PR] HBASE-28292 Make Delay prefetch property to be dynamically configured [hbase]

2024-04-09 Thread via GitHub
Apache-HBase commented on PR #5605: URL: https://github.com/apache/hbase/pull/5605#issuecomment-208351 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docke

[PR] Backport "HBASE-28485 Re-use ZstdDecompressCtx/ZstdCompressCtx for performance (#5797)" to branch-3 [hbase]

2024-04-09 Thread via GitHub
ndimiduk opened a new pull request, #5803: URL: https://github.com/apache/hbase/pull/5803 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[PR] HBASE-28500 Rest Java client library assumes stateless servers [hbase]

2024-04-09 Thread via GitHub
stoty opened a new pull request, #5804: URL: https://github.com/apache/hbase/pull/5804 add a sticky flag which forces using the same server for all requests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[PR] Backport "HBASE-28485 Re-use ZstdDecompressCtx/ZstdCompressCtx for performance (#5797)" to branch-2 [hbase]

2024-04-09 Thread via GitHub
ndimiduk opened a new pull request, #5805: URL: https://github.com/apache/hbase/pull/5805 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

Re: [PR] HBASE-28455 do-release-docker fails to setup gpg agent proxy if proxy container is slow to start [hbase]

2024-04-09 Thread via GitHub
ndimiduk commented on code in PR #5781: URL: https://github.com/apache/hbase/pull/5781#discussion_r1557277610 ## dev-support/create-release/do-release-docker.sh: ## @@ -300,9 +300,22 @@ if [ "${HOST_OS}" == "DARWIN" ]; then "type=bind,src=${HOME}/.ssh/id_rsa.pub,dst=/home

Re: [PR] HBASE-28455 do-release-docker fails to setup gpg agent proxy if proxy container is slow to start [hbase]

2024-04-09 Thread via GitHub
ndimiduk commented on PR #5781: URL: https://github.com/apache/hbase/pull/5781#issuecomment-2044515931 FYI @busbey -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[PR] Backport "HBASE-28485 Re-use ZstdDecompressCtx/ZstdCompressCtx for performance (#5797)" to branch-2.6 [hbase]

2024-04-09 Thread via GitHub
ndimiduk opened a new pull request, #5806: URL: https://github.com/apache/hbase/pull/5806 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

Re: [PR] HBASE-28495 [hbase-thirdparty] Fix pre commit build [hbase-thirdparty]

2024-04-09 Thread via GitHub
ndimiduk commented on PR #116: URL: https://github.com/apache/hbase-thirdparty/pull/116#issuecomment-2044524155 Thanks @Apache9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] HBASE-28492 [hbase-thirdparty] Bump dependency versions before releasing [hbase-thirdparty]

2024-04-09 Thread via GitHub
ndimiduk commented on PR #115: URL: https://github.com/apache/hbase-thirdparty/pull/115#issuecomment-2044527983 FYI @bbeaudreault -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[PR] Backport "HBASE-28485 Re-use ZstdDecompressCtx/ZstdCompressCtx for performance (#5797)" to branch-2.5 [hbase]

2024-04-09 Thread via GitHub
ndimiduk opened a new pull request, #5807: URL: https://github.com/apache/hbase/pull/5807 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

Re: [PR] Backport "HBASE-28485 Re-use ZstdDecompressCtx/ZstdCompressCtx for performance (#5797)" to branch-2 [hbase]

2024-04-09 Thread via GitHub
Apache-HBase commented on PR #5805: URL: https://github.com/apache/hbase/pull/5805#issuecomment-2044556876 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 45s | Docke

Re: [PR] Backport "HBASE-28485 Re-use ZstdDecompressCtx/ZstdCompressCtx for performance (#5797)" to branch-3 [hbase]

2024-04-09 Thread via GitHub
Apache-HBase commented on PR #5803: URL: https://github.com/apache/hbase/pull/5803#issuecomment-2044557565 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docke

Re: [PR] Backport "HBASE-28485 Re-use ZstdDecompressCtx/ZstdCompressCtx for performance (#5797)" to branch-3 [hbase]

2024-04-09 Thread via GitHub
Apache-HBase commented on PR #5803: URL: https://github.com/apache/hbase/pull/5803#issuecomment-2044562437 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s | Docke

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

2024-04-09 Thread via GitHub
Apache-HBase commented on PR #5802: URL: https://github.com/apache/hbase/pull/5802#issuecomment-2044562602 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 51s | Docke

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

2024-04-09 Thread via GitHub
Apache-HBase commented on PR #5802: URL: https://github.com/apache/hbase/pull/5802#issuecomment-2044563034 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker

Re: [PR] HBASE-28500 Rest Java client library assumes stateless servers [hbase]

2024-04-09 Thread via GitHub
Apache-HBase commented on PR #5804: URL: https://github.com/apache/hbase/pull/5804#issuecomment-2044563797 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docke

Re: [PR] Backport "HBASE-28485 Re-use ZstdDecompressCtx/ZstdCompressCtx for performance (#5797)" to branch-2 [hbase]

2024-04-09 Thread via GitHub
Apache-HBase commented on PR #5805: URL: https://github.com/apache/hbase/pull/5805#issuecomment-2044561860 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 58s | Docke

Re: [PR] Backport "HBASE-28485 Re-use ZstdDecompressCtx/ZstdCompressCtx for performance (#5797)" to branch-3 [hbase]

2024-04-09 Thread via GitHub
Apache-HBase commented on PR #5803: URL: https://github.com/apache/hbase/pull/5803#issuecomment-2044564858 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 8s | Docke

Re: [PR] HBASE-28500 Rest Java client library assumes stateless servers [hbase]

2024-04-09 Thread via GitHub
Apache-HBase commented on PR #5804: URL: https://github.com/apache/hbase/pull/5804#issuecomment-2044562087 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s | Docke

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

2024-04-09 Thread via GitHub
Apache-HBase commented on PR #5802: URL: https://github.com/apache/hbase/pull/5802#issuecomment-2044565904 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 53s | Docke

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

2024-04-09 Thread via GitHub
Apache-HBase commented on PR #5802: URL: https://github.com/apache/hbase/pull/5802#issuecomment-2044567536 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s | Docke

Re: [PR] HBASE-28500 Rest Java client library assumes stateless servers [hbase]

2024-04-09 Thread via GitHub
Apache-HBase commented on PR #5804: URL: https://github.com/apache/hbase/pull/5804#issuecomment-2044568076 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 54s | Docke

Re: [PR] Backport "HBASE-28485 Re-use ZstdDecompressCtx/ZstdCompressCtx for performance (#5797)" to branch-3 [hbase]

2024-04-09 Thread via GitHub
Apache-HBase commented on PR #5803: URL: https://github.com/apache/hbase/pull/5803#issuecomment-2044569044 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 50s | Docke

Re: [PR] Backport "HBASE-28485 Re-use ZstdDecompressCtx/ZstdCompressCtx for performance (#5797)" to branch-2 [hbase]

2024-04-09 Thread via GitHub
Apache-HBase commented on PR #5805: URL: https://github.com/apache/hbase/pull/5805#issuecomment-2044569930 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 52s | Docke

Re: [PR] Backport "HBASE-28485 Re-use ZstdDecompressCtx/ZstdCompressCtx for performance (#5797)" to branch-3 [hbase]

2024-04-09 Thread via GitHub
ndimiduk merged PR #5803: URL: https://github.com/apache/hbase/pull/5803 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache

Re: [PR] HBASE-28500 Rest Java client library assumes stateless servers [hbase]

2024-04-09 Thread via GitHub
Apache-HBase commented on PR #5804: URL: https://github.com/apache/hbase/pull/5804#issuecomment-2044572165 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 15s | Docker

Re: [PR] Backport "HBASE-28485 Re-use ZstdDecompressCtx/ZstdCompressCtx for performance (#5797)" to branch-2 [hbase]

2024-04-09 Thread via GitHub
ndimiduk merged PR #5805: URL: https://github.com/apache/hbase/pull/5805 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache

Re: [PR] Backport "HBASE-28485 Re-use ZstdDecompressCtx/ZstdCompressCtx for performance (#5797)" to branch-2.6 [hbase]

2024-04-09 Thread via GitHub
Apache-HBase commented on PR #5806: URL: https://github.com/apache/hbase/pull/5806#issuecomment-2044603837 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s | Docker

Re: [PR] Backport "HBASE-28485 Re-use ZstdDecompressCtx/ZstdCompressCtx for performance (#5797)" to branch-2.6 [hbase]

2024-04-09 Thread via GitHub
Apache-HBase commented on PR #5806: URL: https://github.com/apache/hbase/pull/5806#issuecomment-2044606220 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docke

Re: [PR] Backport "HBASE-28485 Re-use ZstdDecompressCtx/ZstdCompressCtx for performance (#5797)" to branch-2.6 [hbase]

2024-04-09 Thread via GitHub
Apache-HBase commented on PR #5806: URL: https://github.com/apache/hbase/pull/5806#issuecomment-2044609273 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 45s | Docke

Re: [PR] Backport "HBASE-28485 Re-use ZstdDecompressCtx/ZstdCompressCtx for performance (#5797)" to branch-2.5 [hbase]

2024-04-09 Thread via GitHub
Apache-HBase commented on PR #5807: URL: https://github.com/apache/hbase/pull/5807#issuecomment-2044611293 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s | Docke

Re: [PR] Backport "HBASE-28485 Re-use ZstdDecompressCtx/ZstdCompressCtx for performance (#5797)" to branch-2.5 [hbase]

2024-04-09 Thread via GitHub
Apache-HBase commented on PR #5807: URL: https://github.com/apache/hbase/pull/5807#issuecomment-2044620101 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 51s | Docke

Re: [PR] HBASE-28500 Rest Java client library assumes stateless servers [hbase]

2024-04-09 Thread via GitHub
Apache-HBase commented on PR #5804: URL: https://github.com/apache/hbase/pull/5804#issuecomment-2044625790 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docke

Re: [PR] HBASE-28492 [hbase-thirdparty] Bump dependency versions before releasing [hbase-thirdparty]

2024-04-09 Thread via GitHub
Apache9 merged PR #115: URL: https://github.com/apache/hbase-thirdparty/pull/115 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbas

Re: [PR] HBASE-28500 Rest Java client library assumes stateless servers [hbase]

2024-04-09 Thread via GitHub
Apache-HBase commented on PR #5804: URL: https://github.com/apache/hbase/pull/5804#issuecomment-2044628934 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docke

Re: [PR] HBASE-28500 Rest Java client library assumes stateless servers [hbase]

2024-04-09 Thread via GitHub
Apache-HBase commented on PR #5804: URL: https://github.com/apache/hbase/pull/5804#issuecomment-2044629293 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docke

Re: [PR] Backport "HBASE-28485 Re-use ZstdDecompressCtx/ZstdCompressCtx for performance (#5797)" to branch-2.5 [hbase]

2024-04-09 Thread via GitHub
Apache-HBase commented on PR #5807: URL: https://github.com/apache/hbase/pull/5807#issuecomment-2044629826 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s | Docke

Re: [PR] HBASE-28493 [hbase-thirdparty] Bump protobuf version [hbase-thirdparty]

2024-04-09 Thread via GitHub
Apache9 commented on PR #117: URL: https://github.com/apache/hbase-thirdparty/pull/117#issuecomment-2044632390 > Is it time to re-engage with the protobuf team about accepting some version of these patches? I think first we need to check whether protobuf has already provided these ab

Re: [PR] HBASE-28500 Rest Java client library assumes stateless servers [hbase]

2024-04-09 Thread via GitHub
Apache-HBase commented on PR #5804: URL: https://github.com/apache/hbase/pull/5804#issuecomment-2044637900 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 16s | Docker

Re: [PR] HBASE-28500 Rest Java client library assumes stateless servers [hbase]

2024-04-09 Thread via GitHub
Apache-HBase commented on PR #5804: URL: https://github.com/apache/hbase/pull/5804#issuecomment-2044691941 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s | Docke

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

2024-04-09 Thread via GitHub
Apache-HBase commented on PR #5802: URL: https://github.com/apache/hbase/pull/5802#issuecomment-2044692826 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

2024-04-09 Thread via GitHub
Apache-HBase commented on PR #5802: URL: https://github.com/apache/hbase/pull/5802#issuecomment-2044693170 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 45s | Docke

Re: [PR] HBASE-28482 Reverse scan with tags throws ArrayIndexOutOfBoundsException with DBE in setCurrentBlock flow [hbase]

2024-04-09 Thread via GitHub
vineet4008 commented on PR #5792: URL: https://github.com/apache/hbase/pull/5792#issuecomment-2044697266 testFailAndRollback – org.apache.hadoop.hbase.master.assignment.TestRollbackSCP test – org.apache.hadoop.hbase.master.region.TestMasterRegionWALCleaner Both the failures have no rel

Re: [PR] HBASE-28500 Rest Java client library assumes stateless servers [hbase]

2024-04-09 Thread via GitHub
Apache-HBase commented on PR #5804: URL: https://github.com/apache/hbase/pull/5804#issuecomment-2044698426 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docke

Re: [PR] HBASE-28500 Rest Java client library assumes stateless servers [hbase]

2024-04-09 Thread via GitHub
Apache-HBase commented on PR #5804: URL: https://github.com/apache/hbase/pull/5804#issuecomment-2044700418 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s | Docke

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

2024-04-09 Thread via GitHub
Apache-HBase commented on PR #5802: URL: https://github.com/apache/hbase/pull/5802#issuecomment-2044701668 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s | Docke

Re: [PR] HBASE-28500 Rest Java client library assumes stateless servers [hbase]

2024-04-09 Thread via GitHub
Apache-HBase commented on PR #5804: URL: https://github.com/apache/hbase/pull/5804#issuecomment-2044708162 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 17s | Docker

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

2024-04-09 Thread via GitHub
Apache-HBase commented on PR #5802: URL: https://github.com/apache/hbase/pull/5802#issuecomment-2044698300 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docke

Re: [PR] Backport "HBASE-28485 Re-use ZstdDecompressCtx/ZstdCompressCtx for performance (#5797)" to branch-2.6 [hbase]

2024-04-09 Thread via GitHub
ndimiduk merged PR #5806: URL: https://github.com/apache/hbase/pull/5806 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache

Re: [PR] Backport "HBASE-28485 Re-use ZstdDecompressCtx/ZstdCompressCtx for performance (#5797)" to branch-2.5 [hbase]

2024-04-09 Thread via GitHub
ndimiduk merged PR #5807: URL: https://github.com/apache/hbase/pull/5807 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache

Re: [PR] Backport "HBASE-28485 Re-use ZstdDecompressCtx/ZstdCompressCtx for performance (#5797)" to branch-2.6 [hbase]

2024-04-09 Thread via GitHub
ndimiduk commented on PR #5806: URL: https://github.com/apache/hbase/pull/5806#issuecomment-2044791790 Spotless errors predate this patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

<    2   3   4   5   6   7   8   9   10   11   >