[PR] HBASE-28521 Use standard ConnectionRegistry and Client API to get reg… [hbase]

2024-04-14 Thread via GitHub
Apache9 opened a new pull request, #5825: URL: https://github.com/apache/hbase/pull/5825 …ion server list in in replication -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] HBASE-28517 Make properties dynamically configured [hbase]

2024-04-14 Thread via GitHub
Apache9 commented on PR #5823: URL: https://github.com/apache/hbase/pull/5823#issuecomment-2054080443 Just make CacheConfig implements ConfigurationObserver and register it in HStore.registerChildren? And if we want to change these flags dynamically, I think they should be marked as

Re: [PR] HBASE-28521 Use standard ConnectionRegistry and Client API to get reg… [hbase]

2024-04-14 Thread via GitHub
Apache-HBase commented on PR #5825: URL: https://github.com/apache/hbase/pull/5825#issuecomment-2054084021 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 37s | Docke

Re: [PR] HBASE-28511 Update hbase-thirdparty to 4.1.7 [hbase]

2024-04-14 Thread via GitHub
Apache-HBase commented on PR #5818: URL: https://github.com/apache/hbase/pull/5818#issuecomment-2054103336 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s | Docker

Re: [PR] HBASE-28511 Update hbase-thirdparty to 4.1.7 [hbase]

2024-04-14 Thread via GitHub
Apache-HBase commented on PR #5818: URL: https://github.com/apache/hbase/pull/5818#issuecomment-2054115569 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 8s | Docke

Re: [PR] HBASE-28511 Update hbase-thirdparty to 4.1.7 [hbase]

2024-04-14 Thread via GitHub
Apache-HBase commented on PR #5818: URL: https://github.com/apache/hbase/pull/5818#issuecomment-2054138371 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 58s | Docke

Re: [PR] HBASE-28521 Use standard ConnectionRegistry and Client API to get reg… [hbase]

2024-04-14 Thread via GitHub
Apache-HBase commented on PR #5825: URL: https://github.com/apache/hbase/pull/5825#issuecomment-2054148871 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docker

Re: [PR] HBASE-28521 Use standard ConnectionRegistry and Client API to get reg… [hbase]

2024-04-14 Thread via GitHub
Apache-HBase commented on PR #5825: URL: https://github.com/apache/hbase/pull/5825#issuecomment-2054149236 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 35s | Docker

Re: [PR] HBASE-28521 Use standard ConnectionRegistry and Client API to get reg… [hbase]

2024-04-14 Thread via GitHub
Apache-HBase commented on PR #5825: URL: https://github.com/apache/hbase/pull/5825#issuecomment-2054149973 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 2s | Docker

Re: [PR] HBASE-28509 ScanResumer.resume would perform unnecessary scan when cl… [hbase]

2024-04-14 Thread via GitHub
comnetwork commented on code in PR #5817: URL: https://github.com/apache/hbase/pull/5817#discussion_r1565142498 ## hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncTableResultScanner.java: ## @@ -143,6 +144,18 @@ private void resumePrefetch() { resumer = null;

Re: [PR] HBASE-28509 ScanResumer.resume would perform unnecessary scan when cl… [hbase]

2024-04-14 Thread via GitHub
comnetwork commented on code in PR #5817: URL: https://github.com/apache/hbase/pull/5817#discussion_r1565142703 ## hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncTableResultScanner.java: ## @@ -143,6 +144,18 @@ private void resumePrefetch() { resumer = null;

Re: [PR] HBASE-28509 ScanResumer.resume would perform unnecessary scan when cl… [hbase]

2024-04-14 Thread via GitHub
Apache-HBase commented on PR #5817: URL: https://github.com/apache/hbase/pull/5817#issuecomment-2054904881 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docke

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

2024-04-14 Thread via GitHub
Apache-HBase commented on PR #5802: URL: https://github.com/apache/hbase/pull/5802#issuecomment-2055225640 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docker

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

2024-04-14 Thread via GitHub
Apache-HBase commented on PR #5802: URL: https://github.com/apache/hbase/pull/5802#issuecomment-2055227136 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docke

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

2024-04-14 Thread via GitHub
Apache-HBase commented on PR #5802: URL: https://github.com/apache/hbase/pull/5802#issuecomment-2055233717 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docke

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

2024-04-14 Thread via GitHub
Apache-HBase commented on PR #5802: URL: https://github.com/apache/hbase/pull/5802#issuecomment-2055233034 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docke

[PR] HBASE-28468: Integration of time-based priority caching in eviction logic. [hbase]

2024-04-14 Thread via GitHub
jhungund opened a new pull request, #5826: URL: https://github.com/apache/hbase/pull/5826 HBASE-28468: Integration of time-based priority caching in eviction logic. The time-based priority caching relies on the presence of file paths in the block-cache key. However, in case of the

Re: [PR] Hbase 28468 option2 [hbase]

2024-04-14 Thread via GitHub
jhungund closed pull request #5828: Hbase 28468 option2 URL: https://github.com/apache/hbase/pull/5828 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: i

Re: [PR] Option 2: Data Tiering integration into cache evictions. [hbase]

2024-04-14 Thread via GitHub
jhungund closed pull request #5827: Option 2: Data Tiering integration into cache evictions. URL: https://github.com/apache/hbase/pull/5827 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Alternative solution for data Tiering integration into cache evictions. [hbase]

2024-04-15 Thread via GitHub
jhungund commented on code in PR #5829: URL: https://github.com/apache/hbase/pull/5829#discussion_r1565267535 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java: ## @@ -934,6 +936,27 @@ void freeSpace(final String why) { } try {

Re: [PR] HBASE-28405 - Fix failed procedure rollback when region was not close… [hbase]

2024-04-15 Thread via GitHub
mnpoonia commented on PR #5799: URL: https://github.com/apache/hbase/pull/5799#issuecomment-2055775609 Writing test here is little tricky. Not sure if it is possible to mimic the same failure. I tried all the available options in proceduretestingutility and don't see the right fit for our s

Re: [PR] HBASE-28509 ScanResumer.resume would perform unnecessary scan when cl… [hbase]

2024-04-15 Thread via GitHub
Apache-HBase commented on PR #5817: URL: https://github.com/apache/hbase/pull/5817#issuecomment-2055951263 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 0s | Docke

Re: [PR] HBASE-28509 ScanResumer.resume would perform unnecessary scan when cl… [hbase]

2024-04-15 Thread via GitHub
Apache-HBase commented on PR #5817: URL: https://github.com/apache/hbase/pull/5817#issuecomment-2055948554 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 27s | Docker

Re: [PR] HBASE-28509 ScanResumer.resume would perform unnecessary scan when cl… [hbase]

2024-04-15 Thread via GitHub
Apache-HBase commented on PR #5817: URL: https://github.com/apache/hbase/pull/5817#issuecomment-2055986820 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docke

Re: [PR] HBASE-28292 Make Delay prefetch property to be dynamically configured [hbase]

2024-04-15 Thread via GitHub
wchevreuil commented on PR #5605: URL: https://github.com/apache/hbase/pull/5605#issuecomment-2056208974 Any other concerns @petersomogyi , or would you think this is good to go now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] HBASE-28466 Integration of time-based priority logic of bucket cache in prefetch functionality of HBase [hbase]

2024-04-15 Thread via GitHub
wchevreuil commented on code in PR #5808: URL: https://github.com/apache/hbase/pull/5808#discussion_r1565426828 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePreadReader.java: ## @@ -37,6 +38,17 @@ public class HFilePreadReader extends HFileReaderImpl {

Re: [PR] HBASE-28466 Integration of time-based priority logic of bucket cache in prefetch functionality of HBase [hbase]

2024-04-15 Thread via GitHub
vinayakphegde commented on code in PR #5808: URL: https://github.com/apache/hbase/pull/5808#discussion_r1565439527 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePreadReader.java: ## @@ -37,6 +38,17 @@ public class HFilePreadReader extends HFileReaderImpl {

Re: [PR] HBASE-28509 ScanResumer.resume would perform unnecessary scan when cl… [hbase]

2024-04-15 Thread via GitHub
Apache-HBase commented on PR #5817: URL: https://github.com/apache/hbase/pull/5817#issuecomment-2056337445 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docke

Re: [PR] HBASE-28468: Integration of time-based priority caching in eviction logic. [hbase]

2024-04-15 Thread via GitHub
jhungund commented on code in PR #5826: URL: https://github.com/apache/hbase/pull/5826#discussion_r1565476088 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketProtoUtils.java: ## @@ -130,10 +136,30 @@ static Pair, NavigableSet result = new ConcurrentH

Re: [PR] HBASE-28468: Integration of time-based priority caching in eviction logic. [hbase]

2024-04-15 Thread via GitHub
Apache-HBase commented on PR #5826: URL: https://github.com/apache/hbase/pull/5826#issuecomment-2056389576 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s | Docker

Re: [PR] HBASE-28468: Integration of time-based priority caching in eviction logic. [hbase]

2024-04-15 Thread via GitHub
jhungund commented on PR #5826: URL: https://github.com/apache/hbase/pull/5826#issuecomment-2056405520 > You are passing @vinayakphegde 's commit together with yours in this PR, and this is causing conflicts with the target branch (the PR can't be merged). Please rebase your local branch fi

Re: [PR] Alternative solution for data Tiering integration into cache evictions. [hbase]

2024-04-15 Thread via GitHub
Apache-HBase commented on PR #5829: URL: https://github.com/apache/hbase/pull/5829#issuecomment-2056440848 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 14s | Docker

Re: [PR] HBASE-28466 Integration of time-based priority logic of bucket cache in prefetch functionality of HBase [hbase]

2024-04-15 Thread via GitHub
Apache-HBase commented on PR #5808: URL: https://github.com/apache/hbase/pull/5808#issuecomment-2056586259 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s | Docke

Re: [PR] HBASE-28517 Make properties dynamically configured [hbase]

2024-04-15 Thread via GitHub
Apache-HBase commented on PR #5823: URL: https://github.com/apache/hbase/pull/5823#issuecomment-2056722196 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 18s | Docker

Re: [PR] HBASE-28509 ScanResumer.resume would perform unnecessary scan when cl… [hbase]

2024-04-15 Thread via GitHub
Apache-HBase commented on PR #5817: URL: https://github.com/apache/hbase/pull/5817#issuecomment-2056782797 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docke

Re: [PR] HBASE-28509 ScanResumer.resume would perform unnecessary scan when cl… [hbase]

2024-04-15 Thread via GitHub
Apache-HBase commented on PR #5817: URL: https://github.com/apache/hbase/pull/5817#issuecomment-2056793545 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s | Docke

Re: [PR] HBASE-28509 ScanResumer.resume would perform unnecessary scan when cl… [hbase]

2024-04-15 Thread via GitHub
Apache-HBase commented on PR #5817: URL: https://github.com/apache/hbase/pull/5817#issuecomment-2056795698 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docke

Re: [PR] Alternative solution for data Tiering integration into cache evictions. [hbase]

2024-04-15 Thread via GitHub
Apache-HBase commented on PR #5829: URL: https://github.com/apache/hbase/pull/5829#issuecomment-2056922015 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 11s | Docker

Re: [PR] HBASE-28468: Integration of time-based priority caching in eviction logic. [hbase]

2024-04-15 Thread via GitHub
Apache-HBase commented on PR #5826: URL: https://github.com/apache/hbase/pull/5826#issuecomment-2056945658 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 49s | Docker

Re: [PR] HBASE-28468: Integration of time-based priority caching in eviction logic. [hbase]

2024-04-15 Thread via GitHub
Apache-HBase commented on PR #5826: URL: https://github.com/apache/hbase/pull/5826#issuecomment-2056951564 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docker

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

2024-04-15 Thread via GitHub
stoty commented on PR #5802: URL: https://github.com/apache/hbase/pull/5802#issuecomment-2056964975 Ruined formatting by spotless. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

2024-04-15 Thread via GitHub
Apache-HBase commented on PR #5802: URL: https://github.com/apache/hbase/pull/5802#issuecomment-2057032956 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s | Docke

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

2024-04-15 Thread via GitHub
Apache-HBase commented on PR #5802: URL: https://github.com/apache/hbase/pull/5802#issuecomment-2057033987 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docke

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

2024-04-15 Thread via GitHub
Apache-HBase commented on PR #5802: URL: https://github.com/apache/hbase/pull/5802#issuecomment-2057034754 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docke

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

2024-04-15 Thread via GitHub
Apache-HBase commented on PR #5802: URL: https://github.com/apache/hbase/pull/5802#issuecomment-2057035828 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s | Docke

Re: [PR] Alternative solution for data Tiering integration into cache evictions. [hbase]

2024-04-15 Thread via GitHub
Apache-HBase commented on PR #5829: URL: https://github.com/apache/hbase/pull/5829#issuecomment-2057101183 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

2024-04-15 Thread via GitHub
stoty merged PR #5802: URL: https://github.com/apache/hbase/pull/5802 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.or

Re: [PR] HBASE-28468: Integration of time-based priority caching in eviction logic. [hbase]

2024-04-15 Thread via GitHub
wchevreuil commented on code in PR #5826: URL: https://github.com/apache/hbase/pull/5826#discussion_r1565965514 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java: ## @@ -935,6 +936,16 @@ void freeSpace(final String why) { } try {

Re: [PR] Alternative solution for data Tiering integration into cache evictions. [hbase]

2024-04-15 Thread via GitHub
Apache-HBase commented on PR #5829: URL: https://github.com/apache/hbase/pull/5829#issuecomment-2057168221 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 12s | Docker

Re: [PR] HBASE-28517 Make properties dynamically configured [hbase]

2024-04-15 Thread via GitHub
Apache-HBase commented on PR #5823: URL: https://github.com/apache/hbase/pull/5823#issuecomment-2057198897 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s | Docker

Re: [PR] HBASE-28482 Reverse scan with tags throws ArrayIndexOutOfBoundsException with DBE in setCurrentBlock flow [hbase]

2024-04-15 Thread via GitHub
Apache-HBase commented on PR #5792: URL: https://github.com/apache/hbase/pull/5792#issuecomment-2057213179 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docke

Re: [PR] HBASE-28517 Make properties dynamically configured [hbase]

2024-04-15 Thread via GitHub
Apache-HBase commented on PR #5823: URL: https://github.com/apache/hbase/pull/5823#issuecomment-2057234238 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docke

Re: [PR] HBASE-28517 Make properties dynamically configured [hbase]

2024-04-15 Thread via GitHub
Apache-HBase commented on PR #5823: URL: https://github.com/apache/hbase/pull/5823#issuecomment-2057385042 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 46s | Docke

Re: [PR] HBASE-28466 Integration of time-based priority logic of bucket cache in prefetch functionality of HBase [hbase]

2024-04-15 Thread via GitHub
Apache-HBase commented on PR #5808: URL: https://github.com/apache/hbase/pull/5808#issuecomment-2057407179 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 38s | Docker

Re: [PR] HBASE-28466 Integration of time-based priority logic of bucket cache in prefetch functionality of HBase [hbase]

2024-04-15 Thread via GitHub
Apache-HBase commented on PR #5808: URL: https://github.com/apache/hbase/pull/5808#issuecomment-2057425599 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 41s | Docker

Re: [PR] HBASE-28482 Reverse scan with tags throws ArrayIndexOutOfBoundsException with DBE in setCurrentBlock flow [hbase]

2024-04-15 Thread via GitHub
Apache-HBase commented on PR #5792: URL: https://github.com/apache/hbase/pull/5792#issuecomment-2057658010 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docker

Re: [PR] HBASE-28514: HBase web console automatically listing directories in static/css [hbase]

2024-04-15 Thread via GitHub
Apache-HBase commented on PR #5830: URL: https://github.com/apache/hbase/pull/5830#issuecomment-2057666230 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docker

Re: [PR] HBASE-28482 Reverse scan with tags throws ArrayIndexOutOfBoundsException with DBE in setCurrentBlock flow [hbase]

2024-04-15 Thread via GitHub
Apache-HBase commented on PR #5792: URL: https://github.com/apache/hbase/pull/5792#issuecomment-2057685991 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docke

Re: [PR] Alternative solution for data Tiering integration into cache evictions. [hbase]

2024-04-15 Thread via GitHub
Apache-HBase commented on PR #5829: URL: https://github.com/apache/hbase/pull/5829#issuecomment-2057703402 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docker

Re: [PR] HBASE-28482 Reverse scan with tags throws ArrayIndexOutOfBoundsException with DBE in setCurrentBlock flow [hbase]

2024-04-15 Thread via GitHub
Apache-HBase commented on PR #5792: URL: https://github.com/apache/hbase/pull/5792#issuecomment-2057706760 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 41s | Docke

Re: [PR] Alternative solution for data Tiering integration into cache evictions. [hbase]

2024-04-15 Thread via GitHub
Apache-HBase commented on PR #5829: URL: https://github.com/apache/hbase/pull/5829#issuecomment-2057724090 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s | Docker

Re: [PR] HBASE-28514: HBase web console automatically listing directories in static/css [hbase]

2024-04-15 Thread via GitHub
Apache-HBase commented on PR #5830: URL: https://github.com/apache/hbase/pull/5830#issuecomment-2057960877 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 13s | Docke

Re: [PR] HBASE-28518 Allow specifying a filter for the REST multiget endpoint [hbase]

2024-04-15 Thread via GitHub
ankitsinghal commented on code in PR #5822: URL: https://github.com/apache/hbase/pull/5822#discussion_r1566528648 ## hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/MultiRowResource.java: ## @@ -65,15 +73,33 @@ public MultiRowResource(TableResource tableResource, String v

Re: [PR] HBASE-28514: HBase web console automatically listing directories in static/css [hbase]

2024-04-15 Thread via GitHub
Apache-HBase commented on PR #5830: URL: https://github.com/apache/hbase/pull/5830#issuecomment-2057972723 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docke

Re: [PR] HBASE-28514: HBase web console automatically listing directories in static/css [hbase]

2024-04-15 Thread via GitHub
Apache-HBase commented on PR #5830: URL: https://github.com/apache/hbase/pull/5830#issuecomment-2057993264 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 10s | Docke

Re: [PR] HBASE-28518 Allow specifying a filter for the REST multiget endpoint [hbase]

2024-04-15 Thread via GitHub
stoty commented on code in PR #5822: URL: https://github.com/apache/hbase/pull/5822#discussion_r1566671776 ## hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/Constants.java: ## @@ -80,6 +80,7 @@ public interface Constants { String SCAN_LIMIT = "limit"; String SCAN_FE

Re: [PR] HBASE-28518 Allow specifying a filter for the REST multiget endpoint [hbase]

2024-04-15 Thread via GitHub
stoty commented on code in PR #5822: URL: https://github.com/apache/hbase/pull/5822#discussion_r1566673341 ## hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/MultiRowResource.java: ## @@ -65,15 +73,33 @@ public MultiRowResource(TableResource tableResource, String versions

Re: [PR] HBASE-28518 Allow specifying a filter for the REST multiget endpoint [hbase]

2024-04-15 Thread via GitHub
stoty commented on code in PR #5822: URL: https://github.com/apache/hbase/pull/5822#discussion_r1566673341 ## hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/MultiRowResource.java: ## @@ -65,15 +73,33 @@ public MultiRowResource(TableResource tableResource, String versions

Re: [PR] HBASE-28518 Allow specifying a filter for the REST multiget endpoint [hbase]

2024-04-15 Thread via GitHub
stoty commented on PR #5822: URL: https://github.com/apache/hbase/pull/5822#issuecomment-2058198441 renamed variables and ran spotless:apply -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] HBASE-28518 Allow specifying a filter for the REST multiget endpoint [hbase]

2024-04-15 Thread via GitHub
Apache-HBase commented on PR #5822: URL: https://github.com/apache/hbase/pull/5822#issuecomment-2058205739 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 53s | Docker

Re: [PR] HBASE-28518 Allow specifying a filter for the REST multiget endpoint [hbase]

2024-04-15 Thread via GitHub
Apache-HBase commented on PR #5822: URL: https://github.com/apache/hbase/pull/5822#issuecomment-2058208408 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 15s | Docker

Re: [PR] HBASE-28518 Allow specifying a filter for the REST multiget endpoint [hbase]

2024-04-15 Thread via GitHub
Apache-HBase commented on PR #5822: URL: https://github.com/apache/hbase/pull/5822#issuecomment-2058209129 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 57s | Docker

Re: [PR] HBASE-28518 Allow specifying a filter for the REST multiget endpoint [hbase]

2024-04-15 Thread via GitHub
Apache-HBase commented on PR #5822: URL: https://github.com/apache/hbase/pull/5822#issuecomment-2058213863 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m 11s | Docker

Re: [PR] HBASE-28518 Allow specifying a filter for the REST multiget endpoint [hbase]

2024-04-15 Thread via GitHub
Apache-HBase commented on PR #5822: URL: https://github.com/apache/hbase/pull/5822#issuecomment-2058233754 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docke

Re: [PR] HBASE-28518 Allow specifying a filter for the REST multiget endpoint [hbase]

2024-04-15 Thread via GitHub
Apache-HBase commented on PR #5822: URL: https://github.com/apache/hbase/pull/5822#issuecomment-2058234010 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 18s | Docke

Re: [PR] HBASE-28518 Allow specifying a filter for the REST multiget endpoint [hbase]

2024-04-15 Thread via GitHub
Apache-HBase commented on PR #5822: URL: https://github.com/apache/hbase/pull/5822#issuecomment-2058234972 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docke

Re: [PR] HBASE-28518 Allow specifying a filter for the REST multiget endpoint [hbase]

2024-04-15 Thread via GitHub
Apache-HBase commented on PR #5822: URL: https://github.com/apache/hbase/pull/5822#issuecomment-2058235845 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 26s | Docke

Re: [PR] HBASE-18570 Fix NPE when HBaseContext was never initialized [hbase-connectors]

2024-04-15 Thread via GitHub
Apache-HBase commented on PR #127: URL: https://github.com/apache/hbase-connectors/pull/127#issuecomment-2058248839 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 41s

Re: [PR] HBASE-28518 Allow specifying a filter for the REST multiget endpoint [hbase]

2024-04-15 Thread via GitHub
stoty commented on PR #5822: URL: https://github.com/apache/hbase/pull/5822#issuecomment-2058250810 merging manually -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] HBASE-28518 Allow specifying a filter for the REST multiget endpoint [hbase]

2024-04-15 Thread via GitHub
stoty closed pull request #5822: HBASE-28518 Allow specifying a filter for the REST multiget endpoint URL: https://github.com/apache/hbase/pull/5822 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] HBASE-28517 Make properties dynamically configured [hbase]

2024-04-15 Thread via GitHub
Apache-HBase commented on PR #5823: URL: https://github.com/apache/hbase/pull/5823#issuecomment-2058294708 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docke

Re: [PR] HBASE-28500 Rest Java client library assumes stateless servers [hbase]

2024-04-15 Thread via GitHub
stoty commented on PR #5804: URL: https://github.com/apache/hbase/pull/5804#issuecomment-2058335720 Adding signed-off headers to kick off another CI run -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] HBASE-28500 Rest Java client library assumes stateless servers [hbase]

2024-04-15 Thread via GitHub
Apache-HBase commented on PR #5804: URL: https://github.com/apache/hbase/pull/5804#issuecomment-2058370118 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 48s | Docker

Re: [PR] HBASE-28500 Rest Java client library assumes stateless servers [hbase]

2024-04-16 Thread via GitHub
Apache-HBase commented on PR #5804: URL: https://github.com/apache/hbase/pull/5804#issuecomment-2058373910 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 17s | Docke

Re: [PR] HBASE-28500 Rest Java client library assumes stateless servers [hbase]

2024-04-16 Thread via GitHub
Apache-HBase commented on PR #5804: URL: https://github.com/apache/hbase/pull/5804#issuecomment-2058373943 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 15s | Docke

Re: [PR] HBASE-28500 Rest Java client library assumes stateless servers [hbase]

2024-04-16 Thread via GitHub
Apache-HBase commented on PR #5804: URL: https://github.com/apache/hbase/pull/5804#issuecomment-2058375574 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 48s | Docke

Re: [PR] HBASE-28500 Rest Java client library assumes stateless servers [hbase]

2024-04-16 Thread via GitHub
stoty merged PR #5804: URL: https://github.com/apache/hbase/pull/5804 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.or

Re: [PR] HBASE-28468: Integration of time-based priority caching in eviction logic. [hbase]

2024-04-16 Thread via GitHub
jhungund commented on code in PR #5826: URL: https://github.com/apache/hbase/pull/5826#discussion_r1566860086 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePreadReader.java: ## @@ -79,7 +79,7 @@ public void run() { // so we check first if the

Re: [PR] HBASE-28468: Integration of time-based priority caching in eviction logic. [hbase]

2024-04-16 Thread via GitHub
jhungund commented on code in PR #5826: URL: https://github.com/apache/hbase/pull/5826#discussion_r1566860488 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketProtoUtils.java: ## @@ -130,10 +136,30 @@ static Pair, NavigableSet result = new ConcurrentH

Re: [PR] HBASE-28464: Make replication ZKWatcher config customizable in extens… [hbase]

2024-04-16 Thread via GitHub
BukrosSzabolcs commented on code in PR #5785: URL: https://github.com/apache/hbase/pull/5785#discussion_r1566941715 ## hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java: ## @@ -110,6 +112,23 @@ public static RecoverableZooKeeper connect(Co

Re: [PR] HBASE-28464: Make replication ZKWatcher config customizable in extens… [hbase]

2024-04-16 Thread via GitHub
BukrosSzabolcs commented on code in PR #5785: URL: https://github.com/apache/hbase/pull/5785#discussion_r1566942453 ## hbase-server/src/main/java/org/apache/hadoop/hbase/replication/HBaseReplicationEndpoint.java: ## @@ -193,12 +194,16 @@ private void reloadZkWatcher() throws IOE

Re: [PR] HBASE-28464: Make replication ZKWatcher config customizable in extens… [hbase]

2024-04-16 Thread via GitHub
Apache-HBase commented on PR #5785: URL: https://github.com/apache/hbase/pull/5785#issuecomment-2058605802 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docker

Re: [PR] HBASE-28517 Make properties dynamically configured [hbase]

2024-04-16 Thread via GitHub
Apache-HBase commented on PR #5823: URL: https://github.com/apache/hbase/pull/5823#issuecomment-2058719632 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docke

Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-04-16 Thread via GitHub
gvprathyusha6 commented on PR #5307: URL: https://github.com/apache/hbase/pull/5307#issuecomment-2058823306 > > Could you please provide a UT or add an example in hbase-examples to show how to make use of this feature? > > Thanks. > > @Apache9 I have added UT to parse and validate

Re: [PR] HBASE-28517 Make properties dynamically configured [hbase]

2024-04-16 Thread via GitHub
Apache-HBase commented on PR #5823: URL: https://github.com/apache/hbase/pull/5823#issuecomment-2058866657 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 14s | Docker

Re: [PR] HBASE-28517 Make properties dynamically configured [hbase]

2024-04-16 Thread via GitHub
Apache-HBase commented on PR #5823: URL: https://github.com/apache/hbase/pull/5823#issuecomment-2058898802 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 18s | Docker

Re: [PR] HBASE-28517 Make properties dynamically configured [hbase]

2024-04-16 Thread via GitHub
kabhishek4 commented on PR #5823: URL: https://github.com/apache/hbase/pull/5823#issuecomment-2058943926 @Apache9 I ran the failed tests locally, they passed. Can you please review the new patch set? -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] HBASE-28292 Make Delay prefetch property to be dynamically configured [hbase]

2024-04-16 Thread via GitHub
petersomogyi commented on PR #5605: URL: https://github.com/apache/hbase/pull/5605#issuecomment-2058965578 > Any other concerns @petersomogyi , or would you think this is good to go now? Looks good to me! -- This is an automated message from the Apache Git Service. To respond to th

Re: [PR] HBASE-28464: Make replication ZKWatcher config customizable in extens… [hbase]

2024-04-16 Thread via GitHub
Apache-HBase commented on PR #5785: URL: https://github.com/apache/hbase/pull/5785#issuecomment-2058972288 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s | Docke

Re: [PR] HBASE-28292 Make Delay prefetch property to be dynamically configured [hbase]

2024-04-16 Thread via GitHub
petersomogyi merged PR #5605: URL: https://github.com/apache/hbase/pull/5605 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.ap

<    5   6   7   8   9   10   11   12   13   14   >