[ 
https://issues.apache.org/jira/browse/HIVE-20900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16686613#comment-16686613
 ] 

Zoltan Haindrich edited comment on HIVE-20900 at 11/14/18 2:52 PM:
-------------------------------------------------------------------

[~jdere] I kinda left that behind...I was thinking that its wierd to use a 
table property for something which is tied so closely to the columns type: I 
think by using timestamp.format tbl property it is not possible to have 2 
columns with different format - I feel that this format thing should belong to 
the column type instead of the table.
This is even more problematic when the UDF comes into the picture...as its not 
a table by far.
For hcat I intended to retain the functionality as before - but it looks like I 
wasn't successfull after all...I'm not sure how much effort would it be to add 
it to the column type/etc...so I guess we should retain the old behaviour - as 
users might expect it to work....the patch looks good (with writeables it could 
have skipped that part).



was (Author: kgyrtkirk):
[~jdere] I kinda left that behind...I was thinking that its wierd to use a 
table property for something which is tied so closely to the columns type: I 
think by using timestamp.format tbl property it is not possible to have 2 
columns with different format - I feel that this format thing should belong to 
the column type instead of the table.
This is even more problematic when the UDF comes into the picture...as its not 
a table by far.
For hcat it was retained to function as before...I'm not sure how much effort 
would it be to add it to the column type/etc...so I guess we should retain the 
old behaviour - as users might expect it to work....the patch looks good - with 
writeables it could have skipped that part).


> serde2.JsonSerDe no longer supports timestamp.formats
> -----------------------------------------------------
>
>                 Key: HIVE-20900
>                 URL: https://issues.apache.org/jira/browse/HIVE-20900
>             Project: Hive
>          Issue Type: Bug
>          Components: Serializers/Deserializers
>            Reporter: Jason Dere
>            Assignee: Jason Dere
>            Priority: Major
>         Attachments: HIVE-20900.1.patch, HIVE-20900.2.patch
>
>
> Looks like HIVE-18545 broke this.
> Also json_serde_tsformat.q only tested the hcat version of JsonSerde, and the 
> format in that test used the ISO timestamp format which apparently is now 
> parsed by the default timestamp parsing, so the test was too simple.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to