[
https://issues.apache.org/jira/browse/HIVE-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14620897#comment-14620897
]
Aihua Xu commented on HIVE-10895:
-
Thanks [~vgumashta]. Most are from your work. :)
> Obj
[
https://issues.apache.org/jira/browse/HIVE-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14620743#comment-14620743
]
Vaibhav Gumashta commented on HIVE-10895:
-
Was waiting for a precommit run. Looks
[
https://issues.apache.org/jira/browse/HIVE-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14620733#comment-14620733
]
Aihua Xu commented on HIVE-10895:
-
[~vgumashta] Can you help commit the patch?
> ObjectS
[
https://issues.apache.org/jira/browse/HIVE-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14619983#comment-14619983
]
Hive QA commented on HIVE-10895:
{color:green}Overall{color}: +1 all checks pass
Here a
[
https://issues.apache.org/jira/browse/HIVE-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14619381#comment-14619381
]
Aihua Xu commented on HIVE-10895:
-
ObjectStore was updated again to cause the conflict. Re
[
https://issues.apache.org/jira/browse/HIVE-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14619343#comment-14619343
]
Hive QA commented on HIVE-10895:
{color:red}Overall{color}: -1 no tests executed
Here a
[
https://issues.apache.org/jira/browse/HIVE-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14618685#comment-14618685
]
Aihua Xu commented on HIVE-10895:
-
[~vgumashta] Please commit the new .3 patch. I just reg
[
https://issues.apache.org/jira/browse/HIVE-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14618631#comment-14618631
]
Aihua Xu commented on HIVE-10895:
-
[~vgumashta] ObjectStore.java seems to have been change
[
https://issues.apache.org/jira/browse/HIVE-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14618098#comment-14618098
]
Vaibhav Gumashta commented on HIVE-10895:
-
[~aihuaxu] The patch (.3) does not appl
[
https://issues.apache.org/jira/browse/HIVE-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14618087#comment-14618087
]
Vaibhav Gumashta commented on HIVE-10895:
-
[~aihuaxu] Although the tests are still
[
https://issues.apache.org/jira/browse/HIVE-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14616674#comment-14616674
]
Vaibhav Gumashta commented on HIVE-10895:
-
[~aihuaxu] I'll need one more day to re
[
https://issues.apache.org/jira/browse/HIVE-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1461#comment-1461
]
Aihua Xu commented on HIVE-10895:
-
Thanks [~vgumashta] for doing the testing.
> ObjectSto
[
https://issues.apache.org/jira/browse/HIVE-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14614833#comment-14614833
]
Vaibhav Gumashta commented on HIVE-10895:
-
+1 on the patch. Tests will take few hr
[
https://issues.apache.org/jira/browse/HIVE-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14614773#comment-14614773
]
Vaibhav Gumashta commented on HIVE-10895:
-
[~aihuaxu] I'm back to work. Will revie
[
https://issues.apache.org/jira/browse/HIVE-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14611977#comment-14611977
]
Chaoyu Tang commented on HIVE-10895:
+1
> ObjectStore does not close Query objects in
[
https://issues.apache.org/jira/browse/HIVE-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14611952#comment-14611952
]
Aihua Xu commented on HIVE-10895:
-
[~ctang.ma] and [~sershe]. I double checked the patch.
[
https://issues.apache.org/jira/browse/HIVE-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14611340#comment-14611340
]
Chaoyu Tang commented on HIVE-10895:
[~aihuaxu] Patch looks good to me except the nits
[
https://issues.apache.org/jira/browse/HIVE-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14609120#comment-14609120
]
Hive QA commented on HIVE-10895:
{color:red}Overall{color}: -1 at least one tests failed
[
https://issues.apache.org/jira/browse/HIVE-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14608850#comment-14608850
]
Sergey Shelukhin commented on HIVE-10895:
-
nit: patch appears to add tabs
> Objec
[
https://issues.apache.org/jira/browse/HIVE-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14606129#comment-14606129
]
Aihua Xu commented on HIVE-10895:
-
[~thejas] Yes. Those users are all using Oracle as the
[
https://issues.apache.org/jira/browse/HIVE-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14606099#comment-14606099
]
Thejas M Nair commented on HIVE-10895:
--
[~aihuaxu] Are those users also seeing the fa
[
https://issues.apache.org/jira/browse/HIVE-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14605894#comment-14605894
]
Chaoyu Tang commented on HIVE-10895:
[~aihuaxu] I left some comments on RB.
> ObjectS
[
https://issues.apache.org/jira/browse/HIVE-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14605667#comment-14605667
]
Aihua Xu commented on HIVE-10895:
-
Really appreciate it if you can review the code, give i
[
https://issues.apache.org/jira/browse/HIVE-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14605541#comment-14605541
]
Vaibhav Gumashta commented on HIVE-10895:
-
[~aihuaxu] Were you able to reproduce t
[
https://issues.apache.org/jira/browse/HIVE-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14605538#comment-14605538
]
Vaibhav Gumashta commented on HIVE-10895:
-
[~aihuaxu] I'll be able to look at the
[
https://issues.apache.org/jira/browse/HIVE-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14603712#comment-14603712
]
Hive QA commented on HIVE-10895:
{color:green}Overall{color}: +1 all checks pass
Here a
[
https://issues.apache.org/jira/browse/HIVE-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14603259#comment-14603259
]
Aihua Xu commented on HIVE-10895:
-
[~thejas], [~xuefuz], [~ctang.ma], could you please rev
[
https://issues.apache.org/jira/browse/HIVE-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14602895#comment-14602895
]
Aihua Xu commented on HIVE-10895:
-
It's caused by the patch, in which the order of the def
[
https://issues.apache.org/jira/browse/HIVE-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14602603#comment-14602603
]
Hive QA commented on HIVE-10895:
{color:red}Overall{color}: -1 at least one tests failed
[
https://issues.apache.org/jira/browse/HIVE-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14600141#comment-14600141
]
Aihua Xu commented on HIVE-10895:
-
Seems both tests are unrelated. TestPigHBaseStorageHand
[
https://issues.apache.org/jira/browse/HIVE-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14599897#comment-14599897
]
Hive QA commented on HIVE-10895:
{color:red}Overall{color}: -1 at least one tests failed
[
https://issues.apache.org/jira/browse/HIVE-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14599456#comment-14599456
]
Aihua Xu commented on HIVE-10895:
-
All the tests are not related to the patch.
> ObjectS
[
https://issues.apache.org/jira/browse/HIVE-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14598838#comment-14598838
]
Hive QA commented on HIVE-10895:
{color:red}Overall{color}: -1 at least one tests failed
[
https://issues.apache.org/jira/browse/HIVE-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14596679#comment-14596679
]
Aihua Xu commented on HIVE-10895:
-
[~vgumashta] I was looking into two solutions. 1. a wap
[
https://issues.apache.org/jira/browse/HIVE-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14596031#comment-14596031
]
Aihua Xu commented on HIVE-10895:
-
Got it. Thanks for letting me know. I will take over th
[
https://issues.apache.org/jira/browse/HIVE-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14596010#comment-14596010
]
Vaibhav Gumashta commented on HIVE-10895:
-
[~aihuaxu] I'm OOO for next few days. P
[
https://issues.apache.org/jira/browse/HIVE-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14596013#comment-14596013
]
Vaibhav Gumashta commented on HIVE-10895:
-
[~aihuaxu] I'm OOO for next few days. P
[
https://issues.apache.org/jira/browse/HIVE-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595962#comment-14595962
]
Aihua Xu commented on HIVE-10895:
-
Hi [~vgumashta] Any updates on that? Sorry to push you
[
https://issues.apache.org/jira/browse/HIVE-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14588538#comment-14588538
]
Aihua Xu commented on HIVE-10895:
-
Thanks Vaibhav. Will check the new patch when it's read
[
https://issues.apache.org/jira/browse/HIVE-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14588504#comment-14588504
]
Vaibhav Gumashta commented on HIVE-10895:
-
[~aihuaxu] Thanks for the comments on r
[
https://issues.apache.org/jira/browse/HIVE-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14570001#comment-14570001
]
Vaibhav Gumashta commented on HIVE-10895:
-
Patch v1 has some issues - uploading a
41 matches
Mail list logo