[
https://issues.apache.org/jira/browse/HIVE-11130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14625098#comment-14625098
]
Aihua Xu commented on HIVE-11130:
-
Test not related.
[~alangates] and [~csun]. Do you
[
https://issues.apache.org/jira/browse/HIVE-11130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14625004#comment-14625004
]
Hive QA commented on HIVE-11130:
{color:red}Overall{color}: -1 at least one tests failed
[
https://issues.apache.org/jira/browse/HIVE-11130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14625469#comment-14625469
]
Chao Sun commented on HIVE-11130:
-
LGTM +1
Refactoring the code so that HiveTxnManager
[
https://issues.apache.org/jira/browse/HIVE-11130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14616823#comment-14616823
]
Aihua Xu commented on HIVE-11130:
-
Can you take a look at the .2.patch? Moved the check
[
https://issues.apache.org/jira/browse/HIVE-11130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14616796#comment-14616796
]
Aihua Xu commented on HIVE-11130:
-
[~alangates] Yes. supportsExplicitLock() is being
[
https://issues.apache.org/jira/browse/HIVE-11130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14616802#comment-14616802
]
Aihua Xu commented on HIVE-11130:
-
Do you think we should move that logic to
[
https://issues.apache.org/jira/browse/HIVE-11130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14615574#comment-14615574
]
Alan Gates commented on HIVE-11130:
---
The only comment I have is that in the
[
https://issues.apache.org/jira/browse/HIVE-11130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14612211#comment-14612211
]
Chao Sun commented on HIVE-11130:
-
Hi [~aihuaxu], can you create a review board?
[
https://issues.apache.org/jira/browse/HIVE-11130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14612474#comment-14612474
]
Aihua Xu commented on HIVE-11130:
-
Thanks [~alangates] and [~csun]. I updated the patch to
[
https://issues.apache.org/jira/browse/HIVE-11130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14605782#comment-14605782
]
Aihua Xu commented on HIVE-11130:
-
Seems the two tests are not related to this
[
https://issues.apache.org/jira/browse/HIVE-11130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14603929#comment-14603929
]
Hive QA commented on HIVE-11130:
{color:red}Overall{color}: -1 at least one tests failed
11 matches
Mail list logo