[
https://issues.apache.org/jira/browse/HIVE-11710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14969193#comment-14969193
]
Aihua Xu commented on HIVE-11710:
-
Xuefu, can you help submit the patch?
> Beeline embedded mode doesn't
[
https://issues.apache.org/jira/browse/HIVE-11710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14963478#comment-14963478
]
Aihua Xu commented on HIVE-11710:
-
[~xuefuz] can you help review the new patch?
> Beeline embedded mode
[
https://issues.apache.org/jira/browse/HIVE-11710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14963592#comment-14963592
]
Xuefu Zhang commented on HIVE-11710:
+1
> Beeline embedded mode doesn't output query progress after
[
https://issues.apache.org/jira/browse/HIVE-11710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14961636#comment-14961636
]
Hive QA commented on HIVE-11710:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-11710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14959103#comment-14959103
]
Aihua Xu commented on HIVE-11710:
-
Seems HIVE-11579 fixed one related issue, but the current incorrect
[
https://issues.apache.org/jira/browse/HIVE-11710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14959601#comment-14959601
]
Aihua Xu commented on HIVE-11710:
-
Attached the new patch which will close the streams if there is an
[
https://issues.apache.org/jira/browse/HIVE-11710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14959359#comment-14959359
]
Aihua Xu commented on HIVE-11710:
-
OK. Seems we don't need flush the string manually since autoFlush is
[
https://issues.apache.org/jira/browse/HIVE-11710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14959364#comment-14959364
]
Aihua Xu commented on HIVE-11710:
-
Thanks [~Ferd] I will try to add one unit test to cover that.
>
[
https://issues.apache.org/jira/browse/HIVE-11710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14959358#comment-14959358
]
Aihua Xu commented on HIVE-11710:
-
OK. Seems we don't need flush the string manually since autoFlush is
[
https://issues.apache.org/jira/browse/HIVE-11710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14907772#comment-14907772
]
Hive QA commented on HIVE-11710:
{color:red}Overall{color}: -1 at least one tests failed
Here are the
[
https://issues.apache.org/jira/browse/HIVE-11710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14904502#comment-14904502
]
Aihua Xu commented on HIVE-11710:
-
Yeah. The second patch will leak "PrintStream", so I think the first
[
https://issues.apache.org/jira/browse/HIVE-11710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14904628#comment-14904628
]
Aihua Xu commented on HIVE-11710:
-
[~xuefuz] I double checked. The first patch is good to handle closing
[
https://issues.apache.org/jira/browse/HIVE-11710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14904882#comment-14904882
]
Xuefu Zhang commented on HIVE-11710:
[~aihuaxu], looking at the two patches, I seem to see that either
[
https://issues.apache.org/jira/browse/HIVE-11710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14905037#comment-14905037
]
Aihua Xu commented on HIVE-11710:
-
[~xuefuz] Regarding #2, in SQLOperation class, the streams are using
[
https://issues.apache.org/jira/browse/HIVE-11710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14905070#comment-14905070
]
Aihua Xu commented on HIVE-11710:
-
For SQLOperation, the stream are System.out and System.err. We
[
https://issues.apache.org/jira/browse/HIVE-11710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14905041#comment-14905041
]
Xuefu Zhang commented on HIVE-11710:
For #2, I meant that we need something similar to
[
https://issues.apache.org/jira/browse/HIVE-11710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14905112#comment-14905112
]
Aihua Xu commented on HIVE-11710:
-
Indeed that we have misunderstanding. :) Now I know what you mean.
[
https://issues.apache.org/jira/browse/HIVE-11710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14905087#comment-14905087
]
Xuefu Zhang commented on HIVE-11710:
{quote}
For SQLOperation, the stream are System.out and
[
https://issues.apache.org/jira/browse/HIVE-11710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14905073#comment-14905073
]
Aihua Xu commented on HIVE-11710:
-
We will close File based stream, not standard System.out and
[
https://issues.apache.org/jira/browse/HIVE-11710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14904121#comment-14904121
]
Hive QA commented on HIVE-11710:
{color:red}Overall{color}: -1 at least one tests failed
Here are the
[
https://issues.apache.org/jira/browse/HIVE-11710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14905382#comment-14905382
]
Xuefu Zhang commented on HIVE-11710:
Does the following pseudo code helps a little bit?
{code}
public
[
https://issues.apache.org/jira/browse/HIVE-11710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14905158#comment-14905158
]
Aihua Xu commented on HIVE-11710:
-
PrintStream.close() will do "flushing the stream and then closing the
[
https://issues.apache.org/jira/browse/HIVE-11710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14905128#comment-14905128
]
Xuefu Zhang commented on HIVE-11710:
I see. If we don't close the PrintStream instances, won't there
[
https://issues.apache.org/jira/browse/HIVE-11710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14903471#comment-14903471
]
Xuefu Zhang commented on HIVE-11710:
[~aihuaxu], your new patch looks good. One thing I'm not 100%
[
https://issues.apache.org/jira/browse/HIVE-11710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14902821#comment-14902821
]
Aihua Xu commented on HIVE-11710:
-
[~xuefuz] Attached the new patch which doesn't close the ss.out or
[
https://issues.apache.org/jira/browse/HIVE-11710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14875868#comment-14875868
]
Xuefu Zhang commented on HIVE-11710:
Do you have any thoughts on this?
{quote}
It looks like that we
[
https://issues.apache.org/jira/browse/HIVE-11710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14745483#comment-14745483
]
Aihua Xu commented on HIVE-11710:
-
OK. Seems it's fine since from the close() call shown below, we are
[
https://issues.apache.org/jira/browse/HIVE-11710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14745465#comment-14745465
]
Aihua Xu commented on HIVE-11710:
-
Yeah. You are right. It really depends on how ss.out is used.
[
https://issues.apache.org/jira/browse/HIVE-11710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14743611#comment-14743611
]
Aihua Xu commented on HIVE-11710:
-
The failures are not caused by the patch.
> Beeline embedded mode
[
https://issues.apache.org/jira/browse/HIVE-11710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14744393#comment-14744393
]
Xuefu Zhang commented on HIVE-11710:
In HiveCommandOperation.tearDownSessionIO(), should we just
[
https://issues.apache.org/jira/browse/HIVE-11710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14741703#comment-14741703
]
Hive QA commented on HIVE-11710:
{color:red}Overall{color}: -1 at least one tests failed
Here are the
[
https://issues.apache.org/jira/browse/HIVE-11710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14738780#comment-14738780
]
Aihua Xu commented on HIVE-11710:
-
I didn't create code review for this since it's a simple change. Submit
[
https://issues.apache.org/jira/browse/HIVE-11710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14739348#comment-14739348
]
Xuefu Zhang commented on HIVE-11710:
Could we also check what Hive CLI is doing w.r.t this?
> Beeline
[
https://issues.apache.org/jira/browse/HIVE-11710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14739409#comment-14739409
]
Aihua Xu commented on HIVE-11710:
-
CLI sets as follows in CLIDriver.java.
{noformat}
ss.out = new
[
https://issues.apache.org/jira/browse/HIVE-11710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14739441#comment-14739441
]
Aihua Xu commented on HIVE-11710:
-
Actually after {{IOUtils.cleanup(LOG,
35 matches
Mail list logo
