[jira] [Commented] (HIVE-14303) CommonJoinOperator.checkAndGenObject should return directly at CLOSE state to avoid NPE if ExecReducer.close is called twice.

2016-08-01 Thread zhihai xu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-14303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401656#comment-15401656 ] zhihai xu commented on HIVE-14303: -- Attached the stack trace which prove checkAndGenObjec

[jira] [Commented] (HIVE-14303) CommonJoinOperator.checkAndGenObject should return directly at CLOSE state to avoid NPE if ExecReducer.close is called twice.

2016-08-01 Thread zhihai xu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-14303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401652#comment-15401652 ] zhihai xu commented on HIVE-14303: -- Thanks for finding this issue, It was my fault, I mis

[jira] [Commented] (HIVE-14303) CommonJoinOperator.checkAndGenObject should return directly at CLOSE state to avoid NPE if ExecReducer.close is called twice.

2016-07-29 Thread Chao Sun (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-14303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15400355#comment-15400355 ] Chao Sun commented on HIVE-14303: - Yes, it seems the test failures are related to this pat

[jira] [Commented] (HIVE-14303) CommonJoinOperator.checkAndGenObject should return directly at CLOSE state to avoid NPE if ExecReducer.close is called twice.

2016-07-29 Thread Chao Sun (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-14303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15400346#comment-15400346 ] Chao Sun commented on HIVE-14303: - [~ashutoshc] I chose one failed test (auto_smb_mapjoin_

[jira] [Commented] (HIVE-14303) CommonJoinOperator.checkAndGenObject should return directly at CLOSE state to avoid NPE if ExecReducer.close is called twice.

2016-07-29 Thread Ashutosh Chauhan (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-14303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15400297#comment-15400297 ] Ashutosh Chauhan commented on HIVE-14303: - Seems like these reported failures were

[jira] [Commented] (HIVE-14303) CommonJoinOperator.checkAndGenObject should return directly at CLOSE state to avoid NPE if ExecReducer.close is called twice.

2016-07-29 Thread Chao Sun (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-14303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15399943#comment-15399943 ] Chao Sun commented on HIVE-14303: - Committed to master. Thanks [~zxu] for the patch and [~

[jira] [Commented] (HIVE-14303) CommonJoinOperator.checkAndGenObject should return directly at CLOSE state to avoid NPE if ExecReducer.close is called twice.

2016-07-29 Thread zhihai xu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-14303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15399859#comment-15399859 ] zhihai xu commented on HIVE-14303: -- Thanks for the review [~csun]! All these test failure

[jira] [Commented] (HIVE-14303) CommonJoinOperator.checkAndGenObject should return directly at CLOSE state to avoid NPE if ExecReducer.close is called twice.

2016-07-29 Thread Chao Sun (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-14303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15399844#comment-15399844 ] Chao Sun commented on HIVE-14303: - Going to commit this. [~zxu] are the test failures rela

[jira] [Commented] (HIVE-14303) CommonJoinOperator.checkAndGenObject should return directly at CLOSE state to avoid NPE if ExecReducer.close is called twice.

2016-07-27 Thread Xuefu Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-14303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15396871#comment-15396871 ] Xuefu Zhang commented on HIVE-14303: Ok. Thanks for the explanation. +1 > CommonJoinO

[jira] [Commented] (HIVE-14303) CommonJoinOperator.checkAndGenObject should return directly at CLOSE state to avoid NPE if ExecReducer.close is called twice.

2016-07-27 Thread zhihai xu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-14303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15396851#comment-15396851 ] zhihai xu commented on HIVE-14303: -- Thanks for the review [~xuefuz]! Currently {{IOUtils.

[jira] [Commented] (HIVE-14303) CommonJoinOperator.checkAndGenObject should return directly at CLOSE state to avoid NPE if ExecReducer.close is called twice.

2016-07-26 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-14303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15395025#comment-15395025 ] Hive QA commented on HIVE-14303: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-14303) CommonJoinOperator.checkAndGenObject should return directly at CLOSE state to avoid NPE if ExecReducer.close is called twice.

2016-07-25 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-14303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15392991#comment-15392991 ] Hive QA commented on HIVE-14303: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-14303) CommonJoinOperator.checkAndGenObject should return directly at CLOSE state to avoid NPE if ExecReducer.close is called twice.

2016-07-25 Thread Xuefu Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-14303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15392870#comment-15392870 ] Xuefu Zhang commented on HIVE-14303: Is it more logical if we check if reducer is null