[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16004088#comment-16004088
]
Ashutosh Chauhan commented on HIVE-14412:
-
yes.. there is coverage in junit tests.. +1
> Add a
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16004073#comment-16004073
]
Hive QA commented on HIVE-14412:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16004017#comment-16004017
]
Ashutosh Chauhan commented on HIVE-14412:
-
I see. If its a non-reserved key word and provides
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003950#comment-16003950
]
Rui Li commented on HIVE-14412:
---
[~ashutoshc], thanks for the review.
bq. Is there any reason to use
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003721#comment-16003721
]
Ashutosh Chauhan commented on HIVE-14412:
-
[~lirui] Patch looks good. Left few comments on RB.
>
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002950#comment-16002950
]
Ashutosh Chauhan commented on HIVE-14412:
-
Is there any reason to use timestamptz alias for type
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002794#comment-16002794
]
Xuefu Zhang commented on HIVE-14412:
+1
> Add a timezone-aware timestamp
>
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16001958#comment-16001958
]
Carter Shanklin commented on HIVE-14412:
Rui, tried the latest patch looks great.
> Add a
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16001925#comment-16001925
]
Rui Li commented on HIVE-14412:
---
The latest failure are not related.
[~cartershanklin], the Postgres
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16001781#comment-16001781
]
Xuefu Zhang commented on HIVE-14412:
Since session zone is not currently available in Hive, I think
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16001774#comment-16001774
]
Carter Shanklin commented on HIVE-14412:
You can store the time zone or adjust the values based on
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16001310#comment-16001310
]
Hive QA commented on HIVE-14412:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16000251#comment-16000251
]
Carter Shanklin commented on HIVE-14412:
I tried the patch and had a few comments, 1 relates to
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16000115#comment-16000115
]
Xuefu Zhang commented on HIVE-14412:
Patch looks good. I had a couple of questions on RB.
> Add a
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15994346#comment-15994346
]
Rui Li commented on HIVE-14412:
---
Latest failure are not related. I've updated the v11 patch on RB.
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15992872#comment-15992872
]
Hive QA commented on HIVE-14412:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15987952#comment-15987952
]
Hive QA commented on HIVE-14412:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985892#comment-15985892
]
Rui Li commented on HIVE-14412:
---
As discussed in HIVE-16418, we won't store the TZ part and all TimestampTZ
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984742#comment-15984742
]
Hive QA commented on HIVE-14412:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15968546#comment-15968546
]
Rui Li commented on HIVE-14412:
---
Hi [~ashutoshc], thanks for the suggestions.
bq. Timestamp with Timezone
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15968447#comment-15968447
]
Ashutosh Chauhan commented on HIVE-14412:
-
One concern I have is storing TZ in storage doesn't
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15967185#comment-15967185
]
Hive QA commented on HIVE-14412:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15564689#comment-15564689
]
Rui Li commented on HIVE-14412:
---
Thanks [~alangates] and [~jdere] for your inputs. I'll investigate how to
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533471#comment-15533471
]
Jason Dere commented on HIVE-14412:
---
bq. I thought about this. One difficulty is we need to serialize
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533452#comment-15533452
]
Alan Gates commented on HIVE-14412:
---
Agree the TZ <-> non TZ conversions look like they match up with
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15528517#comment-15528517
]
Rui Li commented on HIVE-14412:
---
[~jdere], thank you for the comments and trying this out.
bq. Is there a
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15527345#comment-15527345
]
Jason Dere commented on HIVE-14412:
---
Thanks for the patch. Had a few questions on the conversions:
Date
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517410#comment-15517410
]
Hive QA commented on HIVE-14412:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15513010#comment-15513010
]
Jason Dere commented on HIVE-14412:
---
Sorry, a little bit late to the review .. added a few initial
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15512404#comment-15512404
]
Hive QA commented on HIVE-14412:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15512148#comment-15512148
]
Xuefu Zhang commented on HIVE-14412:
+1
> Add a timezone-aware timestamp
>
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15511974#comment-15511974
]
Xuefu Zhang commented on HIVE-14412:
[~lirui], I have a couple of minor comment on RB. License header
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15511722#comment-15511722
]
Rui Li commented on HIVE-14412:
---
Latest failures not related and I've uploaded v6 to RB.
[~xuefuz] please
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15510305#comment-15510305
]
Hive QA commented on HIVE-14412:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508499#comment-15508499
]
Rui Li commented on HIVE-14412:
---
Most of the recent failures are because "TIME" is added as a new key word
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507121#comment-15507121
]
Hive QA commented on HIVE-14412:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15489157#comment-15489157
]
Rui Li commented on HIVE-14412:
---
Thank you guys for your inputs. Like Xuefu said, the standard name is
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15488638#comment-15488638
]
Jason Dere commented on HIVE-14412:
---
Check if there are any issues with
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15488639#comment-15488639
]
Jason Dere commented on HIVE-14412:
---
Check if there are any issues with
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15488427#comment-15488427
]
Xuefu Zhang commented on HIVE-14412:
I think the standard type name is TIMESTAMP WITH TIMEZONE.
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15487655#comment-15487655
]
Matt McCline commented on HIVE-14412:
-
And, SerializedWrite/DeserializationRead and ORC?
> Add a
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15487650#comment-15487650
]
Matt McCline commented on HIVE-14412:
-
What about vectorization support??
> Add a timezone-aware
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15487429#comment-15487429
]
Sergio Peña commented on HIVE-14412:
I don't know if we support spaces on type names, but I think we
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15486593#comment-15486593
]
Rui Li commented on HIVE-14412:
---
I've drafted a summary of the proposal in Google Doc and linked it here.
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15485989#comment-15485989
]
Rui Li commented on HIVE-14412:
---
Thanks [~xuefuz] for your comments!
bq. TIMESTAMP WITH TIME ZONE is the
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15485772#comment-15485772
]
Xuefu Zhang commented on HIVE-14412:
Hi [~lirui], thanks for working on this. It may take me sometime
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15482896#comment-15482896
]
Rui Li commented on HIVE-14412:
---
The failure don't seem related.
[~xuefuz] could you take a look? I've put
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15477327#comment-15477327
]
Hive QA commented on HIVE-14412:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15469620#comment-15469620
]
Hive QA commented on HIVE-14412:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15430384#comment-15430384
]
Rui Li commented on HIVE-14412:
---
I think make HiveTimestamp a subclass of Timestamp can be problematic. E.g.
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15424515#comment-15424515
]
Rui Li commented on HIVE-14412:
---
Maybe I can use a nanos larger than 9 to indicate the extra field.
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15423762#comment-15423762
]
Rui Li commented on HIVE-14412:
---
To read the new field, we need another IntegerReader in
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15423172#comment-15423172
]
Xuefu Zhang commented on HIVE-14412:
Adding a new field might be okay, as long as the new reader is
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422200#comment-15422200
]
Rui Li commented on HIVE-14412:
---
[~xuefuz], thanks for your comments. In {{TimestampColumnVector}}, we store
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15421358#comment-15421358
]
Xuefu Zhang commented on HIVE-14412:
[~lirui], your proposal looks good to me, especially it's
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420848#comment-15420848
]
Rui Li commented on HIVE-14412:
---
Somehow the tests worked this time. {{TestStandardObjectInspectors}} is
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420621#comment-15420621
]
Hive QA commented on HIVE-14412:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418963#comment-15418963
]
Sergio Peña commented on HIVE-14412:
I see these maven versions used:
PTEST MASTER (Hive is built
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414860#comment-15414860
]
Rui Li commented on HIVE-14412:
---
If I run {{mvn dependency:tree}}, only sshj-0.8.1 is found in the
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414594#comment-15414594
]
Rui Li commented on HIVE-14412:
---
The error is {{Invalid JDK version in profile 'doclint-java8-disable':
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414388#comment-15414388
]
Sergio Peña commented on HIVE-14412:
[~lirui] The 'console output' link does not work anymore. Could
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411204#comment-15411204
]
Rui Li commented on HIVE-14412:
---
Here's the [console
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407038#comment-15407038
]
Rui Li commented on HIVE-14412:
---
Thanks [~sershe] for your comments.
For UDFs like "to/from UTC timestamp",
[
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406415#comment-15406415
]
Sergey Shelukhin commented on HIVE-14412:
-
Doesn't the problem only exist at the time of parsing
64 matches
Mail list logo
