[jira] [Commented] (HIVE-17261) Hive use deprecated ParquetInputSplit constructor which blocked parquet dictionary filter

2017-09-16 Thread Ferdinand Xu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169162#comment-16169162 ] Ferdinand Xu commented on HIVE-17261: - Hi [~csun], Vectorization reader can't leverage the existing

[jira] [Commented] (HIVE-17261) Hive use deprecated ParquetInputSplit constructor which blocked parquet dictionary filter

2017-09-15 Thread Chao Sun (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168216#comment-16168216 ] Chao Sun commented on HIVE-17261: - [~Ferd]: does

[jira] [Commented] (HIVE-17261) Hive use deprecated ParquetInputSplit constructor which blocked parquet dictionary filter

2017-09-15 Thread Junjie Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167454#comment-16167454 ] Junjie Chen commented on HIVE-17261: I think the length in create table should specify the maximum

[jira] [Commented] (HIVE-17261) Hive use deprecated ParquetInputSplit constructor which blocked parquet dictionary filter

2017-09-15 Thread Ferdinand Xu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167409#comment-16167409 ] Ferdinand Xu commented on HIVE-17261: - Thanks [~junjie] for the investigation. Hive should cast

[jira] [Commented] (HIVE-17261) Hive use deprecated ParquetInputSplit constructor which blocked parquet dictionary filter

2017-09-15 Thread Junjie Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167401#comment-16167401 ] Junjie Chen commented on HIVE-17261: The insert statement following store values in parquet without

[jira] [Commented] (HIVE-17261) Hive use deprecated ParquetInputSplit constructor which blocked parquet dictionary filter

2017-09-13 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165722#comment-16165722 ] Hive QA commented on HIVE-17261: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-17261) Hive use deprecated ParquetInputSplit constructor which blocked parquet dictionary filter

2017-09-13 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165648#comment-16165648 ] Hive QA commented on HIVE-17261: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-17261) Hive use deprecated ParquetInputSplit constructor which blocked parquet dictionary filter

2017-09-13 Thread Ferdinand Xu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164196#comment-16164196 ] Ferdinand Xu commented on HIVE-17261: - LGTM +1 pending on the test > Hive use deprecated

[jira] [Commented] (HIVE-17261) Hive use deprecated ParquetInputSplit constructor which blocked parquet dictionary filter

2017-09-12 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162959#comment-16162959 ] Hive QA commented on HIVE-17261: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-17261) Hive use deprecated ParquetInputSplit constructor which blocked parquet dictionary filter

2017-09-11 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16161299#comment-16161299 ] Hive QA commented on HIVE-17261: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-17261) Hive use deprecated ParquetInputSplit constructor which blocked parquet dictionary filter

2017-09-10 Thread Ferdinand Xu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160626#comment-16160626 ] Ferdinand Xu commented on HIVE-17261: - [~junjie], I take a further round look. One more minor comment

[jira] [Commented] (HIVE-17261) Hive use deprecated ParquetInputSplit constructor which blocked parquet dictionary filter

2017-09-10 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160599#comment-16160599 ] Hive QA commented on HIVE-17261: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-17261) Hive use deprecated ParquetInputSplit constructor which blocked parquet dictionary filter

2017-09-10 Thread Ferdinand Xu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160552#comment-16160552 ] Ferdinand Xu commented on HIVE-17261: - Thanks Junjie Chen for the patch. One comment is not addressed:

[jira] [Commented] (HIVE-17261) Hive use deprecated ParquetInputSplit constructor which blocked parquet dictionary filter

2017-09-07 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16156899#comment-16156899 ] Hive QA commented on HIVE-17261: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-17261) Hive use deprecated ParquetInputSplit constructor which blocked parquet dictionary filter

2017-09-06 Thread Junjie Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16156286#comment-16156286 ] Junjie Chen commented on HIVE-17261: Thanks [~Ferd] As for 4, since jobconf is a member variable, so

[jira] [Commented] (HIVE-17261) Hive use deprecated ParquetInputSplit constructor which blocked parquet dictionary filter

2017-09-06 Thread Ferdinand Xu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16155410#comment-16155410 ] Ferdinand Xu commented on HIVE-17261: - Thanks [~junjie] for the patch. Some minor comments below: In

[jira] [Commented] (HIVE-17261) Hive use deprecated ParquetInputSplit constructor which blocked parquet dictionary filter

2017-09-05 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153206#comment-16153206 ] Hive QA commented on HIVE-17261: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-17261) Hive use deprecated ParquetInputSplit constructor which blocked parquet dictionary filter

2017-08-11 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123550#comment-16123550 ] Hive QA commented on HIVE-17261: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-17261) Hive use deprecated ParquetInputSplit constructor which blocked parquet dictionary filter

2017-08-11 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123320#comment-16123320 ] Hive QA commented on HIVE-17261: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-17261) Hive use deprecated ParquetInputSplit constructor which blocked parquet dictionary filter

2017-08-11 Thread Ferdinand Xu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122983#comment-16122983 ] Ferdinand Xu commented on HIVE-17261: - Can we set the conf in the base class? Otherwise there is no

[jira] [Commented] (HIVE-17261) Hive use deprecated ParquetInputSplit constructor which blocked parquet dictionary filter

2017-08-11 Thread Junjie Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122944#comment-16122944 ] Junjie Chen commented on HIVE-17261: [~Ferd], Updated original unit tests to apply filter from parquet

[jira] [Commented] (HIVE-17261) Hive use deprecated ParquetInputSplit constructor which blocked parquet dictionary filter

2017-08-10 Thread Ferdinand Xu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122760#comment-16122760 ] Ferdinand Xu commented on HIVE-17261: - Thank [~junjie] for further analysis. Any way to add some UTs

[jira] [Commented] (HIVE-17261) Hive use deprecated ParquetInputSplit constructor which blocked parquet dictionary filter

2017-08-10 Thread Junjie Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122708#comment-16122708 ] Junjie Chen commented on HIVE-17261: Actually, Hive use two deprecated parquet APIs, one is

[jira] [Commented] (HIVE-17261) Hive use deprecated ParquetInputSplit constructor which blocked parquet dictionary filter

2017-08-10 Thread Ferdinand Xu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122622#comment-16122622 ] Ferdinand Xu commented on HIVE-17261: - As discussed offline, we can clean up the code to filter row

[jira] [Commented] (HIVE-17261) Hive use deprecated ParquetInputSplit constructor which blocked parquet dictionary filter

2017-08-10 Thread Junjie Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122594#comment-16122594 ] Junjie Chen commented on HIVE-17261: [~Ferd], I don't understand what you means, end() is private

[jira] [Commented] (HIVE-17261) Hive use deprecated ParquetInputSplit constructor which blocked parquet dictionary filter

2017-08-10 Thread Ferdinand Xu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121654#comment-16121654 ] Ferdinand Xu commented on HIVE-17261: - [~junjie] ParquetInputSplit doesn't implicitly call row group

[jira] [Commented] (HIVE-17261) Hive use deprecated ParquetInputSplit constructor which blocked parquet dictionary filter

2017-08-10 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121502#comment-16121502 ] Hive QA commented on HIVE-17261: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-17261) Hive use deprecated ParquetInputSplit constructor which blocked parquet dictionary filter

2017-08-10 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121252#comment-16121252 ] Hive QA commented on HIVE-17261: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-17261) Hive use deprecated ParquetInputSplit constructor which blocked parquet dictionary filter

2017-08-10 Thread Junjie Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121126#comment-16121126 ] Junjie Chen commented on HIVE-17261: Yes,

[jira] [Commented] (HIVE-17261) Hive use deprecated ParquetInputSplit constructor which blocked parquet dictionary filter

2017-08-09 Thread Ferdinand Xu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121105#comment-16121105 ] Ferdinand Xu commented on HIVE-17261: - Sorry for misleading. Update previous question. > Hive use

[jira] [Commented] (HIVE-17261) Hive use deprecated ParquetInputSplit constructor which blocked parquet dictionary filter

2017-08-09 Thread Junjie Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121082#comment-16121082 ] Junjie Chen commented on HIVE-17261: Hive convert search argument to FilterPredicate and push down to

[jira] [Commented] (HIVE-17261) Hive use deprecated ParquetInputSplit constructor which blocked parquet dictionary filter

2017-08-09 Thread Ferdinand Xu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121073#comment-16121073 ] Ferdinand Xu commented on HIVE-17261: - Can you rename the patch to HIVE-17261.patch? I see the new

[jira] [Commented] (HIVE-17261) Hive use deprecated ParquetInputSplit constructor which blocked parquet dictionary filter

2017-08-09 Thread liyunzhang_intel (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121062#comment-16121062 ] liyunzhang_intel commented on HIVE-17261: - [~junjie]: GTM from my side. [~ferd] and [~csun]:

[jira] [Commented] (HIVE-17261) Hive use deprecated ParquetInputSplit constructor which blocked parquet dictionary filter

2017-08-09 Thread Junjie Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121006#comment-16121006 ] Junjie Chen commented on HIVE-17261: Hi [~kellyzly] Could you please have a look? > Hive use