[jira] [Commented] (HIVE-17606) Improve security for DB notification related APIs

2017-10-01 Thread Tao Li (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187465#comment-16187465 ] Tao Li commented on HIVE-17606: --- Added a section here:

[jira] [Commented] (HIVE-17606) Improve security for DB notification related APIs

2017-09-30 Thread Tao Li (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187256#comment-16187256 ] Tao Li commented on HIVE-17606: --- Thanks [~thejas]. Will update Apache wiki asap. > Improve security for DB

[jira] [Commented] (HIVE-17606) Improve security for DB notification related APIs

2017-09-28 Thread Thejas M Nair (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185026#comment-16185026 ] Thejas M Nair commented on HIVE-17606: -- reverted > Improve security for DB notification related APIs

[jira] [Commented] (HIVE-17606) Improve security for DB notification related APIs

2017-09-28 Thread Thejas M Nair (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185021#comment-16185021 ] Thejas M Nair commented on HIVE-17606: -- [~sershe] [~taoli-hwx] Looks like I had some partial changes

[jira] [Commented] (HIVE-17606) Improve security for DB notification related APIs

2017-09-28 Thread Tao Li (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184995#comment-16184995 ] Tao Li commented on HIVE-17606: --- [~sershe] I don't see how the change could cause the error since

[jira] [Commented] (HIVE-17606) Improve security for DB notification related APIs

2017-09-28 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184988#comment-16184988 ] Sergey Shelukhin commented on HIVE-17606: - This appears to break the build: {noformat} [ERROR]

[jira] [Commented] (HIVE-17606) Improve security for DB notification related APIs

2017-09-28 Thread Tao Li (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184900#comment-16184900 ] Tao Li commented on HIVE-17606: --- [~thejas] Am I supposed to make the wiki doc change? Thanks for the

[jira] [Commented] (HIVE-17606) Improve security for DB notification related APIs

2017-09-28 Thread Thejas M Nair (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184894#comment-16184894 ] Thejas M Nair commented on HIVE-17606: -- [~taoli-hwx] We should follow up with documentation change in

[jira] [Commented] (HIVE-17606) Improve security for DB notification related APIs

2017-09-28 Thread Tao Li (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184838#comment-16184838 ] Tao Li commented on HIVE-17606: --- Test result looks good. The failures don't seems related to the change. >

[jira] [Commented] (HIVE-17606) Improve security for DB notification related APIs

2017-09-28 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184827#comment-16184827 ] Hive QA commented on HIVE-17606: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-17606) Improve security for DB notification related APIs

2017-09-28 Thread Thejas M Nair (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184746#comment-16184746 ] Thejas M Nair commented on HIVE-17606: -- +1 > Improve security for DB notification related APIs >

[jira] [Commented] (HIVE-17606) Improve security for DB notification related APIs

2017-09-28 Thread Tao Li (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184674#comment-16184674 ] Tao Li commented on HIVE-17606: --- [~thejas] Correct. Actually I am fixing that now. > Improve security for

[jira] [Commented] (HIVE-17606) Improve security for DB notification related APIs

2017-09-28 Thread Thejas M Nair (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184668#comment-16184668 ] Thejas M Nair commented on HIVE-17606: -- {code} try { + rsp =

[jira] [Commented] (HIVE-17606) Improve security for DB notification related APIs

2017-09-28 Thread Tao Li (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184610#comment-16184610 ] Tao Li commented on HIVE-17606: --- [~thejas] Thanks for the comments. Regarding the test case, I was

[jira] [Commented] (HIVE-17606) Improve security for DB notification related APIs

2017-09-28 Thread Thejas M Nair (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184573#comment-16184573 ] Thejas M Nair commented on HIVE-17606: -- MetaStoreUtils.hasPermissionForDbNotificationCalls is

[jira] [Commented] (HIVE-17606) Improve security for DB notification related APIs

2017-09-28 Thread Thejas M Nair (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184569#comment-16184569 ] Thejas M Nair commented on HIVE-17606: -- I see one possible issue with the test case. If the "rsp =

[jira] [Commented] (HIVE-17606) Improve security for DB notification related APIs

2017-09-28 Thread Tao Li (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184476#comment-16184476 ] Tao Li commented on HIVE-17606: --- Test result looks good. > Improve security for DB notification related

[jira] [Commented] (HIVE-17606) Improve security for DB notification related APIs

2017-09-28 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184471#comment-16184471 ] Hive QA commented on HIVE-17606: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-17606) Improve security for DB notification related APIs

2017-09-27 Thread Lefty Leverenz (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16183695#comment-16183695 ] Lefty Leverenz commented on HIVE-17606: --- Thanks for fixing the parameter description. It looks

[jira] [Commented] (HIVE-17606) Improve security for DB notification related APIs

2017-09-27 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16183645#comment-16183645 ] Hive QA commented on HIVE-17606: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-17606) Improve security for DB notification related APIs

2017-09-27 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16183122#comment-16183122 ] Hive QA commented on HIVE-17606: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-17606) Improve security for DB notification related APIs

2017-09-27 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182742#comment-16182742 ] Hive QA commented on HIVE-17606: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-17606) Improve security for DB notification related APIs

2017-09-27 Thread Tao Li (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182189#comment-16182189 ] Tao Li commented on HIVE-17606: --- [~thejas], [~leftylev] Thanks for the comments. Just uploaded another

[jira] [Commented] (HIVE-17606) Improve security for DB notification related APIs

2017-09-26 Thread Lefty Leverenz (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182004#comment-16182004 ] Lefty Leverenz commented on HIVE-17606: --- Config review: The description of

[jira] [Commented] (HIVE-17606) Improve security for DB notification related APIs

2017-09-26 Thread Thejas M Nair (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181754#comment-16181754 ] Thejas M Nair commented on HIVE-17606: -- Can you also call the authorize method something more

[jira] [Commented] (HIVE-17606) Improve security for DB notification related APIs

2017-09-26 Thread Thejas M Nair (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181717#comment-16181717 ] Thejas M Nair commented on HIVE-17606: -- * Lets secure this out of the box -

[jira] [Commented] (HIVE-17606) Improve security for DB notification related APIs

2017-09-26 Thread Tao Li (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181607#comment-16181607 ] Tao Li commented on HIVE-17606: --- Test result looks good now. > Improve security for DB notification related

[jira] [Commented] (HIVE-17606) Improve security for DB notification related APIs

2017-09-26 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181603#comment-16181603 ] Hive QA commented on HIVE-17606: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-17606) Improve security for DB notification related APIs

2017-09-26 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-17606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16180631#comment-16180631 ] Hive QA commented on HIVE-17606: Here are the results of testing the latest attachment: