[jira] [Commented] (HIVE-18355) Add builder for metastore Thrift classes missed in the first pass - FunctionBuilder

[ https://issues.apache.org/jira/browse/HIVE-18355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324541#comment-16324541 ] Alan Gates commented on HIVE-18355: --- +1 > Add builder for metastore Thrift classes miss

[jira] [Commented] (HIVE-18355) Add builder for metastore Thrift classes missed in the first pass - FunctionBuilder

[ https://issues.apache.org/jira/browse/HIVE-18355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16319164#comment-16319164 ] Hive QA commented on HIVE-18355: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-18355) Add builder for metastore Thrift classes missed in the first pass - FunctionBuilder

[ https://issues.apache.org/jira/browse/HIVE-18355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16319059#comment-16319059 ] Hive QA commented on HIVE-18355: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || S

[jira] [Commented] (HIVE-18355) Add builder for metastore Thrift classes missed in the first pass - FunctionBuilder

[ https://issues.apache.org/jira/browse/HIVE-18355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317103#comment-16317103 ] Alan Gates commented on HIVE-18355: --- A couple of comments in the build method: # It shou

[jira] [Commented] (HIVE-18355) Add builder for metastore Thrift classes missed in the first pass - FunctionBuilder

[ https://issues.apache.org/jira/browse/HIVE-18355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16308322#comment-16308322 ] Peter Vary commented on HIVE-18355: --- The failures are not related. The checkstyle error

[jira] [Commented] (HIVE-18355) Add builder for metastore Thrift classes missed in the first pass - FunctionBuilder

[ https://issues.apache.org/jira/browse/HIVE-18355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16308170#comment-16308170 ] Hive QA commented on HIVE-18355: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-18355) Add builder for metastore Thrift classes missed in the first pass - FunctionBuilder

[ https://issues.apache.org/jira/browse/HIVE-18355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16308090#comment-16308090 ] Hive QA commented on HIVE-18355: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || S

[jira] [Commented] (HIVE-18355) Add builder for metastore Thrift classes missed in the first pass - FunctionBuilder

[ https://issues.apache.org/jira/browse/HIVE-18355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16308044#comment-16308044 ] Peter Vary commented on HIVE-18355: --- [~alangates]: Could you please review? Thanks, Pete