[jira] [Commented] (HIVE-18421) Vectorized execution handles overflows in a different manner than non-vectorized execution

2018-02-15 Thread Vihang Karajgaonkar (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-18421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16365817#comment-16365817 ] Vihang Karajgaonkar commented on HIVE-18421: Patch merged in the master branch

[jira] [Commented] (HIVE-18421) Vectorized execution handles overflows in a different manner than non-vectorized execution

2018-02-14 Thread Vihang Karajgaonkar (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-18421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364647#comment-16364647 ] Vihang Karajgaonkar commented on HIVE-18421: I would like to commit this patch

[jira] [Commented] (HIVE-18421) Vectorized execution handles overflows in a different manner than non-vectorized execution

2018-02-13 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-18421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362777#comment-16362777 ] Hive QA commented on HIVE-18421: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-18421) Vectorized execution handles overflows in a different manner than non-vectorized execution

2018-02-13 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-18421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362701#comment-16362701 ] Hive QA commented on HIVE-18421: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || S

[jira] [Commented] (HIVE-18421) Vectorized execution handles overflows in a different manner than non-vectorized execution

2018-02-12 Thread Vihang Karajgaonkar (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-18421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16361929#comment-16361929 ] Vihang Karajgaonkar commented on HIVE-18421: Hi [~gopalv] I added a couple of

[jira] [Commented] (HIVE-18421) Vectorized execution handles overflows in a different manner than non-vectorized execution

2018-02-09 Thread Aihua Xu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-18421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16358701#comment-16358701 ] Aihua Xu commented on HIVE-18421: - Originally I thought non-vectorization version was hand

[jira] [Commented] (HIVE-18421) Vectorized execution handles overflows in a different manner than non-vectorized execution

2018-02-08 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-18421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16357849#comment-16357849 ] Hive QA commented on HIVE-18421: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-18421) Vectorized execution handles overflows in a different manner than non-vectorized execution

2018-02-08 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-18421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16357816#comment-16357816 ] Hive QA commented on HIVE-18421: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || S

[jira] [Commented] (HIVE-18421) Vectorized execution handles overflows in a different manner than non-vectorized execution

2018-02-08 Thread Matt McCline (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-18421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16357733#comment-16357733 ] Matt McCline commented on HIVE-18421: - I briefly looked it over – I'm concentrating on

[jira] [Commented] (HIVE-18421) Vectorized execution handles overflows in a different manner than non-vectorized execution

2018-02-08 Thread Gopal V (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-18421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16357722#comment-16357722 ] Gopal V commented on HIVE-18421: The performance question was primarily about inserting th

[jira] [Commented] (HIVE-18421) Vectorized execution handles overflows in a different manner than non-vectorized execution

2018-02-08 Thread Vihang Karajgaonkar (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-18421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16357718#comment-16357718 ] Vihang Karajgaonkar commented on HIVE-18421: I can enable this config by defau

[jira] [Commented] (HIVE-18421) Vectorized execution handles overflows in a different manner than non-vectorized execution

2018-02-08 Thread Aihua Xu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-18421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16357392#comment-16357392 ] Aihua Xu commented on HIVE-18421: - Talked to [~vihangk1] offline and got better understand

[jira] [Commented] (HIVE-18421) Vectorized execution handles overflows in a different manner than non-vectorized execution

2018-02-07 Thread Aihua Xu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-18421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356455#comment-16356455 ] Aihua Xu commented on HIVE-18421: - [~vihangk1] Sorry for the late reply. I left comment in

[jira] [Commented] (HIVE-18421) Vectorized execution handles overflows in a different manner than non-vectorized execution

2018-02-07 Thread Vihang Karajgaonkar (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-18421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356213#comment-16356213 ] Vihang Karajgaonkar commented on HIVE-18421: [~mmccline] would you be able to

[jira] [Commented] (HIVE-18421) Vectorized execution handles overflows in a different manner than non-vectorized execution

2018-02-07 Thread Vihang Karajgaonkar (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-18421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356202#comment-16356202 ] Vihang Karajgaonkar commented on HIVE-18421: Okay, I finally figured out the p

[jira] [Commented] (HIVE-18421) Vectorized execution handles overflows in a different manner than non-vectorized execution

2018-02-07 Thread Vihang Karajgaonkar (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-18421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356118#comment-16356118 ] Vihang Karajgaonkar commented on HIVE-18421: vectorization_numeric_overflows.q

[jira] [Commented] (HIVE-18421) Vectorized execution handles overflows in a different manner than non-vectorized execution

2018-02-07 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-18421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355686#comment-16355686 ] Hive QA commented on HIVE-18421: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-18421) Vectorized execution handles overflows in a different manner than non-vectorized execution

2018-02-07 Thread Sahil Takiar (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-18421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355690#comment-16355690 ] Sahil Takiar commented on HIVE-18421: - +1 LGTM > Vectorized execution handles overflo

[jira] [Commented] (HIVE-18421) Vectorized execution handles overflows in a different manner than non-vectorized execution

2018-02-07 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-18421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355622#comment-16355622 ] Hive QA commented on HIVE-18421: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || S

[jira] [Commented] (HIVE-18421) Vectorized execution handles overflows in a different manner than non-vectorized execution

2018-02-06 Thread Vihang Karajgaonkar (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-18421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16354516#comment-16354516 ] Vihang Karajgaonkar commented on HIVE-18421: latest patch fixes TestCliDriver.

[jira] [Commented] (HIVE-18421) Vectorized execution handles overflows in a different manner than non-vectorized execution

2018-02-06 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-18421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16354168#comment-16354168 ] Hive QA commented on HIVE-18421: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-18421) Vectorized execution handles overflows in a different manner than non-vectorized execution

2018-02-06 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-18421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16354092#comment-16354092 ] Hive QA commented on HIVE-18421: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || S

[jira] [Commented] (HIVE-18421) Vectorized execution handles overflows in a different manner than non-vectorized execution

2018-02-06 Thread Vihang Karajgaonkar (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-18421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16353538#comment-16353538 ] Vihang Karajgaonkar commented on HIVE-18421: Fixed TestVectorMathFunctions Te

[jira] [Commented] (HIVE-18421) Vectorized execution handles overflows in a different manner than non-vectorized execution

2018-02-05 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-18421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16353327#comment-16353327 ] Hive QA commented on HIVE-18421: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-18421) Vectorized execution handles overflows in a different manner than non-vectorized execution

2018-02-05 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-18421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16353296#comment-16353296 ] Hive QA commented on HIVE-18421: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || S

[jira] [Commented] (HIVE-18421) Vectorized execution handles overflows in a different manner than non-vectorized execution

2018-02-05 Thread Vihang Karajgaonkar (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-18421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352918#comment-16352918 ] Vihang Karajgaonkar commented on HIVE-18421: latest patch should fix most of t

[jira] [Commented] (HIVE-18421) Vectorized execution handles overflows in a different manner than non-vectorized execution

2018-02-05 Thread Vihang Karajgaonkar (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-18421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352725#comment-16352725 ] Vihang Karajgaonkar commented on HIVE-18421: Copy pasting the test result from

[jira] [Commented] (HIVE-18421) Vectorized execution handles overflows in a different manner than non-vectorized execution

2018-02-04 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-18421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352019#comment-16352019 ] Hive QA commented on HIVE-18421: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || S

[jira] [Commented] (HIVE-18421) Vectorized execution handles overflows in a different manner than non-vectorized execution

2018-02-03 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-18421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351345#comment-16351345 ] Hive QA commented on HIVE-18421: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || S

[jira] [Commented] (HIVE-18421) Vectorized execution handles overflows in a different manner than non-vectorized execution

2018-02-02 Thread Vihang Karajgaonkar (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-18421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351216#comment-16351216 ] Vihang Karajgaonkar commented on HIVE-18421: adding reviewboard link > Vector

[jira] [Commented] (HIVE-18421) Vectorized execution handles overflows in a different manner than non-vectorized execution

2018-02-02 Thread Vihang Karajgaonkar (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-18421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351212#comment-16351212 ] Vihang Karajgaonkar commented on HIVE-18421: Updated the Jira description appr