[
https://issues.apache.org/jira/browse/HIVE-18629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16483126#comment-16483126
]
Vihang Karajgaonkar commented on HIVE-18629:
Oh I see. In that case can we close this issue?
[
https://issues.apache.org/jira/browse/HIVE-18629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16481335#comment-16481335
]
Sergey Shelukhin commented on HIVE-18629:
-
See the discussion above. [~mmccline] doesn't like it
[
https://issues.apache.org/jira/browse/HIVE-18629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16481277#comment-16481277
]
Vihang Karajgaonkar commented on HIVE-18629:
[~sershe] Was this not merged for a reason?
>
[
https://issues.apache.org/jira/browse/HIVE-18629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370476#comment-16370476
]
Sergey Shelukhin commented on HIVE-18629:
-
[~mmccline] ping?
> copyValues in BytesColumnVector
[
https://issues.apache.org/jira/browse/HIVE-18629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361687#comment-16361687
]
Hive QA commented on HIVE-18629:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-18629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361643#comment-16361643
]
Hive QA commented on HIVE-18629:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-18629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361527#comment-16361527
]
Sergey Shelukhin commented on HIVE-18629:
-
[~mmccline] this patch as is will either already set
[
https://issues.apache.org/jira/browse/HIVE-18629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361518#comment-16361518
]
Matt McCline commented on HIVE-18629:
-
I think the patch is still wrong.
1) Until HIVE-18622 is
[
https://issues.apache.org/jira/browse/HIVE-18629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361446#comment-16361446
]
Sergey Shelukhin commented on HIVE-18629:
-
Added an assertion after discussing with [~mmccline]
[
https://issues.apache.org/jira/browse/HIVE-18629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16358065#comment-16358065
]
Hive QA commented on HIVE-18629:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-18629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16358032#comment-16358032
]
Hive QA commented on HIVE-18629:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-18629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356278#comment-16356278
]
Hive QA commented on HIVE-18629:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-18629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356235#comment-16356235
]
Sergey Shelukhin commented on HIVE-18629:
-
Updated to also handle isRepeating case.
[~mmccline] I
[
https://issues.apache.org/jira/browse/HIVE-18629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356232#comment-16356232
]
Hive QA commented on HIVE-18629:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-18629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356214#comment-16356214
]
Vihang Karajgaonkar commented on HIVE-18629:
Patch looks good to me. Can we include a test
[
https://issues.apache.org/jira/browse/HIVE-18629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356009#comment-16356009
]
Sergey Shelukhin commented on HIVE-18629:
-
No new test failures.
cc [~vihangk1] [~mmccline]
>
[
https://issues.apache.org/jira/browse/HIVE-18629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354914#comment-16354914
]
Hive QA commented on HIVE-18629:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-18629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354888#comment-16354888
]
Hive QA commented on HIVE-18629:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-18629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354880#comment-16354880
]
Sergey Shelukhin commented on HIVE-18629:
-
[~vihangk1] updated the patch.
> copyValues in
[
https://issues.apache.org/jira/browse/HIVE-18629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354609#comment-16354609
]
Sergey Shelukhin commented on HIVE-18629:
-
Sorry, yeah, I mixed it up when changing the ifs
[
https://issues.apache.org/jira/browse/HIVE-18629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354585#comment-16354585
]
Vihang Karajgaonkar commented on HIVE-18629:
Hi [~sershe] I took a quick look at the attached
[
https://issues.apache.org/jira/browse/HIVE-18629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354350#comment-16354350
]
Sergey Shelukhin commented on HIVE-18629:
-
[~vihangk1] no that makes sense, they might be related.
[
https://issues.apache.org/jira/browse/HIVE-18629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353493#comment-16353493
]
Vihang Karajgaonkar commented on HIVE-18629:
oops didn't see the comment above. I will let
[
https://issues.apache.org/jira/browse/HIVE-18629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353490#comment-16353490
]
Vihang Karajgaonkar commented on HIVE-18629:
possibly related to HIVE-18622?
> copyValues in
[
https://issues.apache.org/jira/browse/HIVE-18629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353237#comment-16353237
]
Sergey Shelukhin commented on HIVE-18629:
-
[~mmccline] does this patch make sense?
> copyValues
25 matches
Mail list logo
