[jira] [Commented] (HIVE-19041) Thrift deserialization of Partition objects should intern fields

[ https://issues.apache.org/jira/browse/HIVE-19041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16484597#comment-16484597 ] Vineet Garg commented on HIVE-19041: Replaced fix version 3.1.0 with 4.0.0 since maste

[jira] [Commented] (HIVE-19041) Thrift deserialization of Partition objects should intern fields

[ https://issues.apache.org/jira/browse/HIVE-19041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16472418#comment-16472418 ] Vihang Karajgaonkar commented on HIVE-19041: Looked more carefully and realize

[jira] [Commented] (HIVE-19041) Thrift deserialization of Partition objects should intern fields

[ https://issues.apache.org/jira/browse/HIVE-19041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16472391#comment-16472391 ] Vihang Karajgaonkar commented on HIVE-19041: not sure why the patch couldn't b

[jira] [Commented] (HIVE-19041) Thrift deserialization of Partition objects should intern fields

[ https://issues.apache.org/jira/browse/HIVE-19041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16471921#comment-16471921 ] Sahil Takiar commented on HIVE-19041: - +1 latest patch LGTM, although looks like it ne

[jira] [Commented] (HIVE-19041) Thrift deserialization of Partition objects should intern fields

[ https://issues.apache.org/jira/browse/HIVE-19041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16471832#comment-16471832 ] Hive QA commented on HIVE-19041: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-19041) Thrift deserialization of Partition objects should intern fields

[ https://issues.apache.org/jira/browse/HIVE-19041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470954#comment-16470954 ] Misha Dmitriev commented on HIVE-19041: --- Thank you for looking into the details, [~v

[jira] [Commented] (HIVE-19041) Thrift deserialization of Partition objects should intern fields

[ https://issues.apache.org/jira/browse/HIVE-19041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470664#comment-16470664 ] Vihang Karajgaonkar commented on HIVE-19041: Hi [~mi...@cloudera.com] Thanks f

[jira] [Commented] (HIVE-19041) Thrift deserialization of Partition objects should intern fields

[ https://issues.apache.org/jira/browse/HIVE-19041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469733#comment-16469733 ] Misha Dmitriev commented on HIVE-19041: --- Agree - in our internal heap dump analysis,

[jira] [Commented] (HIVE-19041) Thrift deserialization of Partition objects should intern fields

[ https://issues.apache.org/jira/browse/HIVE-19041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469680#comment-16469680 ] Vihang Karajgaonkar commented on HIVE-19041: Talked with [~stakiar] offline. R

[jira] [Commented] (HIVE-19041) Thrift deserialization of Partition objects should intern fields

[ https://issues.apache.org/jira/browse/HIVE-19041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16466509#comment-16466509 ] Vihang Karajgaonkar commented on HIVE-19041: Tests failures are unrelated. >

[jira] [Commented] (HIVE-19041) Thrift deserialization of Partition objects should intern fields

[ https://issues.apache.org/jira/browse/HIVE-19041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464982#comment-16464982 ] Hive QA commented on HIVE-19041: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-19041) Thrift deserialization of Partition objects should intern fields

[ https://issues.apache.org/jira/browse/HIVE-19041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464972#comment-16464972 ] Hive QA commented on HIVE-19041: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HIVE-19041) Thrift deserialization of Partition objects should intern fields

[ https://issues.apache.org/jira/browse/HIVE-19041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464550#comment-16464550 ] Vihang Karajgaonkar commented on HIVE-19041: v3 of the patch includes addition

[jira] [Commented] (HIVE-19041) Thrift deserialization of Partition objects should intern fields

[ https://issues.apache.org/jira/browse/HIVE-19041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464418#comment-16464418 ] Hive QA commented on HIVE-19041: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-19041) Thrift deserialization of Partition objects should intern fields

[ https://issues.apache.org/jira/browse/HIVE-19041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464356#comment-16464356 ] Hive QA commented on HIVE-19041: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HIVE-19041) Thrift deserialization of Partition objects should intern fields

[ https://issues.apache.org/jira/browse/HIVE-19041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464296#comment-16464296 ] Vihang Karajgaonkar commented on HIVE-19041: just realized {{AddPartitionsRequ

[jira] [Commented] (HIVE-19041) Thrift deserialization of Partition objects should intern fields

[ https://issues.apache.org/jira/browse/HIVE-19041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16463269#comment-16463269 ] Sahil Takiar commented on HIVE-19041: - Think you missed {{bucketCols}} in {{StorageDes

[jira] [Commented] (HIVE-19041) Thrift deserialization of Partition objects should intern fields

[ https://issues.apache.org/jira/browse/HIVE-19041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16463256#comment-16463256 ] Vihang Karajgaonkar commented on HIVE-19041: Attaching second patch which addr

[jira] [Commented] (HIVE-19041) Thrift deserialization of Partition objects should intern fields

[ https://issues.apache.org/jira/browse/HIVE-19041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16463254#comment-16463254 ] Vihang Karajgaonkar commented on HIVE-19041: {{FieldSchema.comment}} is alread

[jira] [Commented] (HIVE-19041) Thrift deserialization of Partition objects should intern fields

[ https://issues.apache.org/jira/browse/HIVE-19041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16463236#comment-16463236 ] Misha Dmitriev commented on HIVE-19041: --- [~gopalv] yes, since JDK 1.7 built-in strin

[jira] [Commented] (HIVE-19041) Thrift deserialization of Partition objects should intern fields

[ https://issues.apache.org/jira/browse/HIVE-19041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16463235#comment-16463235 ] Misha Dmitriev commented on HIVE-19041: --- Yes, all interned strings are kept in the J

[jira] [Commented] (HIVE-19041) Thrift deserialization of Partition objects should intern fields

[ https://issues.apache.org/jira/browse/HIVE-19041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16463233#comment-16463233 ] Gopal V commented on HIVE-19041: Hadoop comes with a weak-interner, which is used by Tez.

[jira] [Commented] (HIVE-19041) Thrift deserialization of Partition objects should intern fields

[ https://issues.apache.org/jira/browse/HIVE-19041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16463221#comment-16463221 ] Sahil Takiar commented on HIVE-19041: - I guess if you have a comment for the partition

[jira] [Commented] (HIVE-19041) Thrift deserialization of Partition objects should intern fields

[ https://issues.apache.org/jira/browse/HIVE-19041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16463109#comment-16463109 ] Vihang Karajgaonkar commented on HIVE-19041: The test which did not show comme

[jira] [Commented] (HIVE-19041) Thrift deserialization of Partition objects should intern fields

[ https://issues.apache.org/jira/browse/HIVE-19041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16462886#comment-16462886 ] Misha Dmitriev commented on HIVE-19041: --- [~vihangk1] does the jxray report show that

[jira] [Commented] (HIVE-19041) Thrift deserialization of Partition objects should intern fields

[ https://issues.apache.org/jira/browse/HIVE-19041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16462877#comment-16462877 ] Vihang Karajgaonkar commented on HIVE-19041: Thanks [~stakiar] for taking a lo

[jira] [Commented] (HIVE-19041) Thrift deserialization of Partition objects should intern fields

[ https://issues.apache.org/jira/browse/HIVE-19041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16462854#comment-16462854 ] Sahil Takiar commented on HIVE-19041: - Few comments: * In {{Partition}} doesn't look

[jira] [Commented] (HIVE-19041) Thrift deserialization of Partition objects should intern fields

[ https://issues.apache.org/jira/browse/HIVE-19041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16462824#comment-16462824 ] Vihang Karajgaonkar commented on HIVE-19041: Attaching the first version of th

[jira] [Commented] (HIVE-19041) Thrift deserialization of Partition objects should intern fields

[ https://issues.apache.org/jira/browse/HIVE-19041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16462573#comment-16462573 ] Sahil Takiar commented on HIVE-19041: - Yeah, right now its something like this: {code

[jira] [Commented] (HIVE-19041) Thrift deserialization of Partition objects should intern fields

[ https://issues.apache.org/jira/browse/HIVE-19041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16462568#comment-16462568 ] Vihang Karajgaonkar commented on HIVE-19041: I found that the issue only durin

[jira] [Commented] (HIVE-19041) Thrift deserialization of Partition objects should intern fields

[ https://issues.apache.org/jira/browse/HIVE-19041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16462473#comment-16462473 ] Sahil Takiar commented on HIVE-19041: - I think this applies to almost every Thrift cla