[jira] [Commented] (HIVE-19059) Support DEFAULT keyword with INSERT and UPDATE

2018-03-31 Thread Jesus Camacho Rodriguez (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-19059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421411#comment-16421411 ] Jesus Camacho Rodriguez commented on HIVE-19059: +1 > Support DEFAULT key

[jira] [Commented] (HIVE-19059) Support DEFAULT keyword with INSERT and UPDATE

2018-03-31 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-19059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421278#comment-16421278 ] Hive QA commented on HIVE-19059: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-19059) Support DEFAULT keyword with INSERT and UPDATE

2018-03-31 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-19059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421259#comment-16421259 ] Hive QA commented on HIVE-19059: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || S

[jira] [Commented] (HIVE-19059) Support DEFAULT keyword with INSERT and UPDATE

2018-03-30 Thread Vineet Garg (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-19059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421183#comment-16421183 ] Vineet Garg commented on HIVE-19059: Test failures are unrelated. Latest patch address

[jira] [Commented] (HIVE-19059) Support DEFAULT keyword with INSERT and UPDATE

2018-03-30 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-19059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420823#comment-16420823 ] Hive QA commented on HIVE-19059: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-19059) Support DEFAULT keyword with INSERT and UPDATE

2018-03-30 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-19059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420753#comment-16420753 ] Hive QA commented on HIVE-19059: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || S

[jira] [Commented] (HIVE-19059) Support DEFAULT keyword with INSERT and UPDATE

2018-03-29 Thread Vineet Garg (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-19059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420148#comment-16420148 ] Vineet Garg commented on HIVE-19059: [~jcamachorodriguez] Thanks for reviewing. I have

[jira] [Commented] (HIVE-19059) Support DEFAULT keyword with INSERT and UPDATE

2018-03-28 Thread Vineet Garg (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-19059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16418267#comment-16418267 ] Vineet Garg commented on HIVE-19059: [~jcamachorodriguez] Can you take a look? Review

[jira] [Commented] (HIVE-19059) Support DEFAULT keyword with INSERT and UPDATE

2018-03-28 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-19059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16417142#comment-16417142 ] Hive QA commented on HIVE-19059: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-19059) Support DEFAULT keyword with INSERT and UPDATE

2018-03-28 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-19059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16417089#comment-16417089 ] Hive QA commented on HIVE-19059: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || S

[jira] [Commented] (HIVE-19059) Support DEFAULT keyword with INSERT and UPDATE

2018-03-27 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-19059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416866#comment-16416866 ] Hive QA commented on HIVE-19059: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-19059) Support DEFAULT keyword with INSERT and UPDATE

2018-03-27 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-19059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416823#comment-16416823 ] Hive QA commented on HIVE-19059: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || S

[jira] [Commented] (HIVE-19059) Support DEFAULT keyword with INSERT and UPDATE

2018-03-26 Thread Vineet Garg (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-19059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16414863#comment-16414863 ] Vineet Garg commented on HIVE-19059: Thanks for the comment [~pxiong] :). That grammar

[jira] [Commented] (HIVE-19059) Support DEFAULT keyword with INSERT and UPDATE

2018-03-26 Thread Pengcheng Xiong (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-19059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16414858#comment-16414858 ] Pengcheng Xiong commented on HIVE-19059: " |-> \{$expr.tree.getText() == "default"

[jira] [Commented] (HIVE-19059) Support DEFAULT keyword with INSERT and UPDATE

2018-03-26 Thread Vineet Garg (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-19059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16414834#comment-16414834 ] Vineet Garg commented on HIVE-19059: First patch provide support for INSERT and UPDATE