[jira] [Commented] (HIVE-19493) VectorUDFDateDiffColCol copySelected does not handle nulls correctly

[ https://issues.apache.org/jira/browse/HIVE-19493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470964#comment-16470964 ] Vihang Karajgaonkar commented on HIVE-19493: cc: [~mmccline] > VectorUDFDateD

[jira] [Commented] (HIVE-19493) VectorUDFDateDiffColCol copySelected does not handle nulls correctly

[ https://issues.apache.org/jira/browse/HIVE-19493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16471198#comment-16471198 ] Vihang Karajgaonkar commented on HIVE-19493: adding review board link. [~mmccl

[jira] [Commented] (HIVE-19493) VectorUDFDateDiffColCol copySelected does not handle nulls correctly

[ https://issues.apache.org/jira/browse/HIVE-19493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16471281#comment-16471281 ] Matt McCline commented on HIVE-19493: - [~vihangk1] thank you for catching this. I've s

[jira] [Commented] (HIVE-19493) VectorUDFDateDiffColCol copySelected does not handle nulls correctly

[ https://issues.apache.org/jira/browse/HIVE-19493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16471354#comment-16471354 ] Vihang Karajgaonkar commented on HIVE-19493: Thanks [~mmccline] for the review

[jira] [Commented] (HIVE-19493) VectorUDFDateDiffColCol copySelected does not handle nulls correctly

[ https://issues.apache.org/jira/browse/HIVE-19493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16473047#comment-16473047 ] Hive QA commented on HIVE-19493: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HIVE-19493) VectorUDFDateDiffColCol copySelected does not handle nulls correctly

[ https://issues.apache.org/jira/browse/HIVE-19493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16473072#comment-16473072 ] Hive QA commented on HIVE-19493: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-19493) VectorUDFDateDiffColCol copySelected does not handle nulls correctly

[ https://issues.apache.org/jira/browse/HIVE-19493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16473666#comment-16473666 ] Matt McCline commented on HIVE-19493: - I'm creating a new TestVectorDateAddSub UT that

[jira] [Commented] (HIVE-19493) VectorUDFDateDiffColCol copySelected does not handle nulls correctly

[ https://issues.apache.org/jira/browse/HIVE-19493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16474438#comment-16474438 ] Matt McCline commented on HIVE-19493: - I wrote a new UT called TestVectorDateDiff (not

[jira] [Commented] (HIVE-19493) VectorUDFDateDiffColCol copySelected does not handle nulls correctly

[ https://issues.apache.org/jira/browse/HIVE-19493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16495501#comment-16495501 ] Vihang Karajgaonkar commented on HIVE-19493: Hi [~mmccline] I don't see {{Tes

[jira] [Commented] (HIVE-19493) VectorUDFDateDiffColCol copySelected does not handle nulls correctly

[ https://issues.apache.org/jira/browse/HIVE-19493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16495561#comment-16495561 ] Vihang Karajgaonkar commented on HIVE-19493: HIVE-19529 introduces a test cas

[jira] [Commented] (HIVE-19493) VectorUDFDateDiffColCol copySelected does not handle nulls correctly

[ https://issues.apache.org/jira/browse/HIVE-19493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496096#comment-16496096 ] Matt McCline commented on HIVE-19493: - [~vihangk1] I'm hoping HIVE-19529 will go in t

[jira] [Commented] (HIVE-19493) VectorUDFDateDiffColCol copySelected does not handle nulls correctly

[ https://issues.apache.org/jira/browse/HIVE-19493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496798#comment-16496798 ] Matt McCline commented on HIVE-19493: - Now that HIVE-19529 has committed on master, r

[jira] [Commented] (HIVE-19493) VectorUDFDateDiffColCol copySelected does not handle nulls correctly

[ https://issues.apache.org/jira/browse/HIVE-19493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496800#comment-16496800 ] Vihang Karajgaonkar commented on HIVE-19493: Thanks [~mmccline] I will keep a

[jira] [Commented] (HIVE-19493) VectorUDFDateDiffColCol copySelected does not handle nulls correctly

[ https://issues.apache.org/jira/browse/HIVE-19493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16499344#comment-16499344 ] Hive QA commented on HIVE-19493: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HIVE-19493) VectorUDFDateDiffColCol copySelected does not handle nulls correctly

[ https://issues.apache.org/jira/browse/HIVE-19493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16499348#comment-16499348 ] Hive QA commented on HIVE-19493: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-19493) VectorUDFDateDiffColCol copySelected does not handle nulls correctly

[ https://issues.apache.org/jira/browse/HIVE-19493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16499368#comment-16499368 ] Matt McCline commented on HIVE-19493: - +1 LGTM. > VectorUDFDateDiffColCol copySelect

[jira] [Commented] (HIVE-19493) VectorUDFDateDiffColCol copySelected does not handle nulls correctly

[ https://issues.apache.org/jira/browse/HIVE-19493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16499372#comment-16499372 ] Matt McCline commented on HIVE-19493: - Committed to branch-3 > VectorUDFDateDiffColC

[jira] [Commented] (HIVE-19493) VectorUDFDateDiffColCol copySelected does not handle nulls correctly

[ https://issues.apache.org/jira/browse/HIVE-19493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16499371#comment-16499371 ] Matt McCline commented on HIVE-19493: - Not a big enough change to warrant running Hiv

[jira] [Commented] (HIVE-19493) VectorUDFDateDiffColCol copySelected does not handle nulls correctly

[ https://issues.apache.org/jira/browse/HIVE-19493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16499370#comment-16499370 ] Matt McCline commented on HIVE-19493: - Committed to master. > VectorUDFDateDiffColCo

[jira] [Commented] (HIVE-19493) VectorUDFDateDiffColCol copySelected does not handle nulls correctly

[ https://issues.apache.org/jira/browse/HIVE-19493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16500591#comment-16500591 ] Vihang Karajgaonkar commented on HIVE-19493: Thanks [~mmccline] for the revie

[jira] [Commented] (HIVE-19493) VectorUDFDateDiffColCol copySelected does not handle nulls correctly

[ https://issues.apache.org/jira/browse/HIVE-19493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16502572#comment-16502572 ] Hive QA commented on HIVE-19493: Here are the results of testing the latest attachment: