[jira] [Commented] (HIVE-19937) Intern fields in MapWork on deserialization

2018-08-03 Thread Vihang Karajgaonkar (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-19937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568535#comment-16568535 ] Vihang Karajgaonkar commented on HIVE-19937: HI [~stakiar] Sorry for the delay in responding.

[jira] [Commented] (HIVE-19937) Intern fields in MapWork on deserialization

2018-08-02 Thread Sahil Takiar (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-19937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567402#comment-16567402 ] Sahil Takiar commented on HIVE-19937: - Ping [~vihangk1] > Intern fields in MapWork on

[jira] [Commented] (HIVE-19937) Intern fields in MapWork on deserialization

2018-07-24 Thread Sahil Takiar (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-19937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554477#comment-16554477 ] Sahil Takiar commented on HIVE-19937: - [~vihangk1] could you take a look? > Intern fields in MapWork

[jira] [Commented] (HIVE-19937) Intern fields in MapWork on deserialization

2018-07-23 Thread Sahil Takiar (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-19937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553538#comment-16553538 ] Sahil Takiar commented on HIVE-19937: - Thanks Misha, yes I will keep this in mind. I don't think this

[jira] [Commented] (HIVE-19937) Intern fields in MapWork on deserialization

2018-07-23 Thread Misha Dmitriev (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-19937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553279#comment-16553279 ] Misha Dmitriev commented on HIVE-19937: --- The last patch looks good to me. The only slight concern

[jira] [Commented] (HIVE-19937) Intern fields in MapWork on deserialization

2018-07-22 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-19937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552113#comment-16552113 ] Hive QA commented on HIVE-19937: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-19937) Intern fields in MapWork on deserialization

2018-07-22 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-19937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552067#comment-16552067 ] Hive QA commented on HIVE-19937: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-19937) Intern fields in MapWork on deserialization

2018-07-20 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-19937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16550341#comment-16550341 ] Hive QA commented on HIVE-19937: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-19937) Intern fields in MapWork on deserialization

2018-07-20 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-19937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16550340#comment-16550340 ] Hive QA commented on HIVE-19937: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-19937) Intern fields in MapWork on deserialization

2018-07-20 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-19937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16550312#comment-16550312 ] Hive QA commented on HIVE-19937: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-19937) Intern fields in MapWork on deserialization

2018-07-19 Thread Misha Dmitriev (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-19937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549768#comment-16549768 ] Misha Dmitriev commented on HIVE-19937: --- +1 One small comment: instead of {{this.baseFileName =

[jira] [Commented] (HIVE-19937) Intern fields in MapWork on deserialization

2018-07-19 Thread Sahil Takiar (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-19937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549704#comment-16549704 ] Sahil Takiar commented on HIVE-19937: - The overheads probably won't grow in proportion to the heap,

[jira] [Commented] (HIVE-19937) Intern fields in MapWork on deserialization

2018-07-19 Thread Misha Dmitriev (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-19937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549667#comment-16549667 ] Misha Dmitriev commented on HIVE-19937: --- Thank you for publishing the updated jxray report,

[jira] [Commented] (HIVE-19937) Intern fields in MapWork on deserialization

2018-07-19 Thread Sahil Takiar (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-19937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549601#comment-16549601 ] Sahil Takiar commented on HIVE-19937: - Attached an jxray report after applying the patch on a cluster