[jira] [Commented] (HIVE-20044) Arrow Serde should pad char values and handle empty strings correctly

2018-09-02 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16601767#comment-16601767 ] Hive QA commented on HIVE-20044: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-20044) Arrow Serde should pad char values and handle empty strings correctly

2018-09-02 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16601752#comment-16601752 ] Hive QA commented on HIVE-20044: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HIVE-20044) Arrow Serde should pad char values and handle empty strings correctly

2018-08-07 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16572526#comment-16572526 ] Hive QA commented on HIVE-20044: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-20044) Arrow Serde should pad char values and handle empty strings correctly

2018-08-07 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16572516#comment-16572516 ] Hive QA commented on HIVE-20044: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HIVE-20044) Arrow Serde should pad char values and handle empty strings correctly

2018-08-07 Thread Matt McCline (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16572470#comment-16572470 ] Matt McCline commented on HIVE-20044: - Ok, I looked at the newest changes (patch #3)

[jira] [Commented] (HIVE-20044) Arrow Serde should pad char values and handle empty strings correctly

2018-08-07 Thread Eric Wohlstadter (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16572363#comment-16572363 ] Eric Wohlstadter commented on HIVE-20044: - [~mmccline] [~teddy.choi] Updated the

[jira] [Commented] (HIVE-20044) Arrow Serde should pad char values and handle empty strings correctly

2018-08-06 Thread Matt McCline (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16570849#comment-16570849 ] Matt McCline commented on HIVE-20044: - +1 re-review LGTM > Arrow Serde should pad ch

[jira] [Commented] (HIVE-20044) Arrow Serde should pad char values and handle empty strings correctly

2018-08-03 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568070#comment-16568070 ] Hive QA commented on HIVE-20044: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-20044) Arrow Serde should pad char values and handle empty strings correctly

2018-08-03 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568033#comment-16568033 ] Hive QA commented on HIVE-20044: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HIVE-20044) Arrow Serde should pad char values and handle empty strings correctly

2018-08-03 Thread Teddy Choi (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16567905#comment-16567905 ] Teddy Choi commented on HIVE-20044: --- [~mmccline], I added a variation of StringExpr.pad

[jira] [Commented] (HIVE-20044) Arrow Serde should pad char values and handle empty strings correctly

2018-07-31 Thread Matt McCline (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564539#comment-16564539 ] Matt McCline commented on HIVE-20044: - [~teddy.choi] [~ewohlstadter] Second thoughts.

[jira] [Commented] (HIVE-20044) Arrow Serde should pad char values and handle empty strings correctly

2018-07-30 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563132#comment-16563132 ] Hive QA commented on HIVE-20044: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-20044) Arrow Serde should pad char values and handle empty strings correctly

2018-07-30 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563113#comment-16563113 ] Hive QA commented on HIVE-20044: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HIVE-20044) Arrow Serde should pad char values and handle empty strings correctly

2018-07-19 Thread Eric Wohlstadter (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16549934#comment-16549934 ] Eric Wohlstadter commented on HIVE-20044: - [~teddy.choi] Looks like you should k

[jira] [Commented] (HIVE-20044) Arrow Serde should pad char values and handle empty strings correctly

2018-07-11 Thread Matt McCline (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539779#comment-16539779 ] Matt McCline commented on HIVE-20044: - +1 LGTM tests pending. > Arrow Serde should p

[jira] [Commented] (HIVE-20044) Arrow Serde should pad char values and handle empty strings correctly

2018-07-10 Thread Teddy Choi (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539396#comment-16539396 ] Teddy Choi commented on HIVE-20044: --- Could you review this please, [~mmccline]? > Arro

[jira] [Commented] (HIVE-20044) Arrow Serde should pad char values and handle empty strings correctly

2018-07-10 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16538705#comment-16538705 ] Hive QA commented on HIVE-20044: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-20044) Arrow Serde should pad char values and handle empty strings correctly

2018-07-10 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16538635#comment-16538635 ] Hive QA commented on HIVE-20044: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HIVE-20044) Arrow Serde should pad char values and handle empty strings correctly

2018-07-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16538560#comment-16538560 ] ASF GitHub Bot commented on HIVE-20044: --- GitHub user pudidic opened a pull request:

[jira] [Commented] (HIVE-20044) Arrow Serde should pad char values and handle empty strings correctly

2018-07-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16538521#comment-16538521 ] ASF GitHub Bot commented on HIVE-20044: --- GitHub user pudidic opened a pull request: