[
https://issues.apache.org/jira/browse/HIVE-21264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788844#comment-16788844
]
Hive QA commented on HIVE-21264:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-21264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788838#comment-16788838
]
Hive QA commented on HIVE-21264:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-21264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788613#comment-16788613
]
Hive QA commented on HIVE-21264:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-21264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788593#comment-16788593
]
Hive QA commented on HIVE-21264:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-21264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788480#comment-16788480
]
David Mollitor commented on HIVE-21264:
---
[~gopalv] Thanks! Ya, doing this way saves a bunch of
[
https://issues.apache.org/jira/browse/HIVE-21264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788478#comment-16788478
]
Gopal V commented on HIVE-21264:
LGTM - +1
> Improvements Around CharTypeInfo
>
[
https://issues.apache.org/jira/browse/HIVE-21264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788471#comment-16788471
]
Gopal V commented on HIVE-21264:
bq. There is no need to do this check explicitly in the child classes.
[
https://issues.apache.org/jira/browse/HIVE-21264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788220#comment-16788220
]
Hive QA commented on HIVE-21264:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-21264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788157#comment-16788157
]
Hive QA commented on HIVE-21264:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-21264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16787926#comment-16787926
]
Hive QA commented on HIVE-21264:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-21264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16787880#comment-16787880
]
Hive QA commented on HIVE-21264:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-21264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16787443#comment-16787443
]
Hive QA commented on HIVE-21264:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-21264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16787389#comment-16787389
]
Hive QA commented on HIVE-21264:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-21264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16787019#comment-16787019
]
David Mollitor commented on HIVE-21264:
---
[~gopalv] Thank you so much for the review.
If you prefer
[
https://issues.apache.org/jira/browse/HIVE-21264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786354#comment-16786354
]
Gopal V commented on HIVE-21264:
[~belugabehr]: I don't think is correct because varchar(10) != char(10).
[
https://issues.apache.org/jira/browse/HIVE-21264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774111#comment-16774111
]
BELUGA BEHR commented on HIVE-21264:
[~ngangam] [~pvary] Please review :)
> Improvements Around
[
https://issues.apache.org/jira/browse/HIVE-21264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767955#comment-16767955
]
Hive QA commented on HIVE-21264:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-21264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767929#comment-16767929
]
Hive QA commented on HIVE-21264:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-21264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767407#comment-16767407
]
Hive QA commented on HIVE-21264:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-21264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767380#comment-16767380
]
Hive QA commented on HIVE-21264:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
20 matches
Mail list logo
