[jira] [Commented] (HIVE-21851) FireEventResponse should include event id when available

2020-03-31 Thread Vihang Karajgaonkar (Jira)
[ https://issues.apache.org/jira/browse/HIVE-21851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17071554#comment-17071554 ] Vihang Karajgaonkar commented on HIVE-21851: Attached the branch-3 patch. >

[jira] [Commented] (HIVE-21851) FireEventResponse should include event id when available

2020-03-12 Thread Vihang Karajgaonkar (Jira)
[ https://issues.apache.org/jira/browse/HIVE-21851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058276#comment-17058276 ] Vihang Karajgaonkar commented on HIVE-21851: Patch merged into master. I will attach a

[jira] [Commented] (HIVE-21851) FireEventResponse should include event id when available

2020-03-10 Thread Naveen Gangam (Jira)
[ https://issues.apache.org/jira/browse/HIVE-21851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17055947#comment-17055947 ] Naveen Gangam commented on HIVE-21851: -- Latest patch looks good to me. +1 for me. Thanks [~vihangk1]

[jira] [Commented] (HIVE-21851) FireEventResponse should include event id when available

2020-03-06 Thread Hive QA (Jira)
[ https://issues.apache.org/jira/browse/HIVE-21851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17053835#comment-17053835 ] Hive QA commented on HIVE-21851: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-21851) FireEventResponse should include event id when available

2020-03-06 Thread Hive QA (Jira)
[ https://issues.apache.org/jira/browse/HIVE-21851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17053827#comment-17053827 ] Hive QA commented on HIVE-21851: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-21851) FireEventResponse should include event id when available

2020-03-05 Thread Vihang Karajgaonkar (Jira)
[ https://issues.apache.org/jira/browse/HIVE-21851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052546#comment-17052546 ] Vihang Karajgaonkar commented on HIVE-21851: Reattaching the patch. > FireEventResponse

[jira] [Commented] (HIVE-21851) FireEventResponse should include event id when available

2020-03-03 Thread Hive QA (Jira)
[ https://issues.apache.org/jira/browse/HIVE-21851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17050746#comment-17050746 ] Hive QA commented on HIVE-21851: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-21851) FireEventResponse should include event id when available

2020-03-03 Thread Hive QA (Jira)
[ https://issues.apache.org/jira/browse/HIVE-21851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17050720#comment-17050720 ] Hive QA commented on HIVE-21851: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-21851) FireEventResponse should include event id when available

2020-03-03 Thread Vihang Karajgaonkar (Jira)
[ https://issues.apache.org/jira/browse/HIVE-21851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17050508#comment-17050508 ] Vihang Karajgaonkar commented on HIVE-21851: I changed the requiredness of the field to

[jira] [Commented] (HIVE-21851) FireEventResponse should include event id when available

2020-02-21 Thread Hive QA (Jira)
[ https://issues.apache.org/jira/browse/HIVE-21851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17042417#comment-17042417 ] Hive QA commented on HIVE-21851: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-21851) FireEventResponse should include event id when available

2020-02-21 Thread Hive QA (Jira)
[ https://issues.apache.org/jira/browse/HIVE-21851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17042389#comment-17042389 ] Hive QA commented on HIVE-21851: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-21851) FireEventResponse should include event id when available

2020-02-21 Thread Vihang Karajgaonkar (Jira)
[ https://issues.apache.org/jira/browse/HIVE-21851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17042320#comment-17042320 ] Vihang Karajgaonkar commented on HIVE-21851: Reattached the patch again. The test failures

[jira] [Commented] (HIVE-21851) FireEventResponse should include event id when available

2019-11-28 Thread Hive QA (Jira)
[ https://issues.apache.org/jira/browse/HIVE-21851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984527#comment-16984527 ] Hive QA commented on HIVE-21851: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-21851) FireEventResponse should include event id when available

2019-11-28 Thread Hive QA (Jira)
[ https://issues.apache.org/jira/browse/HIVE-21851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984503#comment-16984503 ] Hive QA commented on HIVE-21851: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-21851) FireEventResponse should include event id when available

2019-11-27 Thread Vihang Karajgaonkar (Jira)
[ https://issues.apache.org/jira/browse/HIVE-21851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983800#comment-16983800 ] Vihang Karajgaonkar commented on HIVE-21851: I can't seem to understand why the test fails on

[jira] [Commented] (HIVE-21851) FireEventResponse should include event id when available

2019-06-10 Thread Vihang Karajgaonkar (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860228#comment-16860228 ] Vihang Karajgaonkar commented on HIVE-21851: Yeah, thats interesting .. will take a look.

[jira] [Commented] (HIVE-21851) FireEventResponse should include event id when available

2019-06-10 Thread Yongzhi Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859879#comment-16859879 ] Yongzhi Chen commented on HIVE-21851: - [~vihangk1], the same test failed again, could you check? >

[jira] [Commented] (HIVE-21851) FireEventResponse should include event id when available

2019-06-08 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859361#comment-16859361 ] Hive QA commented on HIVE-21851: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-21851) FireEventResponse should include event id when available

2019-06-08 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859356#comment-16859356 ] Hive QA commented on HIVE-21851: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-21851) FireEventResponse should include event id when available

2019-06-08 Thread Vihang Karajgaonkar (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859349#comment-16859349 ] Vihang Karajgaonkar commented on HIVE-21851: test works for me locally. Reattaching it the

[jira] [Commented] (HIVE-21851) FireEventResponse should include event id when available

2019-06-08 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859170#comment-16859170 ] Hive QA commented on HIVE-21851: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-21851) FireEventResponse should include event id when available

2019-06-08 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859160#comment-16859160 ] Hive QA commented on HIVE-21851: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-21851) FireEventResponse should include event id when available

2019-06-07 Thread Vihang Karajgaonkar (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859076#comment-16859076 ] Vihang Karajgaonkar commented on HIVE-21851: [~ngangam] [~ychena] Can you please take a look?