[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15022804#comment-15022804
]
Yin Huai commented on HIVE-3454:
OK. Thanks.
> Problem with CAST(BIGINT as TIMESTAMP)
> --
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15022785#comment-15022785
]
Aihua Xu commented on HIVE-3454:
[~yhuai] In 1.2.1, you need to {{set
hive.int.timestamp.c
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15022420#comment-15022420
]
Yin Huai commented on HIVE-3454:
I was using 1.2.1.
> Problem with CAST(BIGINT as TIMESTA
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15022402#comment-15022402
]
Aihua Xu commented on HIVE-3454:
[~yhuai] Which version are you running on? I tried on the
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15014538#comment-15014538
]
Yin Huai commented on HIVE-3454:
Seems this issue has not been fixe completely. I still see
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14378367#comment-14378367
]
Aihua Xu commented on HIVE-3454:
Thanks [~csun] and [~jdere].
> Problem with CAST(BIGINT a
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14376863#comment-14376863
]
Jason Dere commented on HIVE-3454:
--
+1
> Problem with CAST(BIGINT as TIMESTAMP)
> ---
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14375082#comment-14375082
]
Aihua Xu commented on HIVE-3454:
This error is unrelated to the change and seems random.
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14374774#comment-14374774
]
Hive QA commented on HIVE-3454:
---
{color:red}Overall{color}: -1 at least one tests failed
H
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14372897#comment-14372897
]
Hive QA commented on HIVE-3454:
---
{color:red}Overall{color}: -1 at least one tests failed
H
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14372840#comment-14372840
]
Aihua Xu commented on HIVE-3454:
Attached should be the right patch now. Maybe I uploaded t
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14372089#comment-14372089
]
Jason Dere commented on HIVE-3454:
--
So this patch did not require any changes to MathExpr?
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14371672#comment-14371672
]
Hive QA commented on HIVE-3454:
---
{color:red}Overall{color}: -1 at least one tests failed
H
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14363650#comment-14363650
]
Jason Dere commented on HIVE-3454:
--
Whoops, yes it is longToTimestamp() that should be fix
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14363355#comment-14363355
]
Aihua Xu commented on HIVE-3454:
Thanks [~jdere]. We need to correct MathErpr.longToTimesta
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14359502#comment-14359502
]
Jason Dere commented on HIVE-3454:
--
I've just started looking at vectorized code .. looks
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14359406#comment-14359406
]
Aihua Xu commented on HIVE-3454:
Yes. That's right. That patch is to change in the correct
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14359383#comment-14359383
]
Jason Dere commented on HIVE-3454:
--
This has been marked patch available - which one shoul
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14359144#comment-14359144
]
Jason Dere commented on HIVE-3454:
--
That's fine to break into separate tasks, we'll just n
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14358988#comment-14358988
]
Chao commented on HIVE-3454:
+1. Breaking into separate tasks makes sense to me, but it's bette
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14355789#comment-14355789
]
Aihua Xu commented on HIVE-3454:
[~brocknoland], [~jdere] and [~hagleitn] I created HIVE-99
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14355763#comment-14355763
]
Aihua Xu commented on HIVE-3454:
I'm looking into the solution [~hagleitn] suggested. I wi
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14348023#comment-14348023
]
Aihua Xu commented on HIVE-3454:
Of course, since we need to support LLAP, UDF approach see
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14347905#comment-14347905
]
Aihua Xu commented on HIVE-3454:
I agree that for non thread-safe statics, it will cause pr
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14347582#comment-14347582
]
Gunther Hagleitner commented on HIVE-3454:
--
I agree with [~sershe]. These statics
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14347540#comment-14347540
]
Sergey Shelukhin commented on HIVE-3454:
It just seems like a bad design pattern ir
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14347042#comment-14347042
]
Aihua Xu commented on HIVE-3454:
Was not aware of LLAP. Seems reasonable to defer the issue
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14346454#comment-14346454
]
Brock Noland commented on HIVE-3454:
bq. an HOS have multiple threads doing work for mo
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14346318#comment-14346318
]
Jason Dere commented on HIVE-3454:
--
I'm willing to defer that work to a different Jira. +1
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14346302#comment-14346302
]
Brock Noland commented on HIVE-3454:
HOS won't have this issue as the executors are tie
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14346184#comment-14346184
]
Jason Dere commented on HIVE-3454:
--
{quote}
Actually we don't want it to be thread-local s
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14346156#comment-14346156
]
Sergey Shelukhin commented on HIVE-3454:
Please don't use the static intToTimeStamp
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14346115#comment-14346115
]
Aihua Xu commented on HIVE-3454:
#Actually we don't want it to be thread-local since we wan
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14346047#comment-14346047
]
Jason Dere commented on HIVE-3454:
--
- Can you make intToTimeStampInSeconds thread-local?
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14345766#comment-14345766
]
Aihua Xu commented on HIVE-3454:
[~jdere] Can you review the latest patch? Right now it sho
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14344253#comment-14344253
]
Hive QA commented on HIVE-3454:
---
{color:green}Overall{color}: +1 all checks pass
Here are
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14343913#comment-14343913
]
Aihua Xu commented on HIVE-3454:
Updated to initialize for local mode in Driver.runInternal
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14340221#comment-14340221
]
Aihua Xu commented on HIVE-3454:
I see your points that multiple threads run in single mapp
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14337027#comment-14337027
]
Jason Dere commented on HIVE-3454:
--
If concurrent compilation is possible, then there is s
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14336537#comment-14336537
]
Aihua Xu commented on HIVE-3454:
If the job runs locally in-process, like cast(0 as timesta
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14335946#comment-14335946
]
Jason Dere commented on HIVE-3454:
--
I guess the only possible issue here might be for expr
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14335874#comment-14335874
]
Aihua Xu commented on HIVE-3454:
The unit test failure is unrelated to the change. [~jdere]
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333554#comment-14333554
]
Aihua Xu commented on HIVE-3454:
[~jdere] I spent some time looking into the parallel in Hi
43 matches
Mail list logo
