[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022785#comment-15022785
]
Aihua Xu commented on HIVE-3454:
[~yhuai] In 1.2.1, you need to {{set
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022804#comment-15022804
]
Yin Huai commented on HIVE-3454:
OK. Thanks.
> Problem with CAST(BIGINT as TIMESTAMP)
>
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022402#comment-15022402
]
Aihua Xu commented on HIVE-3454:
[~yhuai] Which version are you running on? I tried on the latest and it
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022420#comment-15022420
]
Yin Huai commented on HIVE-3454:
I was using 1.2.1.
> Problem with CAST(BIGINT as TIMESTAMP)
>
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014538#comment-15014538
]
Yin Huai commented on HIVE-3454:
Seems this issue has not been fixe completely. I still see
{code}
hive>
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14378367#comment-14378367
]
Aihua Xu commented on HIVE-3454:
Thanks [~csun] and [~jdere].
Problem with CAST(BIGINT as
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14376863#comment-14376863
]
Jason Dere commented on HIVE-3454:
--
+1
Problem with CAST(BIGINT as TIMESTAMP)
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14372897#comment-14372897
]
Hive QA commented on HIVE-3454:
---
{color:red}Overall{color}: -1 at least one tests failed
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14372840#comment-14372840
]
Aihua Xu commented on HIVE-3454:
Attached should be the right patch now. Maybe I uploaded
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14374774#comment-14374774
]
Hive QA commented on HIVE-3454:
---
{color:red}Overall{color}: -1 at least one tests failed
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14372089#comment-14372089
]
Jason Dere commented on HIVE-3454:
--
So this patch did not require any changes to MathExpr?
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14371672#comment-14371672
]
Hive QA commented on HIVE-3454:
---
{color:red}Overall{color}: -1 at least one tests failed
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14363355#comment-14363355
]
Aihua Xu commented on HIVE-3454:
Thanks [~jdere]. We need to correct
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14363650#comment-14363650
]
Jason Dere commented on HIVE-3454:
--
Whoops, yes it is longToTimestamp() that should be
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14358988#comment-14358988
]
Chao commented on HIVE-3454:
+1. Breaking into separate tasks makes sense to me, but it's
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14359406#comment-14359406
]
Aihua Xu commented on HIVE-3454:
Yes. That's right. That patch is to change in the correct
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14359144#comment-14359144
]
Jason Dere commented on HIVE-3454:
--
That's fine to break into separate tasks, we'll just
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14359502#comment-14359502
]
Jason Dere commented on HIVE-3454:
--
I've just started looking at vectorized code .. looks
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14347582#comment-14347582
]
Gunther Hagleitner commented on HIVE-3454:
--
I agree with [~sershe]. These statics
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14348023#comment-14348023
]
Aihua Xu commented on HIVE-3454:
Of course, since we need to support LLAP, UDF approach
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14347905#comment-14347905
]
Aihua Xu commented on HIVE-3454:
I agree that for non thread-safe statics, it will cause
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14345766#comment-14345766
]
Aihua Xu commented on HIVE-3454:
[~jdere] Can you review the latest patch? Right now it
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14346156#comment-14346156
]
Sergey Shelukhin commented on HIVE-3454:
Please don't use the static
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14346184#comment-14346184
]
Jason Dere commented on HIVE-3454:
--
{quote}
Actually we don't want it to be thread-local
[
https://issues.apache.org/jira/browse/HIVE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14346318#comment-14346318
]
Jason Dere commented on HIVE-3454:
--
I'm willing to defer that work to a different Jira. +1
25 matches
Mail list logo
