[
https://issues.apache.org/jira/browse/HIVE-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15396077#comment-15396077
]
Sergey Shelukhin commented on HIVE-9555:
Hmm?
> assorted ORC refactorings for LLAP
[
https://issues.apache.org/jira/browse/HIVE-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14372319#comment-14372319
]
Sergey Shelukhin commented on HIVE-9555:
Filed HIVE-10042 as a followup
> assorte
[
https://issues.apache.org/jira/browse/HIVE-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14372247#comment-14372247
]
Gopal V commented on HIVE-9555:
---
[~sershe]: Adding to Prasanth's +1 - LGTM.
Move the DiskRan
[
https://issues.apache.org/jira/browse/HIVE-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14370499#comment-14370499
]
Hive QA commented on HIVE-9555:
---
{color:green}Overall{color}: +1 all checks pass
Here are
[
https://issues.apache.org/jira/browse/HIVE-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14366783#comment-14366783
]
Gopal V commented on HIVE-9555:
---
[~prasanth_j]: I saw that, which is why I so missed Object m
[
https://issues.apache.org/jira/browse/HIVE-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14366676#comment-14366676
]
Prasanth Jayachandran commented on HIVE-9555:
-
And for
https://github.com/apac
[
https://issues.apache.org/jira/browse/HIVE-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14366672#comment-14366672
]
Prasanth Jayachandran commented on HIVE-9555:
-
Its needed for
https://github.c
[
https://issues.apache.org/jira/browse/HIVE-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14366670#comment-14366670
]
Gopal V commented on HIVE-9555:
---
It shouldn't?
{code}
- private static class StringTreeRead
[
https://issues.apache.org/jira/browse/HIVE-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1438#comment-1438
]
Sergey Shelukhin commented on HIVE-9555:
StringTreeReader should not be exposed, th
[
https://issues.apache.org/jira/browse/HIVE-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14366584#comment-14366584
]
Gopal V commented on HIVE-9555:
---
[~sershe]: Review 1-pass done, I've understood what you're t
[
https://issues.apache.org/jira/browse/HIVE-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14360858#comment-14360858
]
Sergey Shelukhin commented on HIVE-9555:
[~gopalv] ping? I am ready to commit ;)
>
[
https://issues.apache.org/jira/browse/HIVE-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14355306#comment-14355306
]
Sergey Shelukhin commented on HIVE-9555:
[~prasanth_j] ping?
> assorted ORC refact
[
https://issues.apache.org/jira/browse/HIVE-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14356177#comment-14356177
]
Hive QA commented on HIVE-9555:
---
{color:green}Overall{color}: +1 all checks pass
Here are
[
https://issues.apache.org/jira/browse/HIVE-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14356051#comment-14356051
]
Prasanth Jayachandran commented on HIVE-9555:
-
LGTM, +1. Pending tests on the n
[
https://issues.apache.org/jira/browse/HIVE-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14356014#comment-14356014
]
Hive QA commented on HIVE-9555:
---
{color:green}Overall{color}: +1 all checks pass
Here are
[
https://issues.apache.org/jira/browse/HIVE-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14355865#comment-14355865
]
Prasanth Jayachandran commented on HIVE-9555:
-
Mostly looks good. Left few more
[
https://issues.apache.org/jira/browse/HIVE-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14355689#comment-14355689
]
Sergey Shelukhin commented on HIVE-9555:
Please ignore the one in b/ directory.
>
[
https://issues.apache.org/jira/browse/HIVE-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14355665#comment-14355665
]
Prasanth Jayachandran commented on HIVE-9555:
-
I think there is something wrong
[
https://issues.apache.org/jira/browse/HIVE-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14355429#comment-14355429
]
Prasanth Jayachandran commented on HIVE-9555:
-
Left some minor comments in RB.
[
https://issues.apache.org/jira/browse/HIVE-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14355313#comment-14355313
]
Prasanth Jayachandran commented on HIVE-9555:
-
I just started reviewing it. In
[
https://issues.apache.org/jira/browse/HIVE-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14335951#comment-14335951
]
Hive QA commented on HIVE-9555:
---
{color:red}Overall{color}: -1 at least one tests failed
H
[
https://issues.apache.org/jira/browse/HIVE-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14335671#comment-14335671
]
Sergey Shelukhin commented on HIVE-9555:
https://reviews.apache.org/r/31386/
> ass
22 matches
Mail list logo
