[
https://issues.apache.org/jira/browse/HIVE-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16995693#comment-16995693
]
Hive QA commented on HIVE-9736:
---
Here are the results of testing the latest attachment:
ht
[
https://issues.apache.org/jira/browse/HIVE-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16995221#comment-16995221
]
Mithun Radhakrishnan commented on HIVE-9736:
[~zshao], sorry I missed your com
[
https://issues.apache.org/jira/browse/HIVE-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16752550#comment-16752550
]
Hive QA commented on HIVE-9736:
---
Here are the results of testing the latest attachment:
ht
[
https://issues.apache.org/jira/browse/HIVE-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16752547#comment-16752547
]
Zheng Shao commented on HIVE-9736:
--
Are we sure that FileSystem.listStatus(Path[]) is fas
[
https://issues.apache.org/jira/browse/HIVE-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14588814#comment-14588814
]
Sushanth Sowmyan commented on HIVE-9736:
Looks like we have a regression :
org.apa
[
https://issues.apache.org/jira/browse/HIVE-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14588792#comment-14588792
]
Hive QA commented on HIVE-9736:
---
{color:red}Overall{color}: -1 at least one tests failed
H
[
https://issues.apache.org/jira/browse/HIVE-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14536981#comment-14536981
]
Hive QA commented on HIVE-9736:
---
{color:red}Overall{color}: -1 at least one tests failed
H
[
https://issues.apache.org/jira/browse/HIVE-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14535883#comment-14535883
]
Sushanth Sowmyan commented on HIVE-9736:
Removing fix version of 1.2.0 in preparati
[
https://issues.apache.org/jira/browse/HIVE-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14535528#comment-14535528
]
Sushanth Sowmyan commented on HIVE-9736:
I did not find this in the precommit queue
[
https://issues.apache.org/jira/browse/HIVE-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14534035#comment-14534035
]
Lefty Leverenz commented on HIVE-9736:
--
Doc note: This adds configuration parameter
[
https://issues.apache.org/jira/browse/HIVE-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14532252#comment-14532252
]
Sushanth Sowmyan commented on HIVE-9736:
Sorry about the null-check, yup, I meant t
[
https://issues.apache.org/jira/browse/HIVE-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14531961#comment-14531961
]
Chris Nauroth commented on HIVE-9736:
-
I apologize for missing this in my code review.
[
https://issues.apache.org/jira/browse/HIVE-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14531885#comment-14531885
]
Mithun Radhakrishnan commented on HIVE-9736:
@[~sushanth]: Quick question about
[
https://issues.apache.org/jira/browse/HIVE-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14531851#comment-14531851
]
Mithun Radhakrishnan commented on HIVE-9736:
[~spena], [~sushanth], thanks for
[
https://issues.apache.org/jira/browse/HIVE-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14531809#comment-14531809
]
Sushanth Sowmyan commented on HIVE-9736:
Also, since this is a performance patch ra
[
https://issues.apache.org/jira/browse/HIVE-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14531800#comment-14531800
]
Sushanth Sowmyan commented on HIVE-9736:
The problem, as Sergio mentions, is that a
[
https://issues.apache.org/jira/browse/HIVE-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14531722#comment-14531722
]
Sushanth Sowmyan commented on HIVE-9736:
Hi Sergio, thanks for the catch, have file
[
https://issues.apache.org/jira/browse/HIVE-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14531704#comment-14531704
]
Sergio Peña commented on HIVE-9736:
---
Hi [~mithun]
This patch is causing the above tests
[
https://issues.apache.org/jira/browse/HIVE-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14528724#comment-14528724
]
Chris Nauroth commented on HIVE-9736:
-
[~sushanth], thank you for your review and the c
[
https://issues.apache.org/jira/browse/HIVE-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14528696#comment-14528696
]
Sushanth Sowmyan commented on HIVE-9736:
+1 : Have looked through patch and it make
[
https://issues.apache.org/jira/browse/HIVE-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14528348#comment-14528348
]
Hive QA commented on HIVE-9736:
---
{color:red}Overall{color}: -1 at least one tests failed
H
[
https://issues.apache.org/jira/browse/HIVE-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14527506#comment-14527506
]
Chris Nauroth commented on HIVE-9736:
-
I verified with both {{-Phadoop-2}} and {{-Phado
[
https://issues.apache.org/jira/browse/HIVE-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14527362#comment-14527362
]
Chris Nauroth commented on HIVE-9736:
-
Just as a reminder, we were asked to check the b
[
https://issues.apache.org/jira/browse/HIVE-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14527348#comment-14527348
]
Chris Nauroth commented on HIVE-9736:
-
I figured we could make {{DefaultFileAccess#comb
[
https://issues.apache.org/jira/browse/HIVE-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14527314#comment-14527314
]
Mithun Radhakrishnan commented on HIVE-9736:
Thanks for the review, Chris.
Wo
[
https://issues.apache.org/jira/browse/HIVE-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14522338#comment-14522338
]
Sushanth Sowmyan commented on HIVE-9736:
(Note that given that HIVE-9681 has now be
[
https://issues.apache.org/jira/browse/HIVE-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14520892#comment-14520892
]
Chris Nauroth commented on HIVE-9736:
-
I have one remaining comment in Review Board sug
[
https://issues.apache.org/jira/browse/HIVE-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14520852#comment-14520852
]
Hive QA commented on HIVE-9736:
---
{color:red}Overall{color}: -1 no tests executed
Here are
[
https://issues.apache.org/jira/browse/HIVE-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14520508#comment-14520508
]
Sushanth Sowmyan commented on HIVE-9736:
[~thejas], could you please review this pa
[
https://issues.apache.org/jira/browse/HIVE-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14518943#comment-14518943
]
Sushanth Sowmyan commented on HIVE-9736:
Hi, just so this gets into the precommit q
[
https://issues.apache.org/jira/browse/HIVE-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14518834#comment-14518834
]
Mithun Radhakrishnan commented on HIVE-9736:
Hello, Chris.
bq. ... we can com
[
https://issues.apache.org/jira/browse/HIVE-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14518695#comment-14518695
]
Chris Nauroth commented on HIVE-9736:
-
Hi [~mithun]. Thank you for uploading a new pat
[
https://issues.apache.org/jira/browse/HIVE-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14492966#comment-14492966
]
Chris Nauroth commented on HIVE-9736:
-
Thank you for the rebased patch. It looks great
[
https://issues.apache.org/jira/browse/HIVE-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486260#comment-14486260
]
Mithun Radhakrishnan commented on HIVE-9736:
@[~cnauroth]: Good to meet you, si
[
https://issues.apache.org/jira/browse/HIVE-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486193#comment-14486193
]
Chris Nauroth commented on HIVE-9736:
-
Hi [~mithun]. Great ideas in this patch! I'd b
[
https://issues.apache.org/jira/browse/HIVE-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486159#comment-14486159
]
Mithun Radhakrishnan commented on HIVE-9736:
Ok, I'd better rebase this change.
[
https://issues.apache.org/jira/browse/HIVE-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486151#comment-14486151
]
Sushanth Sowmyan commented on HIVE-9736:
I've not looked at this patch in detail ye
[
https://issues.apache.org/jira/browse/HIVE-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14342835#comment-14342835
]
Mithun Radhakrishnan commented on HIVE-9736:
The review on RB is [r/31615|https
[
https://issues.apache.org/jira/browse/HIVE-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14335645#comment-14335645
]
Thejas M Nair commented on HIVE-9736:
-
[~mithun] Can you please upload the patch to rev
[
https://issues.apache.org/jira/browse/HIVE-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334157#comment-14334157
]
Mithun Radhakrishnan commented on HIVE-9736:
Tagging [~thejas], since this marc
40 matches
Mail list logo
