[jira] [Commented] (HIVE-9917) After HIVE-3454 is done, make int to timestamp conversion configurable

[ https://issues.apache.org/jira/browse/HIVE-9917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14509570#comment-14509570 ] Aihua Xu commented on HIVE-9917: Thanks [~jdere]. After HIVE-3454 is done, make int to

[jira] [Commented] (HIVE-9917) After HIVE-3454 is done, make int to timestamp conversion configurable

[ https://issues.apache.org/jira/browse/HIVE-9917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14505408#comment-14505408 ] Jason Dere commented on HIVE-9917: -- You mean on RB? I don't think I have access to update

[jira] [Commented] (HIVE-9917) After HIVE-3454 is done, make int to timestamp conversion configurable

[ https://issues.apache.org/jira/browse/HIVE-9917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14505332#comment-14505332 ] Aihua Xu commented on HIVE-9917: I see. Yeah. I was using --no-prefix. After HIVE-3454

[jira] [Commented] (HIVE-9917) After HIVE-3454 is done, make int to timestamp conversion configurable

[ https://issues.apache.org/jira/browse/HIVE-9917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14505623#comment-14505623 ] Aihua Xu commented on HIVE-9917: No. I mean check in this code change to trunk? After

[jira] [Commented] (HIVE-9917) After HIVE-3454 is done, make int to timestamp conversion configurable

[ https://issues.apache.org/jira/browse/HIVE-9917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14505638#comment-14505638 ] Jason Dere commented on HIVE-9917: -- The +1 is supposed to sit for a day before getting

[jira] [Commented] (HIVE-9917) After HIVE-3454 is done, make int to timestamp conversion configurable

[ https://issues.apache.org/jira/browse/HIVE-9917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14503780#comment-14503780 ] Jason Dere commented on HIVE-9917: -- You're right, thanks for looking into that. Sorry to

[jira] [Commented] (HIVE-9917) After HIVE-3454 is done, make int to timestamp conversion configurable

[ https://issues.apache.org/jira/browse/HIVE-9917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14502858#comment-14502858 ] Aihua Xu commented on HIVE-9917: [~jdere] You are talking about vector_between_in.q.out,

[jira] [Commented] (HIVE-9917) After HIVE-3454 is done, make int to timestamp conversion configurable

[ https://issues.apache.org/jira/browse/HIVE-9917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14502860#comment-14502860 ] Aihua Xu commented on HIVE-9917: Sorry. Alex Pivovarov's fix. :) After HIVE-3454 is done,

[jira] [Commented] (HIVE-9917) After HIVE-3454 is done, make int to timestamp conversion configurable

[ https://issues.apache.org/jira/browse/HIVE-9917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14500516#comment-14500516 ] Aihua Xu commented on HIVE-9917: [~jdere] I updated the unit tests to check the old

[jira] [Commented] (HIVE-9917) After HIVE-3454 is done, make int to timestamp conversion configurable

[ https://issues.apache.org/jira/browse/HIVE-9917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14500527#comment-14500527 ] Jason Dere commented on HIVE-9917: -- I'll try to take a look later today After HIVE-3454

[jira] [Commented] (HIVE-9917) After HIVE-3454 is done, make int to timestamp conversion configurable

[ https://issues.apache.org/jira/browse/HIVE-9917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14500959#comment-14500959 ] Jason Dere commented on HIVE-9917: -- I'm looking at the qfile output changes, to make sure

[jira] [Commented] (HIVE-9917) After HIVE-3454 is done, make int to timestamp conversion configurable

[ https://issues.apache.org/jira/browse/HIVE-9917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14498235#comment-14498235 ] Hive QA commented on HIVE-9917: --- {color:red}Overall{color}: -1 at least one tests failed

[jira] [Commented] (HIVE-9917) After HIVE-3454 is done, make int to timestamp conversion configurable

[ https://issues.apache.org/jira/browse/HIVE-9917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14498355#comment-14498355 ] Aihua Xu commented on HIVE-9917: The test failures are unrelated to the patch. After

[jira] [Commented] (HIVE-9917) After HIVE-3454 is done, make int to timestamp conversion configurable

[ https://issues.apache.org/jira/browse/HIVE-9917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14496784#comment-14496784 ] Hive QA commented on HIVE-9917: --- {color:red}Overall{color}: -1 at least one tests failed

[jira] [Commented] (HIVE-9917) After HIVE-3454 is done, make int to timestamp conversion configurable

[ https://issues.apache.org/jira/browse/HIVE-9917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14497393#comment-14497393 ] Aihua Xu commented on HIVE-9917: Somehow vector_between_in test case baselines were not

[jira] [Commented] (HIVE-9917) After HIVE-3454 is done, make int to timestamp conversion configurable

[ https://issues.apache.org/jira/browse/HIVE-9917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14490751#comment-14490751 ] Hive QA commented on HIVE-9917: --- {color:red}Overall{color}: -1 no tests executed Here are

[jira] [Commented] (HIVE-9917) After HIVE-3454 is done, make int to timestamp conversion configurable

[ https://issues.apache.org/jira/browse/HIVE-9917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487782#comment-14487782 ] Jason Dere commented on HIVE-9917: -- HIVE-3454 changed the output of a lot of tests,

[jira] [Commented] (HIVE-9917) After HIVE-3454 is done, make int to timestamp conversion configurable

[ https://issues.apache.org/jira/browse/HIVE-9917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487848#comment-14487848 ] Aihua Xu commented on HIVE-9917: For those test cases, I changed them to set the

[jira] [Commented] (HIVE-9917) After HIVE-3454 is done, make int to timestamp conversion configurable

[ https://issues.apache.org/jira/browse/HIVE-9917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487917#comment-14487917 ] Jason Dere commented on HIVE-9917: -- Ah ok. Actually, I would prefer to have the output

[jira] [Commented] (HIVE-9917) After HIVE-3454 is done, make int to timestamp conversion configurable

[ https://issues.apache.org/jira/browse/HIVE-9917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14485302#comment-14485302 ] Aihua Xu commented on HIVE-9917: Internally when we convert timestamp to numerical type, it

[jira] [Commented] (HIVE-9917) After HIVE-3454 is done, make int to timestamp conversion configurable

[ https://issues.apache.org/jira/browse/HIVE-9917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14395623#comment-14395623 ] Hive QA commented on HIVE-9917: --- {color:red}Overall{color}: -1 at least one tests failed

[jira] [Commented] (HIVE-9917) After HIVE-3454 is done, make int to timestamp conversion configurable

[ https://issues.apache.org/jira/browse/HIVE-9917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14394923#comment-14394923 ] Aihua Xu commented on HIVE-9917: Thanks Jason. Regarding implicit conversion, I checked

[jira] [Commented] (HIVE-9917) After HIVE-3454 is done, make int to timestamp conversion configurable

[ https://issues.apache.org/jira/browse/HIVE-9917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14394996#comment-14394996 ] Aihua Xu commented on HIVE-9917: Yeah. You are right. Mostly works. Of course seems the

[jira] [Commented] (HIVE-9917) After HIVE-3454 is done, make int to timestamp conversion configurable

[ https://issues.apache.org/jira/browse/HIVE-9917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14395132#comment-14395132 ] Aihua Xu commented on HIVE-9917: There are some UDFs such as UDFToBoolean, UDFToLong and

[jira] [Commented] (HIVE-9917) After HIVE-3454 is done, make int to timestamp conversion configurable

[ https://issues.apache.org/jira/browse/HIVE-9917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14395039#comment-14395039 ] Jason Dere commented on HIVE-9917: -- If Hive has always been converting from timestamp to

[jira] [Commented] (HIVE-9917) After HIVE-3454 is done, make int to timestamp conversion configurable

[ https://issues.apache.org/jira/browse/HIVE-9917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14394938#comment-14394938 ] Jason Dere commented on HIVE-9917: -- Hmm, that's surprising - I think there are a lot of

[jira] [Commented] (HIVE-9917) After HIVE-3454 is done, make int to timestamp conversion configurable

[ https://issues.apache.org/jira/browse/HIVE-9917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14393482#comment-14393482 ] Hive QA commented on HIVE-9917: --- {color:red}Overall{color}: -1 at least one tests failed

[jira] [Commented] (HIVE-9917) After HIVE-3454 is done, make int to timestamp conversion configurable

[ https://issues.apache.org/jira/browse/HIVE-9917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14393381#comment-14393381 ] Jason Dere commented on HIVE-9917: -- Can you create an RB entry on reviews.apache.org?

[jira] [Commented] (HIVE-9917) After HIVE-3454 is done, make int to timestamp conversion configurable

[ https://issues.apache.org/jira/browse/HIVE-9917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14393415#comment-14393415 ] Aihua Xu commented on HIVE-9917: Already created. Please see the link above. After

[jira] [Commented] (HIVE-9917) After HIVE-3454 is done, make int to timestamp conversion configurable

[ https://issues.apache.org/jira/browse/HIVE-9917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14393764#comment-14393764 ] Jason Dere commented on HIVE-9917: -- So this is covering the case of converting an int to

[jira] [Commented] (HIVE-9917) After HIVE-3454 is done, make int to timestamp conversion configurable

[ https://issues.apache.org/jira/browse/HIVE-9917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14392850#comment-14392850 ] Aihua Xu commented on HIVE-9917: Review: https://reviews.apache.org/r/32775/ After