[ https://issues.apache.org/jira/browse/HIVE-26627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stamatis Zampetakis resolved HIVE-26627. ---------------------------------------- Fix Version/s: 4.0.0 4.0.0-alpha-2 Resolution: Fixed Fixed in https://github.com/apache/hive/commit/b48c1bf11c4f75ba2c894e4732a96813ddde1414. Thanks for the review [~kkasa]! > Remove HiveRelBuilder.aggregateCall override and refactor callers to use > existing public methods > ------------------------------------------------------------------------------------------------ > > Key: HIVE-26627 > URL: https://issues.apache.org/jira/browse/HIVE-26627 > Project: Hive > Issue Type: Task > Components: CBO > Reporter: Stamatis Zampetakis > Assignee: Stamatis Zampetakis > Priority: Major > Labels: pull-request-available > Fix For: 4.0.0, 4.0.0-alpha-2 > > Time Spent: 40m > Remaining Estimate: 0h > > The HiveRelBuilder overrides > [aggregateCall|https://github.com/apache/hive/blob/8c3567ea8e423b202cde370f4d3fb401bcc23e46/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelBuilder.java#L246] > from its superclass simply to expose and use it in > HiveRewriteToDataSketchesRules. > However, there is no real need to override this method since we can achieve > the same outcome by using existing methods in RelBuilder which are easier to > use and understand. Furthermore it is safer to depend on public APIs since > are more stable in general. -- This message was sent by Atlassian Jira (v8.20.10#820010)