[GitHub] incubator-hivemall issue #87: [HIVEMALL-108] Support `-iter` option in gener...

2017-06-27 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/87 There are several design options to consider: 1) move `-iter` and `-mini-batch` functionalities to LeanerBaseUDTF => but, it cannot be used for MulticlassOnlineClassifier.. :-(

[GitHub] incubator-hivemall issue #87: [HIVEMALL-108] Support `-iter` option in gener...

2017-06-27 Thread takuti
Github user takuti commented on the issue: https://github.com/apache/incubator-hivemall/pull/87 @myui Thank you for review and suggestion. I will work on them in a week. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] incubator-hivemall issue #89: [HIVEMALL-120] Refactor on LDA/pLSA's mini-bat...

2017-06-27 Thread takuti
Github user takuti commented on the issue: https://github.com/apache/incubator-hivemall/pull/89 Oh, you move very fast :) > -tol alias Sure~ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] incubator-hivemall issue #89: [HIVEMALL-120] Refactor on LDA/pLSA's mini-bat...

2017-06-27 Thread takuti
Github user takuti commented on the issue: https://github.com/apache/incubator-hivemall/pull/89 @myui Oh, you move very fast :) > -tol alias Sure~ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-hivemall issue #87: [HIVEMALL-108] Support `-iter` option in gener...

2017-06-27 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/87 I think `-tol` is hard to configure by average users. It can be replaced with `ConversionState`. It doubly checks that an iteration really converges. --- If your project is set up

[GitHub] incubator-hivemall issue #87: [HIVEMALL-108] Support `-iter` option in gener...

2017-06-27 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/87 I'm wondering to generalize `-iterations` and `-mini_batch` logic of GeneralLeanerBaseUDTF for BinaryOnlineClassifierUDTF and RegressionBaseUDTF as well. https://gyazo.com/4ceaeb003ccad85

[GitHub] incubator-hivemall pull request #87: [HIVEMALL-108] Support `-iter` option i...

2017-06-27 Thread myui
Github user myui commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/87#discussion_r124191703 --- Diff: core/src/main/java/hivemall/model/FeatureValue.java --- @@ -74,6 +83,16 @@ public void setValue(double value) { this.value = va