[GitHub] incubator-hivemall issue #71: [HIVEMALL-74] Implement pLSA

2017-04-27 Thread takuti
Github user takuti commented on the issue: https://github.com/apache/incubator-hivemall/pull/71 ^ Fixed and gonna be sent as a new pr soon --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-hivemall issue #71: [HIVEMALL-74] Implement pLSA

2017-04-27 Thread takuti
Github user takuti commented on the issue: https://github.com/apache/incubator-hivemall/pull/71 Ack! Checking your modifications. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-hivemall issue #71: [HIVEMALL-74] Implement pLSA

2017-04-27 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/71 oops... need to fix CI errors as well. https://travis-ci.org/apache/incubator-hivemall/jobs/226400990 --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-hivemall issue #71: [HIVEMALL-74] Implement pLSA

2017-04-27 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/71 @takuti Revised branch is already merged into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] incubator-hivemall issue #71: [HIVEMALL-74] Implement pLSA

2017-04-27 Thread takuti
Github user takuti commented on the issue: https://github.com/apache/incubator-hivemall/pull/71 @myui Thanks! Are you planning to push [your revise branch](https://github.com/myui/incubator-hivemall/tree/HIVEMALL-74) to master? Or, can I cherry-pick them and start making additional ef

[GitHub] incubator-hivemall issue #71: [HIVEMALL-74] Implement pLSA

2017-04-27 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/71 @takuti LGTM for other codes. Merged! Thanks. Please send PR `[HIVEMALL-74-2]` if required. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] incubator-hivemall issue #71: [HIVEMALL-74] Implement pLSA

2017-04-27 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/71 @takuti I think probability normalization is missing in `plsa_predict`. ``` [{"label":0,"probability":1.0},{"label":1,"probability":1.1246405E-32}] ``` --- If your project is

[GitHub] incubator-hivemall issue #71: [HIVEMALL-74] Implement pLSA

2017-04-25 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/71 revising at https://github.com/myui/incubator-hivemall/tree/HIVEMALL-74 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-hivemall issue #71: [HIVEMALL-74] Implement pLSA

2017-04-24 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-hivemall/pull/71 [![Coverage Status](https://coveralls.io/builds/11225273/badge)](https://coveralls.io/builds/11225273) Coverage increased (+0.7%) to 38.68% when pulling **94a8fe70088161be6

[GitHub] incubator-hivemall issue #71: [HIVEMALL-74] Implement pLSA

2017-04-24 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-hivemall/pull/71 [![Coverage Status](https://coveralls.io/builds/11225273/badge)](https://coveralls.io/builds/11225273) Coverage increased (+0.7%) to 38.68% when pulling **94a8fe70088161be6

[GitHub] incubator-hivemall issue #71: [HIVEMALL-74] Implement pLSA

2017-04-24 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/71 Sure 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] incubator-hivemall issue #71: [HIVEMALL-74] Implement pLSA

2017-04-24 Thread takuti
Github user takuti commented on the issue: https://github.com/apache/incubator-hivemall/pull/71 @myui almost finished. could you review current code and docs? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] incubator-hivemall issue #71: [HIVEMALL-74] Implement pLSA

2017-04-12 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-hivemall/pull/71 [![Coverage Status](https://coveralls.io/builds/11066189/badge)](https://coveralls.io/builds/11066189) Coverage increased (+0.7%) to 37.545% when pulling **82597a2ca4ffefef

[GitHub] incubator-hivemall issue #71: [HIVEMALL-74] Implement pLSA

2017-04-12 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-hivemall/pull/71 [![Coverage Status](https://coveralls.io/builds/11066189/badge)](https://coveralls.io/builds/11066189) Coverage increased (+0.7%) to 37.545% when pulling **82597a2ca4ffefef

[GitHub] incubator-hivemall issue #71: [HIVEMALL-74] Implement pLSA

2017-04-12 Thread takuti
Github user takuti commented on the issue: https://github.com/apache/incubator-hivemall/pull/71 Since interfaces are similar to Online LDA, this PR should be handled after #66 is merged. --- If your project is set up for it, you can reply to this email and have your reply appear on G