Re: [I] [Bug]: 'Open File' dialog when editing configuration files in Environment properties prepends CWD of client, doesn't resolve variables (hop)

2023-11-21 Thread via GitHub
kranskydog commented on issue #3324: URL: https://github.com/apache/hop/issues/3324#issuecomment-1821745117 @hansva and what happens when you hit 'Select' on that file? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[PR] Update javascript.adoc (hop)

2023-11-21 Thread via GitHub
Mattang-Dan opened a new pull request, #3442: URL: https://github.com/apache/hop/pull/3442 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution

Re: [PR] Fixed flaky test due to use of HashSet in DatabaseLookupMetaTest#testProvidesModelerMeta (hop)

2023-11-21 Thread via GitHub
hansva merged PR #3422: URL: https://github.com/apache/hop/pull/3422 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hop.apache.org

Re: [PR] Fixed flaky test in SvgGraphics2DTest (hop)

2023-11-21 Thread via GitHub
hansva merged PR #3421: URL: https://github.com/apache/hop/pull/3421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hop.apache.org

Re: [PR] Fixed flaky test in SvgGraphics2DTest (hop)

2023-11-21 Thread via GitHub
hansva commented on PR #3421: URL: https://github.com/apache/hop/pull/3421#issuecomment-1821120889 Thank you for the contributions @wang3820 ! much appreciated! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [I] [Task]: HTTP review (hop)

2023-11-21 Thread via GitHub
hansva commented on issue #3416: URL: https://github.com/apache/hop/issues/3416#issuecomment-1821012241 If we can combine the code bases and create some shared classes between the action and the transforms then we could take it into account. -- This is an automated message from the

Re: [I] [Task]: HTTP review (hop)

2023-11-21 Thread via GitHub
enricomariam42 commented on issue #3416: URL: https://github.com/apache/hop/issues/3416#issuecomment-1821007642 Please also take a look at https://github.com/apache/hop/issues/3440 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [I] [Bug]: 'Open File' dialog when editing configuration files in Environment properties prepends CWD of client, doesn't resolve variables (hop)

2023-11-21 Thread via GitHub
hansva commented on issue #3324: URL: https://github.com/apache/hop/issues/3324#issuecomment-1820779420 That expansion also works on my system and it uses the correct variable value... ``` hans@MacBook-Pro-2:~|⇒ echo $HOP_CONFIG_FOLDER /Users/hans/config ```

Re: [I] [Bug]: 'Open File' dialog when editing configuration files in Environment properties prepends CWD of client, doesn't resolve variables (hop)

2023-11-21 Thread via GitHub
kranskydog commented on issue #3324: URL: https://github.com/apache/hop/issues/3324#issuecomment-1820705173 As far as I am aware, there is only one place it needs to be set - the user's environment before they launch the GUI, or the environment of the application server for Hop Web

Re: [PR] updated doc headings, var references and other minor issues #3434 (hop)

2023-11-21 Thread via GitHub
hansva commented on PR #3437: URL: https://github.com/apache/hop/pull/3437#issuecomment-1820539321 PR #3418 snuck into this one too, so only merge after checking that one -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] instructions to update hop script classpaths #3323 (hop)

2023-11-21 Thread via GitHub
hansva commented on PR #3433: URL: https://github.com/apache/hop/pull/3433#issuecomment-1820538019 PR #3418 snuck into this one too, so only merge after checking that one -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] fix #3417 (hop)

2023-11-21 Thread via GitHub
hansva merged PR #3426: URL: https://github.com/apache/hop/pull/3426 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hop.apache.org

Re: [I] [Bug]: Excel Input eats incoming fields, but still passes the metadata for them downstream (as if they still exist) (hop)

2023-11-21 Thread via GitHub
sramazzina commented on issue #3221: URL: https://github.com/apache/hop/issues/3221#issuecomment-1820440862 Ciao @usbrandon thanks for your answer. The fix is almost done I was just waiting your confirmation to complete it. I will let you know when it will be ready so that you can test it.