[PR] Update getvariable.adoc (hop)

2023-11-29 Thread via GitHub
Mattang-Dan opened a new pull request, #3468: URL: https://github.com/apache/hop/pull/3468 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution quick

Re: [I] [Feature Request]: Change the Execution Information icon (hop)

2023-11-29 Thread via GitHub
simonaubertbd commented on issue #3464: URL: https://github.com/apache/hop/issues/3464#issuecomment-1832471137 Hello @nadment Well, you're fast ! Thanks ! Personnaly, I would be happy with either the 1st or the 3rd (they drive an idea of time, contrary to the 2nd). Best regards,

Re: [I] [Feature Request]: Database plugin query comment injection (hop)

2023-11-29 Thread via GitHub
tpickle-amazon commented on issue #3261: URL: https://github.com/apache/hop/issues/3261#issuecomment-1832460760 One potential approach might be to use the `ClientInfo` functionality of the JDBC: https://docs.oracle.com/javase/8/docs/api/java/sql/Connection.html#setClientInfo-java.util.Prope

Re: [I] [Feature Request]: Database plugin query comment injection (hop)

2023-11-29 Thread via GitHub
tpickle-amazon commented on issue #3261: URL: https://github.com/apache/hop/issues/3261#issuecomment-1832436972 >Is this needed for insert/update/delete/lookup/... as well? we are mostly concerned with read queries, so insert/update/delete are probably not needed for now, but lookup would

Re: [I] [Feature Request]: Change the Execution Information icon (hop)

2023-11-29 Thread via GitHub
nadment commented on issue #3464: URL: https://github.com/apache/hop/issues/3464#issuecomment-1832322890 Here are 2 proposals ![execution-2](https://github.com/apache/hop/assets/39568358/eb6a6956-8ada-4be9-b965-6b33f9cf6db6) ![execution-1](https://github.com/apache/hop/assets/3956

[PR] Update writetolog.adoc (hop)

2023-11-29 Thread via GitHub
Mattang-Dan opened a new pull request, #3467: URL: https://github.com/apache/hop/pull/3467 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution quick

[PR] Update formula.adoc (hop)

2023-11-29 Thread via GitHub
Mattang-Dan opened a new pull request, #3466: URL: https://github.com/apache/hop/pull/3466 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution quick

Re: [I] [Feature Request]: An improved method to resolve variable expressions (hop)

2023-11-29 Thread via GitHub
mattcasters commented on issue #3454: URL: https://github.com/apache/hop/issues/3454#issuecomment-1831542631 The idea to have a new 'Lookup' plugin type in core is meant to allow all plugins to contribute and use without too many class loader issues. It also allows us to integrate with met

Re: [I] [Feature Request]: An improved method to resolve variable expressions (hop)

2023-11-29 Thread via GitHub
mattcasters commented on issue #3454: URL: https://github.com/apache/hop/issues/3454#issuecomment-1831533959 That doesn't mean the other ideas aren't valid. Working with a prefix does show the intent of the variable replacement clearly. `${AES:SOME_SECRET}` is pretty clear once you know w