hansva commented on PR #3878:
URL: https://github.com/apache/hop/pull/3878#issuecomment-2097758820
right, a mixup happened in the issue number, for reference this is for #3867
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
hansva merged PR #3878:
URL: https://github.com/apache/hop/pull/3878
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hop.apache.org
sramazzina commented on PR #3878:
URL: https://github.com/apache/hop/pull/3878#issuecomment-2097649857
Yeah I understand and I agree with you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
hansva commented on PR #3878:
URL: https://github.com/apache/hop/pull/3878#issuecomment-2097629033
As stated in my previous comment, nothing you can do about it in this
ticket. Just some personal frustration flowing out.
Thanks for the change LGTM
--
This is an automated message from
sramazzina commented on PR #3878:
URL: https://github.com/apache/hop/pull/3878#issuecomment-2097615165
@hansva, unfortunately, the only thing I'm able to fix is the label.
Multiple selection (that I agree with you is not completed in the
EnterSelectionDialog therefore it cannot be used.
sramazzina commented on PR #3878:
URL: https://github.com/apache/hop/pull/3878#issuecomment-2095492004
@hansva sorry for the wrong label name I've not noticed :-(. I will change it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
hansva commented on PR #3878:
URL: https://github.com/apache/hop/pull/3878#issuecomment-2093077942
TBH... I hate the dialog you used.
there are multiple things wrong with that dialog on MacOS:
- It expands beyond the reach of your window
- when closing it with escape Hop just moves
sramazzina opened a new pull request, #3878:
URL: https://github.com/apache/hop/pull/3878
fix #3867 - Unit test action: dialog improvement
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and
