Re: [PR] fix #3540 (hop)

2024-02-26 Thread via GitHub
usbrandon merged PR #3659: URL: https://github.com/apache/hop/pull/3659 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] fix #3540 (hop)

2024-02-23 Thread via GitHub
sramazzina commented on PR #3659: URL: https://github.com/apache/hop/pull/3659#issuecomment-1962103362 I'm sorry I wrote about it on mattermost. I will copy the message here: _"I made some tests this morning and the delete statement do not throws any exception if the target file

Re: [PR] fix #3540 (hop)

2024-02-22 Thread via GitHub
usbrandon commented on PR #3659: URL: https://github.com/apache/hop/pull/3659#issuecomment-1960527123 Waiting on an update for the case that the file does not exist, but the box is checked. Making sure a null object is not deleted. -- This is an automated message from the Apache Git

Re: [PR] fix #3540 (hop)

2024-02-22 Thread via GitHub
sramazzina commented on PR #3659: URL: https://github.com/apache/hop/pull/3659#issuecomment-1959310877 Basically the overwrite happened without any changes too, I was unable to reproduce the error the reporter experienced. But by performing the test I experienced another issue and that was

[PR] fix #3540 (hop)

2024-02-21 Thread via GitHub
sramazzina opened a new pull request, #3659: URL: https://github.com/apache/hop/pull/3659 fix #3540 copy transform does not overwrite target file Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly