[GitHub] [incubator-iceberg] rdsr edited a comment on issue #227: ORC column map fix

rdsr edited a comment on issue #227: ORC column map fix URL: https://github.com/apache/incubator-iceberg/pull/227#issuecomment-504712756 > are you proposing that we attach an alternative schema to a data file? If so, why not just write the JSON form of the Iceberg schema? The mechani

[GitHub] [incubator-iceberg] rdsr edited a comment on issue #227: ORC column map fix

rdsr edited a comment on issue #227: ORC column map fix URL: https://github.com/apache/incubator-iceberg/pull/227#issuecomment-504712756 > are you proposing that we attach an alternative schema to a data file? If so, why not just write the JSON form of the Iceberg schema? The mechani

[GitHub] [incubator-iceberg] rdsr commented on issue #227: ORC column map fix

rdsr commented on issue #227: ORC column map fix URL: https://github.com/apache/incubator-iceberg/pull/227#issuecomment-504712756 > are you proposing that we attach an alternative schema to a data file? If so, why not just write the JSON form of the Iceberg schema? The mechanism to persi

[GitHub] [incubator-iceberg] rdblue commented on issue #199: ORC metrics

rdblue commented on issue #199: ORC metrics URL: https://github.com/apache/incubator-iceberg/pull/199#issuecomment-504707382 @edgarRd, is this ready for another round of reviews, or should we merge #227 first? This is an auto

[GitHub] [incubator-iceberg] rdblue commented on issue #226: Apply Baseline plugin to iceberg-spark

rdblue commented on issue #226: Apply Baseline plugin to iceberg-spark URL: https://github.com/apache/incubator-iceberg/pull/226#issuecomment-504707336 I had some minor comments, but I don't see any bugs introduced by this. Thanks @aokolnychyi! I think the choices you made sound good

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #226: Apply Baseline plugin to iceberg-spark

rdblue commented on a change in pull request #226: Apply Baseline plugin to iceberg-spark URL: https://github.com/apache/incubator-iceberg/pull/226#discussion_r296460634 ## File path: spark/src/main/java/org/apache/iceberg/spark/PruneColumnsWithReordering.java ## @@ -72,7

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #226: Apply Baseline plugin to iceberg-spark

rdblue commented on a change in pull request #226: Apply Baseline plugin to iceberg-spark URL: https://github.com/apache/incubator-iceberg/pull/226#discussion_r296460624 ## File path: spark/src/jmh/java/org/apache/iceberg/spark/source/IcebergSourceBenchmark.java ## @@ -12

[GitHub] [incubator-iceberg] rdblue commented on issue #218: Fix uncommitted file clean-up in transactions

rdblue commented on issue #218: Fix uncommitted file clean-up in transactions URL: https://github.com/apache/incubator-iceberg/pull/218#issuecomment-504706905 @danielcweeks, when you have time could you review this? This is an

[GitHub] [incubator-iceberg] rdblue merged pull request #231: Remove usage of deprecated Schema.Field constructor

rdblue merged pull request #231: Remove usage of deprecated Schema.Field constructor URL: https://github.com/apache/incubator-iceberg/pull/231 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [incubator-iceberg] electrum opened a new pull request #231: Remove usage of deprecated Schema.Field constructor

electrum opened a new pull request #231: Remove usage of deprecated Schema.Field constructor URL: https://github.com/apache/incubator-iceberg/pull/231 Without the cast, the deprecated variant that takes JsonNode is chosen by Java's overload resolution because it is "more specific".

[GitHub] [incubator-iceberg] rdblue merged pull request #220: Support parsing of special characters in TypeToSchema visitor

rdblue merged pull request #220: Support parsing of special characters in TypeToSchema visitor URL: https://github.com/apache/incubator-iceberg/pull/220 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-iceberg] rdblue commented on issue #227: ORC column map fix

rdblue commented on issue #227: ORC column map fix URL: https://github.com/apache/incubator-iceberg/pull/227#issuecomment-504704779 @rdsr, are you proposing that we attach an alternative schema to a data file? If so, why not just write the JSON form of the Iceberg schema? I like the idea t

[GitHub] [incubator-iceberg] rdblue commented on issue #230: Use JDK StandardCharsets instead of commons-io

rdblue commented on issue #230: Use JDK StandardCharsets instead of commons-io URL: https://github.com/apache/incubator-iceberg/pull/230#issuecomment-504704652 Thanks for fixing this, @electrum! I didn't realize we accidentally used commons-io. -

[GitHub] [incubator-iceberg] rdblue merged pull request #230: Use JDK StandardCharsets instead of commons-io

rdblue merged pull request #230: Use JDK StandardCharsets instead of commons-io URL: https://github.com/apache/incubator-iceberg/pull/230 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [incubator-iceberg] rdblue merged pull request #228: Use Iceberg tables as sinks in Spark Structured Streaming

rdblue merged pull request #228: Use Iceberg tables as sinks in Spark Structured Streaming URL: https://github.com/apache/incubator-iceberg/pull/228 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-iceberg] rdblue closed issue #178: Use Iceberg tables as sinks for Spark Structured Streaming

rdblue closed issue #178: Use Iceberg tables as sinks for Spark Structured Streaming URL: https://github.com/apache/incubator-iceberg/issues/178 This is an automated message from the Apache Git Service. To respond to the mes