[GitHub] [incubator-iceberg] chenjunjiedada closed issue #415: supports unpartitioned table in partitionDF

chenjunjiedada closed issue #415: supports unpartitioned table in partitionDF URL: https://github.com/apache/incubator-iceberg/issues/415 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [incubator-iceberg] chenjunjiedada commented on issue #415: supports unpartitioned table in partitionDF

chenjunjiedada commented on issue #415: supports unpartitioned table in partitionDF URL: https://github.com/apache/incubator-iceberg/issues/415#issuecomment-525157629 Close this first, will add some doc to `partitionDF` to address it. --

[GitHub] [incubator-iceberg] jun-he commented on a change in pull request #357: Add in and not in predicates

jun-he commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r317910185 ## File path: api/src/main/java/org/apache/iceberg/expressions/ExpressionVisitors.java ## @@ -51,6 +53,10 @@ publ

[GitHub] [incubator-iceberg] moulimukherjee commented on a change in pull request #416: Adding docs on how to use custom catalog with iceberg

moulimukherjee commented on a change in pull request #416: Adding docs on how to use custom catalog with iceberg URL: https://github.com/apache/incubator-iceberg/pull/416#discussion_r317856977 ## File path: site/docs/custom-catalog.md ## @@ -0,0 +1,149 @@ +# Custom Catalog

[GitHub] [incubator-iceberg] moulimukherjee commented on a change in pull request #416: Adding docs on how to use custom catalog with iceberg

moulimukherjee commented on a change in pull request #416: Adding docs on how to use custom catalog with iceberg URL: https://github.com/apache/incubator-iceberg/pull/416#discussion_r317856977 ## File path: site/docs/custom-catalog.md ## @@ -0,0 +1,149 @@ +# Custom Catalog

[GitHub] [incubator-iceberg] moulimukherjee commented on issue #416: Adding docs on how to use custom catalog with iceberg

moulimukherjee commented on issue #416: Adding docs on how to use custom catalog with iceberg URL: https://github.com/apache/incubator-iceberg/pull/416#issuecomment-525092405 PTAL again @rdblue @aokolnychyi This is an automa

[GitHub] [incubator-iceberg] moulimukherjee commented on a change in pull request #416: Adding docs on how to use custom catalog with iceberg

moulimukherjee commented on a change in pull request #416: Adding docs on how to use custom catalog with iceberg URL: https://github.com/apache/incubator-iceberg/pull/416#discussion_r317856128 ## File path: site/docs/custom-catalog.md ## @@ -0,0 +1,134 @@ +# Custom Catalog

[GitHub] [incubator-iceberg] moulimukherjee commented on a change in pull request #416: Adding docs on how to use custom catalog with iceberg

moulimukherjee commented on a change in pull request #416: Adding docs on how to use custom catalog with iceberg URL: https://github.com/apache/incubator-iceberg/pull/416#discussion_r317855049 ## File path: site/docs/custom-catalog.md ## @@ -0,0 +1,134 @@ +# Custom Catalog

[GitHub] [incubator-iceberg] moulimukherjee commented on a change in pull request #416: Adding docs on how to use custom catalog with iceberg

moulimukherjee commented on a change in pull request #416: Adding docs on how to use custom catalog with iceberg URL: https://github.com/apache/incubator-iceberg/pull/416#discussion_r317851135 ## File path: site/docs/custom-catalog.md ## @@ -0,0 +1,134 @@ +# Custom Catalog

[GitHub] [incubator-iceberg] moulimukherjee commented on a change in pull request #416: Adding docs on how to use custom catalog with iceberg

moulimukherjee commented on a change in pull request #416: Adding docs on how to use custom catalog with iceberg URL: https://github.com/apache/incubator-iceberg/pull/416#discussion_r317851046 ## File path: site/docs/custom-catalog.md ## @@ -0,0 +1,134 @@ +# Custom Catalog

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #388: Handle rollback in snapshot expiration

rdblue commented on a change in pull request #388: Handle rollback in snapshot expiration URL: https://github.com/apache/incubator-iceberg/pull/388#discussion_r317843266 ## File path: core/src/main/java/org/apache/iceberg/RemoveSnapshots.java ## @@ -120,56 +123,128 @@ publ

[GitHub] [incubator-iceberg] Parth-Brahmbhatt commented on a change in pull request #388: Handle rollback in snapshot expiration

Parth-Brahmbhatt commented on a change in pull request #388: Handle rollback in snapshot expiration URL: https://github.com/apache/incubator-iceberg/pull/388#discussion_r317838958 ## File path: core/src/main/java/org/apache/iceberg/RemoveSnapshots.java ## @@ -120,56 +123,1

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #398: Push down StringStartsWith in Spark IcebergSource

rdblue commented on a change in pull request #398: Push down StringStartsWith in Spark IcebergSource URL: https://github.com/apache/incubator-iceberg/pull/398#discussion_r317842139 ## File path: spark/src/main/java/org/apache/iceberg/spark/SparkFilters.java ## @@ -153,6 +1

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #398: Push down StringStartsWith in Spark IcebergSource

rdblue commented on a change in pull request #398: Push down StringStartsWith in Spark IcebergSource URL: https://github.com/apache/incubator-iceberg/pull/398#discussion_r317841160 ## File path: api/src/test/java/org/apache/iceberg/expressions/TestInclusiveMetricsEvaluator.java ##

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #398: Push down StringStartsWith in Spark IcebergSource

rdblue commented on a change in pull request #398: Push down StringStartsWith in Spark IcebergSource URL: https://github.com/apache/incubator-iceberg/pull/398#discussion_r317841001 ## File path: api/src/test/java/org/apache/iceberg/expressions/TestInclusiveMetricsEvaluator.java ##

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #398: Push down StringStartsWith in Spark IcebergSource

rdblue commented on a change in pull request #398: Push down StringStartsWith in Spark IcebergSource URL: https://github.com/apache/incubator-iceberg/pull/398#discussion_r317840857 ## File path: api/src/test/java/org/apache/iceberg/expressions/TestInclusiveMetricsEvaluator.java ##

[GitHub] [incubator-iceberg] rdblue opened a new pull request #418: Add missing manifest cleanup tests

rdblue opened a new pull request #418: Add missing manifest cleanup tests URL: https://github.com/apache/incubator-iceberg/pull/418 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #398: Push down StringStartsWith in Spark IcebergSource

rdblue commented on a change in pull request #398: Push down StringStartsWith in Spark IcebergSource URL: https://github.com/apache/incubator-iceberg/pull/398#discussion_r317836527 ## File path: parquet/src/main/java/org/apache/iceberg/parquet/ParquetDictionaryRowGroupFilter.java

[GitHub] [incubator-iceberg] moulimukherjee commented on a change in pull request #416: Adding docs on how to use custom catalog with iceberg

moulimukherjee commented on a change in pull request #416: Adding docs on how to use custom catalog with iceberg URL: https://github.com/apache/incubator-iceberg/pull/416#discussion_r317833163 ## File path: site/docs/custom-catalog.md ## @@ -0,0 +1,134 @@ +# Custom Catalog

[GitHub] [incubator-iceberg] rdblue closed issue #261: Support create and replace transactions in Catalog

rdblue closed issue #261: Support create and replace transactions in Catalog URL: https://github.com/apache/incubator-iceberg/issues/261 This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [incubator-iceberg] rdblue merged pull request #362: Support create and replace transactions in Catalog

rdblue merged pull request #362: Support create and replace transactions in Catalog URL: https://github.com/apache/incubator-iceberg/pull/362 This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [incubator-iceberg] rdblue commented on issue #362: Support create and replace transactions in Catalog

rdblue commented on issue #362: Support create and replace transactions in Catalog URL: https://github.com/apache/incubator-iceberg/pull/362#issuecomment-525064046 +1 Thanks for fixing this, @aokolnychyi! This is an au

[GitHub] [incubator-iceberg] shardulm94 opened a new issue #417: Adding support for time-based partitioning on long column type

shardulm94 opened a new issue #417: Adding support for time-based partitioning on long column type URL: https://github.com/apache/incubator-iceberg/issues/417 We have datasets which store milliseconds since epoch as a long column type. This column is currently being used for time-based par

[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #416: Adding docs on how to use custom catalog with iceberg

aokolnychyi commented on a change in pull request #416: Adding docs on how to use custom catalog with iceberg URL: https://github.com/apache/incubator-iceberg/pull/416#discussion_r317827313 ## File path: site/docs/custom-catalog.md ## @@ -0,0 +1,134 @@ +# Custom Catalog Im

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #416: Adding docs on how to use custom catalog with iceberg

rdblue commented on a change in pull request #416: Adding docs on how to use custom catalog with iceberg URL: https://github.com/apache/incubator-iceberg/pull/416#discussion_r317824379 ## File path: site/docs/custom-catalog.md ## @@ -0,0 +1,134 @@ +# Custom Catalog Impleme

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #416: Adding docs on how to use custom catalog with iceberg

rdblue commented on a change in pull request #416: Adding docs on how to use custom catalog with iceberg URL: https://github.com/apache/incubator-iceberg/pull/416#discussion_r317824181 ## File path: site/docs/custom-catalog.md ## @@ -0,0 +1,134 @@ +# Custom Catalog Impleme

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #416: Adding docs on how to use custom catalog with iceberg

rdblue commented on a change in pull request #416: Adding docs on how to use custom catalog with iceberg URL: https://github.com/apache/incubator-iceberg/pull/416#discussion_r317823840 ## File path: site/docs/custom-catalog.md ## @@ -0,0 +1,134 @@ +# Custom Catalog Impleme

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #416: Adding docs on how to use custom catalog with iceberg

rdblue commented on a change in pull request #416: Adding docs on how to use custom catalog with iceberg URL: https://github.com/apache/incubator-iceberg/pull/416#discussion_r317822579 ## File path: site/docs/custom-catalog.md ## @@ -0,0 +1,134 @@ +# Custom Catalog Impleme

[GitHub] [incubator-iceberg] moulimukherjee commented on a change in pull request #416: Adding docs on how to use custom catalog with iceberg

moulimukherjee commented on a change in pull request #416: Adding docs on how to use custom catalog with iceberg URL: https://github.com/apache/incubator-iceberg/pull/416#discussion_r317815623 ## File path: site/docs/custom-catalog.md ## @@ -0,0 +1,138 @@ +# Custom Catalog

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #362: Support create and replace transactions in Catalog

rdblue commented on a change in pull request #362: Support create and replace transactions in Catalog URL: https://github.com/apache/incubator-iceberg/pull/362#discussion_r317815165 ## File path: core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java ## @

[GitHub] [incubator-iceberg] moulimukherjee commented on a change in pull request #416: Adding docs on how to use custom catalog with iceberg

moulimukherjee commented on a change in pull request #416: Adding docs on how to use custom catalog with iceberg URL: https://github.com/apache/incubator-iceberg/pull/416#discussion_r317814151 ## File path: site/docs/custom-catalog.md ## @@ -0,0 +1,138 @@ +# Custom Catalog

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #416: Adding docs on how to use custom catalog with iceberg

rdblue commented on a change in pull request #416: Adding docs on how to use custom catalog with iceberg URL: https://github.com/apache/incubator-iceberg/pull/416#discussion_r317813862 ## File path: site/docs/custom-catalog.md ## @@ -0,0 +1,138 @@ +# Custom Catalog Impleme

[GitHub] [incubator-iceberg] moulimukherjee opened a new pull request #416: Adding docs on how to use custom catalog with iceberg

moulimukherjee opened a new pull request #416: Adding docs on how to use custom catalog with iceberg URL: https://github.com/apache/incubator-iceberg/pull/416 Adding docs on how to use custom catalog with iceberg r? @rdblue --

[GitHub] [incubator-iceberg] rdblue commented on issue #351: Extend Iceberg with a way to overwrite files for eager updates/deletes

rdblue commented on issue #351: Extend Iceberg with a way to overwrite files for eager updates/deletes URL: https://github.com/apache/incubator-iceberg/pull/351#issuecomment-525039053 +1. I'm going to merge this. Thanks for the thorough unit tests, those look great.

[GitHub] [incubator-iceberg] rdblue merged pull request #351: Extend Iceberg with a way to overwrite files for eager updates/deletes

rdblue merged pull request #351: Extend Iceberg with a way to overwrite files for eager updates/deletes URL: https://github.com/apache/incubator-iceberg/pull/351 This is an automated message from the Apache Git Service. To r

[GitHub] [incubator-iceberg] rdblue closed issue #316: Provide an API to modify records within files

rdblue closed issue #316: Provide an API to modify records within files URL: https://github.com/apache/incubator-iceberg/issues/316 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #351: Extend Iceberg with a way to overwrite files for eager updates/deletes

rdblue commented on a change in pull request #351: Extend Iceberg with a way to overwrite files for eager updates/deletes URL: https://github.com/apache/incubator-iceberg/pull/351#discussion_r317800614 ## File path: core/src/main/java/org/apache/iceberg/OverwriteData.java #

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #351: Extend Iceberg with a way to overwrite files for eager updates/deletes

rdblue commented on a change in pull request #351: Extend Iceberg with a way to overwrite files for eager updates/deletes URL: https://github.com/apache/incubator-iceberg/pull/351#discussion_r317799344 ## File path: core/src/main/java/org/apache/iceberg/OverwriteData.java #

[GitHub] [incubator-iceberg] aokolnychyi commented on issue #351: Extend Iceberg with a way to overwrite files for eager updates/deletes

aokolnychyi commented on issue #351: Extend Iceberg with a way to overwrite files for eager updates/deletes URL: https://github.com/apache/incubator-iceberg/pull/351#issuecomment-525028721 I've updated this PR but there are still a couple of open questions.

[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #351: Extend Iceberg with a way to overwrite files for eager updates/deletes

aokolnychyi commented on a change in pull request #351: Extend Iceberg with a way to overwrite files for eager updates/deletes URL: https://github.com/apache/incubator-iceberg/pull/351#discussion_r317793406 ## File path: api/src/main/java/org/apache/iceberg/expressions/InclusiveMet

[GitHub] [incubator-iceberg] aokolnychyi commented on issue #398: Push down StringStartsWith in Spark IcebergSource

aokolnychyi commented on issue #398: Push down StringStartsWith in Spark IcebergSource URL: https://github.com/apache/incubator-iceberg/pull/398#issuecomment-524985833 I've updated this PR to use `toByteBuffer` in `Literal`.

[GitHub] [incubator-iceberg] rdblue merged pull request #414: Add toByteBuffer to Literal

rdblue merged pull request #414: Add toByteBuffer to Literal URL: https://github.com/apache/incubator-iceberg/pull/414 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [incubator-iceberg] rdblue commented on issue #414: Add toByteBuffer to Literal

rdblue commented on issue #414: Add toByteBuffer to Literal URL: https://github.com/apache/incubator-iceberg/pull/414#issuecomment-524964776 +1. I'll merge this when tests pass. This is an automated message from the Apache Git

[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #414: Add toByteBuffer to Literal

aokolnychyi commented on a change in pull request #414: Add toByteBuffer to Literal URL: https://github.com/apache/incubator-iceberg/pull/414#discussion_r317723243 ## File path: api/src/main/java/org/apache/iceberg/expressions/Literal.java ## @@ -102,4 +102,8 @@ * @ret

[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #414: Add toByteBuffer to Literal

aokolnychyi commented on a change in pull request #414: Add toByteBuffer to Literal URL: https://github.com/apache/incubator-iceberg/pull/414#discussion_r317713814 ## File path: api/src/main/java/org/apache/iceberg/expressions/Literal.java ## @@ -102,4 +102,8 @@ * @ret

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #374: Migrate spark table to iceberg table

rdblue commented on a change in pull request #374: Migrate spark table to iceberg table URL: https://github.com/apache/incubator-iceberg/pull/374#discussion_r317712572 ## File path: spark/src/main/scala/org/apache/iceberg/spark/SparkTableUtil.scala ## @@ -297,5 +302,81 @@

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #374: Migrate spark table to iceberg table

rdblue commented on a change in pull request #374: Migrate spark table to iceberg table URL: https://github.com/apache/incubator-iceberg/pull/374#discussion_r317712345 ## File path: spark/src/main/scala/org/apache/iceberg/spark/SparkTableUtil.scala ## @@ -297,5 +302,81 @@

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #374: Migrate spark table to iceberg table

rdblue commented on a change in pull request #374: Migrate spark table to iceberg table URL: https://github.com/apache/incubator-iceberg/pull/374#discussion_r317711705 ## File path: spark/src/main/scala/org/apache/iceberg/spark/SparkTableUtil.scala ## @@ -297,5 +302,81 @@

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #374: Migrate spark table to iceberg table

rdblue commented on a change in pull request #374: Migrate spark table to iceberg table URL: https://github.com/apache/incubator-iceberg/pull/374#discussion_r317711446 ## File path: spark/src/main/scala/org/apache/iceberg/spark/SparkTableUtil.scala ## @@ -297,5 +302,81 @@

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #374: Migrate spark table to iceberg table

rdblue commented on a change in pull request #374: Migrate spark table to iceberg table URL: https://github.com/apache/incubator-iceberg/pull/374#discussion_r317710889 ## File path: spark/src/main/scala/org/apache/iceberg/spark/SparkTableUtil.scala ## @@ -297,5 +302,81 @@

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #374: Migrate spark table to iceberg table

rdblue commented on a change in pull request #374: Migrate spark table to iceberg table URL: https://github.com/apache/incubator-iceberg/pull/374#discussion_r317711151 ## File path: spark/src/main/scala/org/apache/iceberg/spark/SparkTableUtil.scala ## @@ -297,5 +302,81 @@

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #374: Migrate spark table to iceberg table

rdblue commented on a change in pull request #374: Migrate spark table to iceberg table URL: https://github.com/apache/incubator-iceberg/pull/374#discussion_r317710578 ## File path: spark/src/main/scala/org/apache/iceberg/spark/SparkTableUtil.scala ## @@ -297,5 +302,81 @@

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #374: Migrate spark table to iceberg table

rdblue commented on a change in pull request #374: Migrate spark table to iceberg table URL: https://github.com/apache/incubator-iceberg/pull/374#discussion_r317708705 ## File path: spark/src/main/scala/org/apache/iceberg/spark/SparkTableUtil.scala ## @@ -297,5 +301,81 @@

[GitHub] [incubator-iceberg] rdblue commented on issue #412: Use null counts in metrics evaluators

rdblue commented on issue #412: Use null counts in metrics evaluators URL: https://github.com/apache/incubator-iceberg/pull/412#issuecomment-524949101 Thanks @aokolnychyi! This is an automated message from the Apache Git Servi

[GitHub] [incubator-iceberg] rdblue merged pull request #412: Use null counts in metrics evaluators

rdblue merged pull request #412: Use null counts in metrics evaluators URL: https://github.com/apache/incubator-iceberg/pull/412 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-iceberg] rdblue closed issue #408: Use null counts in metrics evaluators

rdblue closed issue #408: Use null counts in metrics evaluators URL: https://github.com/apache/incubator-iceberg/issues/408 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-iceberg] rdblue commented on issue #414: Add toByteBuffer to Literal

rdblue commented on issue #414: Add toByteBuffer to Literal URL: https://github.com/apache/incubator-iceberg/pull/414#issuecomment-524945345 Thanks @aokolnychyi! I just found a couple of minor things to fix. This is an automat

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #414: Add toByteBuffer to Literal

rdblue commented on a change in pull request #414: Add toByteBuffer to Literal URL: https://github.com/apache/incubator-iceberg/pull/414#discussion_r317701995 ## File path: api/src/main/java/org/apache/iceberg/expressions/Literal.java ## @@ -102,4 +102,8 @@ * @return a

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #414: Add toByteBuffer to Literal

rdblue commented on a change in pull request #414: Add toByteBuffer to Literal URL: https://github.com/apache/incubator-iceberg/pull/414#discussion_r317701749 ## File path: api/src/main/java/org/apache/iceberg/expressions/Literal.java ## @@ -102,4 +102,8 @@ * @return a

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #414: Add toByteBuffer to Literal

rdblue commented on a change in pull request #414: Add toByteBuffer to Literal URL: https://github.com/apache/incubator-iceberg/pull/414#discussion_r317700813 ## File path: api/src/main/java/org/apache/iceberg/expressions/Literals.java ## @@ -94,6 +95,7 @@ private Literals(

[GitHub] [incubator-iceberg] rdblue merged pull request #350: Add dropTable purge option to Catalog API

rdblue merged pull request #350: Add dropTable purge option to Catalog API URL: https://github.com/apache/incubator-iceberg/pull/350 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #406: Throw an exception when using Iceberg with Spark embedded metastore

rdblue commented on a change in pull request #406: Throw an exception when using Iceberg with Spark embedded metastore URL: https://github.com/apache/incubator-iceberg/pull/406#discussion_r317698991 ## File path: hive/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java #

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #406: Throw an exception when using Iceberg with Spark embedded metastore

rdblue commented on a change in pull request #406: Throw an exception when using Iceberg with Spark embedded metastore URL: https://github.com/apache/incubator-iceberg/pull/406#discussion_r317698659 ## File path: hive/src/main/java/org/apache/iceberg/hive/HiveClientPool.java ##

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #406: Throw an exception when using Iceberg with Spark embedded metastore

rdblue commented on a change in pull request #406: Throw an exception when using Iceberg with Spark embedded metastore URL: https://github.com/apache/incubator-iceberg/pull/406#discussion_r317698081 ## File path: hive/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java #

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #406: Throw an exception when using Iceberg with Spark embedded metastore

rdblue commented on a change in pull request #406: Throw an exception when using Iceberg with Spark embedded metastore URL: https://github.com/apache/incubator-iceberg/pull/406#discussion_r317697046 ## File path: hive/src/main/java/org/apache/iceberg/hive/HiveClientPool.java ##

[GitHub] [incubator-iceberg] rdblue commented on issue #280: Add persistent IDs to partition fields

rdblue commented on issue #280: Add persistent IDs to partition fields URL: https://github.com/apache/incubator-iceberg/issues/280#issuecomment-524938283 @manishmalhotrawork, those IDs have different contexts. The source ID in a partition field is the ID of the source data column in the ta

[GitHub] [incubator-iceberg] manishmalhotrawork edited a comment on issue #280: Add persistent IDs to partition fields

manishmalhotrawork edited a comment on issue #280: Add persistent IDs to partition fields URL: https://github.com/apache/incubator-iceberg/issues/280#issuecomment-524733183 @rdblue thanks for the answer. Curious on the flow and as how fieldId are maintained in PartitionSpec vs Table Sc

[GitHub] [incubator-iceberg] rdblue commented on issue #412: Use null counts in metrics evaluators

rdblue commented on issue #412: Use null counts in metrics evaluators URL: https://github.com/apache/incubator-iceberg/pull/412#issuecomment-524914156 > Is the current implementation of eq in StrictMetricsEvaluator safe? What if we have truncated min/max values? I think the bounds ch

[GitHub] [incubator-iceberg] aokolnychyi commented on issue #412: Use null counts in metrics evaluators

aokolnychyi commented on issue #412: Use null counts in metrics evaluators URL: https://github.com/apache/incubator-iceberg/pull/412#issuecomment-524900800 @rdblue not directly related to this PR, but is the current implementation of `eq` in `StrictMetricsEvaluator` safe? What if we have tr

[GitHub] [incubator-iceberg] chenjunjiedada opened a new issue #415: supports unpartitioned table in partitionDF

chenjunjiedada opened a new issue #415: supports unpartitioned table in partitionDF URL: https://github.com/apache/incubator-iceberg/issues/415 partitionDF throws exception when executing on unpartitioned table, please see following exception: ``` org.apache.hadoop.hive.ql.metadata.H

[GitHub] [incubator-iceberg] jerryshao commented on issue #406: Throw an exception when using Iceberg with Spark embedded metastore

jerryshao commented on issue #406: Throw an exception when using Iceberg with Spark embedded metastore URL: https://github.com/apache/incubator-iceberg/pull/406#issuecomment-524843479 @rdblue please help to take another look, thanks!