[GitHub] [incubator-iceberg] chenjunjiedada commented on issue #708: Bump Apache Parquet to 1.11.0

chenjunjiedada commented on issue #708: Bump Apache Parquet to 1.11.0 URL: https://github.com/apache/incubator-iceberg/pull/708#issuecomment-569855053 The public constructor of `ColumnChunkPageWriteStore` was removed in 1.11.0. @rdblue, we need to add back ctor in parquet or update class lo

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog'

rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog' URL: https://github.com/apache/incubator-iceberg/pull/688#discussion_r362068739 ## File path: hive/src/main/java/org/apache/iceberg/hive/HiveCatalog.java ###

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog'

rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog' URL: https://github.com/apache/incubator-iceberg/pull/688#discussion_r362068686 ## File path: hive/src/main/java/org/apache/iceberg/hive/HiveCatalog.java ###

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog'

rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog' URL: https://github.com/apache/incubator-iceberg/pull/688#discussion_r362067055 ## File path: hive/src/main/java/org/apache/iceberg/hive/HiveCatalog.java ###

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog'

rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog' URL: https://github.com/apache/incubator-iceberg/pull/688#discussion_r362067055 ## File path: hive/src/main/java/org/apache/iceberg/hive/HiveCatalog.java ###

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog'

rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog' URL: https://github.com/apache/incubator-iceberg/pull/688#discussion_r362066853 ## File path: hive/src/main/java/org/apache/iceberg/hive/HiveCatalog.java ###

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog'

rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog' URL: https://github.com/apache/incubator-iceberg/pull/688#discussion_r362065538 ## File path: hive/src/main/java/org/apache/iceberg/hive/HiveCatalog.java ###

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog'

rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog' URL: https://github.com/apache/incubator-iceberg/pull/688#discussion_r362065400 ## File path: hive/src/main/java/org/apache/iceberg/hive/HiveCatalog.java ###

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog'

rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog' URL: https://github.com/apache/incubator-iceberg/pull/688#discussion_r362064984 ## File path: hive/src/main/java/org/apache/iceberg/hive/HiveCatalog.java ###

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog'

rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog' URL: https://github.com/apache/incubator-iceberg/pull/688#discussion_r362064842 ## File path: hive/src/main/java/org/apache/iceberg/hive/HiveCatalog.java ###

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog'

rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog' URL: https://github.com/apache/incubator-iceberg/pull/688#discussion_r362064720 ## File path: hive/src/main/java/org/apache/iceberg/hive/HiveCatalog.java ###

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog'

rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog' URL: https://github.com/apache/incubator-iceberg/pull/688#discussion_r362064541 ## File path: hive/src/main/java/org/apache/iceberg/hive/HiveCatalog.java ###

[GitHub] [incubator-iceberg] rdblue edited a comment on issue #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog'

rdblue edited a comment on issue #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog' URL: https://github.com/apache/incubator-iceberg/pull/688#issuecomment-569759650 @shawnding, looks like you accidentally closed one of my review comments that wasn't addressed (

[GitHub] [incubator-iceberg] rdblue commented on issue #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog'

rdblue commented on issue #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog' URL: https://github.com/apache/incubator-iceberg/pull/688#issuecomment-569759650 @shawnding, looks like you accidentally closed one of my review comments that wasn't addressed: --

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog'

rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog' URL: https://github.com/apache/incubator-iceberg/pull/688#discussion_r362063574 ## File path: hive/src/main/java/org/apache/iceberg/hive/HiveCatalog.java ###

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog'

rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog' URL: https://github.com/apache/incubator-iceberg/pull/688#discussion_r362055324 ## File path: core/src/main/java/org/apache/iceberg/hadoop/HadoopCatalog.java

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog'

rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog' URL: https://github.com/apache/incubator-iceberg/pull/688#discussion_r362062571 ## File path: api/src/main/java/org/apache/iceberg/catalog/SupportsNamespaces.

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog'

rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog' URL: https://github.com/apache/incubator-iceberg/pull/688#discussion_r362059359 ## File path: api/src/main/java/org/apache/iceberg/catalog/SupportsNamespaces.

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog'

rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog' URL: https://github.com/apache/incubator-iceberg/pull/688#discussion_r362059010 ## File path: api/src/main/java/org/apache/iceberg/catalog/SupportsNamespaces.

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog'

rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog' URL: https://github.com/apache/incubator-iceberg/pull/688#discussion_r362058847 ## File path: core/src/main/java/org/apache/iceberg/hadoop/HadoopCatalog.java

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog'

rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog' URL: https://github.com/apache/incubator-iceberg/pull/688#discussion_r362058161 ## File path: core/src/main/java/org/apache/iceberg/hadoop/HadoopCatalog.java

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog'

rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog' URL: https://github.com/apache/incubator-iceberg/pull/688#discussion_r362058161 ## File path: core/src/main/java/org/apache/iceberg/hadoop/HadoopCatalog.java

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog'

rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog' URL: https://github.com/apache/incubator-iceberg/pull/688#discussion_r362057867 ## File path: core/src/main/java/org/apache/iceberg/hadoop/HadoopCatalog.java

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog'

rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog' URL: https://github.com/apache/incubator-iceberg/pull/688#discussion_r362057752 ## File path: core/src/main/java/org/apache/iceberg/hadoop/HadoopCatalog.java

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog'

rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog' URL: https://github.com/apache/incubator-iceberg/pull/688#discussion_r362057577 ## File path: core/src/main/java/org/apache/iceberg/hadoop/HadoopCatalog.java

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog'

rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog' URL: https://github.com/apache/incubator-iceberg/pull/688#discussion_r362057219 ## File path: core/src/main/java/org/apache/iceberg/hadoop/HadoopCatalog.java

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog'

rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog' URL: https://github.com/apache/incubator-iceberg/pull/688#discussion_r362057119 ## File path: core/src/main/java/org/apache/iceberg/hadoop/HadoopCatalog.java

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog'

rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog' URL: https://github.com/apache/incubator-iceberg/pull/688#discussion_r362056759 ## File path: core/src/main/java/org/apache/iceberg/hadoop/HadoopCatalog.java

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog'

rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog' URL: https://github.com/apache/incubator-iceberg/pull/688#discussion_r362056258 ## File path: core/src/main/java/org/apache/iceberg/hadoop/HadoopCatalog.java

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog'

rdblue commented on a change in pull request #688: [ISSUE #672] Add SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog' URL: https://github.com/apache/incubator-iceberg/pull/688#discussion_r362055324 ## File path: core/src/main/java/org/apache/iceberg/hadoop/HadoopCatalog.java

[GitHub] [incubator-iceberg] rdblue commented on issue #706: Add DeleteFrom support for Spark 3.0

rdblue commented on issue #706: Add DeleteFrom support for Spark 3.0 URL: https://github.com/apache/incubator-iceberg/pull/706#issuecomment-569748302 Thanks for reviewing, @chenjunjiedada and @jerryshao! This is an automated m

[GitHub] [incubator-iceberg] rdblue merged pull request #706: Add DeleteFrom support for Spark 3.0

rdblue merged pull request #706: Add DeleteFrom support for Spark 3.0 URL: https://github.com/apache/incubator-iceberg/pull/706 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [incubator-iceberg] rdblue merged pull request #718: Update projection in addedFiles to support appending

rdblue merged pull request #718: Update projection in addedFiles to support appending URL: https://github.com/apache/incubator-iceberg/pull/718 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [incubator-iceberg] rdblue commented on issue #719: Route to Hadoop table more strictly in IcebergSource#getTable()

rdblue commented on issue #719: Route to Hadoop table more strictly in IcebergSource#getTable() URL: https://github.com/apache/incubator-iceberg/pull/719#issuecomment-569747444 Thanks for looking into it more, @waterlx! I'm going to close this since you say it doesn't seem necessary to mak

[GitHub] [incubator-iceberg] rdblue closed pull request #719: Route to Hadoop table more strictly in IcebergSource#getTable()

rdblue closed pull request #719: Route to Hadoop table more strictly in IcebergSource#getTable() URL: https://github.com/apache/incubator-iceberg/pull/719 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-iceberg] rdblue commented on issue #710: Parquet changes for vectorized reads

rdblue commented on issue #710: Parquet changes for vectorized reads URL: https://github.com/apache/incubator-iceberg/pull/710#issuecomment-569747226 @samarthjain, thanks for fixing this! The remaining changes are minor so I merged this and we can fix them in a follow-up. -

[GitHub] [incubator-iceberg] rdblue merged pull request #710: Parquet changes for vectorized reads

rdblue merged pull request #710: Parquet changes for vectorized reads URL: https://github.com/apache/incubator-iceberg/pull/710 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #710: Parquet changes for vectorized reads

rdblue commented on a change in pull request #710: Parquet changes for vectorized reads URL: https://github.com/apache/incubator-iceberg/pull/710#discussion_r362050520 ## File path: parquet/src/main/java/org/apache/iceberg/parquet/ReadConf.java ## @@ -0,0 +1,203 @@ +/* + *

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #710: Parquet changes for vectorized reads

rdblue commented on a change in pull request #710: Parquet changes for vectorized reads URL: https://github.com/apache/incubator-iceberg/pull/710#discussion_r362050170 ## File path: parquet/src/main/java/org/apache/iceberg/parquet/VectorizedReader.java ## @@ -0,0 +1,51 @@

[GitHub] [incubator-iceberg] chenjunjiedada commented on issue #706: Add DeleteFrom support for Spark 3.0

chenjunjiedada commented on issue #706: Add DeleteFrom support for Spark 3.0 URL: https://github.com/apache/incubator-iceberg/pull/706#issuecomment-569663643 LGTM +1 This is an automated message from the Apache Git Service. To