shawnding commented on issue #683: Add Parquet user-defined predicates to push
down IN and NOT_IN
URL:
https://github.com/apache/incubator-iceberg/issues/683#issuecomment-571861691
OK
This is an automated message from the A
rdblue commented on issue #683: Add Parquet user-defined predicates to push
down IN and NOT_IN
URL:
https://github.com/apache/incubator-iceberg/issues/683#issuecomment-571854411
@shawnding, Sorry, this was implemented in #600. I'll close this.
Thanks to @jun-he for fixing this one!
shawnding commented on issue #683: Add Parquet user-defined predicates to push
down IN and NOT_IN
URL:
https://github.com/apache/incubator-iceberg/issues/683#issuecomment-571852531
HI @rdblue : Is this means implements the IN and NOT_IN predicates into
`ParquetMetricsRowGroupFilter` and `
manishmalhotrawork commented on issue #666: BaseRewriteManifests should keep
different manifest for different partitionSpec
URL: https://github.com/apache/incubator-iceberg/pull/666#issuecomment-571841185
thanks @rdblue, @aokolnychyi for the help to get it done :) !
---
rdblue commented on a change in pull request #678: Add Java code examples and
update site docs
URL: https://github.com/apache/incubator-iceberg/pull/678#discussion_r363918953
##
File path: site/docs/evolution.md
##
@@ -54,6 +54,11 @@ Iceberg uses unique IDs to track each c
Voltir opened a new pull request #727: Fix for #245
URL: https://github.com/apache/incubator-iceberg/pull/727
Shades google.common to fix a conflicting versions used by spark 2.4.x
This is an automated message from the Apache
rdblue commented on issue #227: ORC column map fix
URL: https://github.com/apache/incubator-iceberg/pull/227#issuecomment-571726987
+1
Thanks for all your work on this, @edgarRd! I'm merging it.
Also, thanks to @rdsr, @shardulm94, @lxynov, and @omalley for reviewing!
-
rdblue merged pull request #227: ORC column map fix
URL: https://github.com/apache/incubator-iceberg/pull/227
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
rdblue commented on a change in pull request #227: ORC column map fix
URL: https://github.com/apache/incubator-iceberg/pull/227#discussion_r363900772
##
File path: build.gradle
##
@@ -134,13 +134,19 @@ project(':iceberg-data') {
dependencies {
compile project(':iceb
Voltir commented on issue #245: java.lang.NoSuchMethodError:
com.google.common.base.Preconditions.checkArgument(ZLjava/lang/String;Ljava/lang/Object;)V
URL:
https://github.com/apache/incubator-iceberg/issues/245#issuecomment-571724202
@rdblue Sure, I will open a PR shortly.
--
rdblue commented on a change in pull request #227: ORC column map fix
URL: https://github.com/apache/incubator-iceberg/pull/227#discussion_r363900026
##
File path: orc/src/main/java/org/apache/iceberg/orc/OrcFileAppender.java
##
@@ -126,12 +100,14 @@ public long length() {
rdblue commented on a change in pull request #227: ORC column map fix
URL: https://github.com/apache/incubator-iceberg/pull/227#discussion_r363899690
##
File path: orc/src/test/java/org/apache/iceberg/orc/TestORCSchemaUtil.java
##
@@ -0,0 +1,231 @@
+/*
+ * Licensed to the A
rdblue commented on a change in pull request #675: [WIP] Inherit snapshot ids
URL: https://github.com/apache/incubator-iceberg/pull/675#discussion_r363898394
##
File path: core/src/main/java/org/apache/iceberg/DataTableScan.java
##
@@ -83,9 +83,7 @@ protected TableScan newR
rdblue commented on issue #675: [WIP] Inherit snapshot ids
URL: https://github.com/apache/incubator-iceberg/pull/675#issuecomment-57178
Looks like this conflicts with the recent update to rewrite manifests. Can
you update, @aokolnychyi?
-
rdblue commented on a change in pull request #675: [WIP] Inherit snapshot ids
URL: https://github.com/apache/incubator-iceberg/pull/675#discussion_r363898297
##
File path: core/src/main/java/org/apache/iceberg/MergeAppend.java
##
@@ -49,6 +50,9 @@ public MergeAppend appendF
rdblue commented on a change in pull request #675: [WIP] Inherit snapshot ids
URL: https://github.com/apache/incubator-iceberg/pull/675#discussion_r363897222
##
File path:
core/src/main/java/org/apache/iceberg/GenericPartitionFieldSummary.java
##
@@ -135,9 +136,9 @@ public
rdblue commented on a change in pull request #675: [WIP] Inherit snapshot ids
URL: https://github.com/apache/incubator-iceberg/pull/675#discussion_r363896910
##
File path: core/src/main/java/org/apache/iceberg/FastAppend.java
##
@@ -120,12 +131,6 @@ protected void cleanUnco
rdblue commented on issue #499: Add persistent IDs to partition fields (WIP)
URL: https://github.com/apache/incubator-iceberg/pull/499#issuecomment-571720086
Thanks for working on it, @manishmalhotrawork. If you do open a new PR,
please remember to close this one. Up to you which one you wa
aokolnychyi commented on issue #666: BaseRewriteManifests should keep different
manifest for different partitionSpec
URL: https://github.com/apache/incubator-iceberg/pull/666#issuecomment-571718643
Yes, that is absolutely independent of this PR. I've created #726 so that we
don't forget.
aokolnychyi opened a new issue #726: Improve multi-threading in
BaseRewriteManifests
URL: https://github.com/apache/incubator-iceberg/issues/726
I think we should revisit multi-threading logic in `BaseRewriteManifests` as
we are using a thread pool but all methods in `WriterWrapper` are sy
rdblue commented on issue #666: BaseRewriteManifests should keep different
manifest for different partitionSpec
URL: https://github.com/apache/incubator-iceberg/pull/666#issuecomment-571716633
@aokolnychyi, I agree that we can improve multi-threading.
@manishmalhotrawork is right that we s
rdblue merged pull request #725: Fix api java doc errors.
URL: https://github.com/apache/incubator-iceberg/pull/725
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
aokolnychyi commented on issue #666: BaseRewriteManifests should keep different
manifest for different partitionSpec
URL: https://github.com/apache/incubator-iceberg/pull/666#issuecomment-571715333
Thanks for the work, @manishmalhotrawork!
@rdblue @manishmalhotrawork, what do you thi
rdblue commented on issue #725: Fix api java doc errors.
URL: https://github.com/apache/incubator-iceberg/pull/725#issuecomment-571715618
Looks good to me. Thanks for catching these, @jun-he!
This is an automated message from
rdblue closed issue #480: Don't group files with different partition specs in
BaseRewriteManifests
URL: https://github.com/apache/incubator-iceberg/issues/480
This is an automated message from the Apache Git Service.
To resp
rdblue commented on issue #666: BaseRewriteManifests should keep different
manifest for different partitionSpec
URL: https://github.com/apache/incubator-iceberg/pull/666#issuecomment-571713581
Thanks for fixing this, @manishmalhotrawork! Nice job.
--
rdblue merged pull request #666: BaseRewriteManifests should keep different
manifest for different partitionSpec
URL: https://github.com/apache/incubator-iceberg/pull/666
This is an automated message from the Apache Git Serv
rdblue commented on issue #245: java.lang.NoSuchMethodError:
com.google.common.base.Preconditions.checkArgument(ZLjava/lang/String;Ljava/lang/Object;)V
URL:
https://github.com/apache/incubator-iceberg/issues/245#issuecomment-571710985
@Voltir, that sounds fine to me. I don't think I saw th
Voltir commented on issue #245: java.lang.NoSuchMethodError:
com.google.common.base.Preconditions.checkArgument(ZLjava/lang/String;Ljava/lang/Object;)V
URL:
https://github.com/apache/incubator-iceberg/issues/245#issuecomment-571710205
@rdblue I know this issue appears to be closed, but I n
aokolnychyi commented on a change in pull request #675: [WIP] Inherit snapshot
ids
URL: https://github.com/apache/incubator-iceberg/pull/675#discussion_r363719489
##
File path: core/src/main/java/org/apache/iceberg/FastAppend.java
##
@@ -120,12 +131,6 @@ protected void cle
fbocse commented on a change in pull request #721: Add PreferredLocations
support for Iceberg Spark Source
URL: https://github.com/apache/incubator-iceberg/pull/721#discussion_r363768943
##
File path: spark/src/main/java/org/apache/iceberg/spark/source/Reader.java
##
@@ -3
aokolnychyi commented on a change in pull request #675: [WIP] Inherit snapshot
ids
URL: https://github.com/apache/incubator-iceberg/pull/675#discussion_r363719489
##
File path: core/src/main/java/org/apache/iceberg/FastAppend.java
##
@@ -120,12 +131,6 @@ protected void cle
aokolnychyi commented on a change in pull request #675: [WIP] Inherit snapshot
ids
URL: https://github.com/apache/incubator-iceberg/pull/675#discussion_r363719489
##
File path: core/src/main/java/org/apache/iceberg/FastAppend.java
##
@@ -120,12 +131,6 @@ protected void cle
aokolnychyi commented on a change in pull request #675: [WIP] Inherit snapshot
ids
URL: https://github.com/apache/incubator-iceberg/pull/675#discussion_r363696782
##
File path: core/src/main/java/org/apache/iceberg/FastAppend.java
##
@@ -120,12 +131,6 @@ protected void cle
aokolnychyi commented on issue #675: [WIP] Inherit snapshot ids
URL: https://github.com/apache/incubator-iceberg/pull/675#issuecomment-571518782
I've updated this PR with some recent progress. I am working on tests. In
addition, there are a couple of open points to discuss.
---
aokolnychyi commented on a change in pull request #675: [WIP] Inherit snapshot
ids
URL: https://github.com/apache/incubator-iceberg/pull/675#discussion_r363631929
##
File path: core/src/main/java/org/apache/iceberg/RemoveSnapshots.java
##
@@ -325,4 +324,10 @@ private void
aokolnychyi commented on a change in pull request #675: [WIP] Inherit snapshot
ids
URL: https://github.com/apache/incubator-iceberg/pull/675#discussion_r363631628
##
File path: core/src/test/java/org/apache/iceberg/TestMergeAppend.java
##
@@ -471,24 +471,6 @@ public void t
37 matches
Mail list logo
