[GitHub] [incubator-iceberg] chenjunjiedada commented on a change in pull request #830: Support name mapping resolution for parquet

chenjunjiedada commented on a change in pull request #830: Support name mapping resolution for parquet URL: https://github.com/apache/incubator-iceberg/pull/830#discussion_r391095490 ## File path: api/src/main/java/org/apache/iceberg/types/TypeUtil.java ## @@ -190,7 +191,7

[GitHub] [incubator-iceberg] chenjunjiedada commented on issue #833: make fieldIds in SchemaVisitor thread safe

chenjunjiedada commented on issue #833: make fieldIds in SchemaVisitor thread safe URL: https://github.com/apache/incubator-iceberg/pull/833#issuecomment-597728192 Thanks, I got it. Will update this later. This is an automate

[GitHub] [incubator-iceberg] rdblue commented on issue #833: make fieldIds in SchemaVisitor thread safe

rdblue commented on issue #833: make fieldIds in SchemaVisitor thread safe URL: https://github.com/apache/incubator-iceberg/pull/833#issuecomment-597723370 @chenjunjiedada, you're right that we do need the id to produce the record name. That doesn't mean that we need to include the field id

[GitHub] [incubator-iceberg] rdsr commented on a change in pull request #778: ORC: Implement TestGenericData and fix reader and writer issues

rdsr commented on a change in pull request #778: ORC: Implement TestGenericData and fix reader and writer issues URL: https://github.com/apache/incubator-iceberg/pull/778#discussion_r391022621 ## File path: site/docs/spec.md ## @@ -483,25 +483,25 @@ Lists must use the [3-l

[GitHub] [incubator-iceberg] shardulm94 commented on a change in pull request #778: ORC: Implement TestGenericData and fix reader and writer issues

shardulm94 commented on a change in pull request #778: ORC: Implement TestGenericData and fix reader and writer issues URL: https://github.com/apache/incubator-iceberg/pull/778#discussion_r390946818 ## File path: site/docs/spec.md ## @@ -483,25 +483,25 @@ Lists must use th

[GitHub] [incubator-iceberg] chenjunjiedada edited a comment on issue #833: make fieldIds in SchemaVisitor thread safe

chenjunjiedada edited a comment on issue #833: make fieldIds in SchemaVisitor thread safe URL: https://github.com/apache/incubator-iceberg/pull/833#issuecomment-597525476 Thanks @rdblue for the explanation. I walked through the code path and found that we still need the `id` to for

[GitHub] [incubator-iceberg] chenjunjiedada commented on issue #833: make fieldIds in SchemaVisitor thread safe

chenjunjiedada commented on issue #833: make fieldIds in SchemaVisitor thread safe URL: https://github.com/apache/incubator-iceberg/pull/833#issuecomment-597525476 Thanks @rdblue for the explanation. I walked through the code path and found that we still need the `id` to for the rec